[bitcoind] Transaction fees: One annoying shit i have stumbled upon

[2112]

Can you please point me to the exact source (line of code) ?
I will also remove it from my fork.

I didn't know that fee-skimming scams got so serious these days.

Sorry, no. Please compare 0.3.24 to 0.3.23. The example of the bug:
You have 10.0007 in the wallet and configure it to pay 0.0005 fee. You send 10 plus 0.0005 fee
and expect the wallet to retain the remaining 0.0002. Psych! It went to the miners and your wallet is empty.

The "serious" part mostly pertains to the "conspiracy" part. Traditionally, charges of conspiracy were made when the people involved modified the off-the-shelf accounting software. When "off-the-shelf" really means "off-the-sourceforge" the conspiracy charges are an easy add-on for the plaintiff lawyers.

[1715700692]

1715700692

[1715700692]

1715700692

[1715700692]

1715700692

[1715700692]

1715700692

[2112]

The "change is too small to go to wallet, let's send it to the miner" thing on itself wasn't a bug.

The problem was that 0.3.24 reintroduced a bug where that calculation went wrong, and occasionally up to 0.01 BTC would be sent as fee (instead of 0.0005 BTC). It's fixed in 0.4, by the way.

I apologise for the misrepresentation. I misunderstood somebody's else description. I never looked at the 0.3.24 code. I went straight from 0.3.23 to 0.4rc2. Sorry.

[ShadowOfHarbringer]

The problem was that 0.3.24 reintroduced a bug where that calculation went wrong, and occasionally up to 0.01 BTC would be sent as fee (instead of 0.0005 BTC). It's fixed in 0.4, by the way.

Can you point me to the particular piece of code ?

[Pieter Wuille]

The problem was that 0.3.24 reintroduced a bug where that calculation went wrong, and occasionally up to 0.01 BTC would be sent as fee (instead of 0.0005 BTC). It's fixed in 0.4, by the way.

Can you point me to the particular piece of code ?

This commit fixes it: https://github.com/bitcoin/bitcoin/commit/b6d19aefa0cf455dca57ca74eeb75e158a9390d0.

[ShadowOfHarbringer]

The problem was that 0.3.24 reintroduced a bug where that calculation went wrong, and occasionally up to 0.01 BTC would be sent as fee (instead of 0.0005 BTC). It's fixed in 0.4, by the way.

Can you point me to the particular piece of code ?

This commit fixes it: https://github.com/bitcoin/bitcoin/commit/b6d19aefa0cf455dca57ca74eeb75e158a9390d0.

Excellent, thanks.
I will merge it into my fork.

Hopefully, it won't be too difficult for me to merge it into older versions also (< 0.3.24).

Update:
I checked and my forked version already contains this patch, but thanks nevertheless.

Edit2:
I will now try to apply it from trunk into nftf-0.3.24 branch and older versions.

Edit3:
I successfully merged the patch into following branches:

https://github.com/ShadowOfHarbringer/bitcoin-nftf/tree/nftf-0.3.21
https://github.com/ShadowOfHarbringer/bitcoin-nftf/tree/nftf-0.3.22
https://github.com/ShadowOfHarbringer/bitcoin-nftf/tree/nftf-0.3.23 (was already patched)
https://github.com/ShadowOfHarbringer/bitcoin-nftf/tree/nftf-0.3.24

I added proper announcement:
https://bitcointalk.org/index.php?topic=22434.40