Bitcoin Forum
December 11, 2016, 10:17:27 AM *
News: To be able to use the next phase of the beta forum software, please ensure that your email address is correct/functional.
 
   Home   Help Search Donate Login Register  
Pages: [1]
  Print  
Author Topic: Has someone actually revised the entire code?  (Read 1642 times)
kristoffernolgren
Newbie
*
Offline Offline

Activity: 23


View Profile
April 28, 2011, 01:59:43 PM
 #1

So the code is open-source and revisable wich is good, but has someomne actully looked through the entire code? 
1481451447
Hero Member
*
Offline Offline

Posts: 1481451447

View Profile Personal Message (Offline)

Ignore
1481451447
Reply with quote  #2

1481451447
Report to moderator
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction. Advertise here.
Mike Hearn
Legendary
*
expert
Offline Offline

Activity: 1526


View Profile
April 28, 2011, 02:12:38 PM
 #2

I've looked through most of it. All the important parts for payment verification anyway. I think a few others have too (Hal, for one).

Now, that doesn't mean I'm fully convinced it's correct. BitCoin is VERY complicated.
khal
Hero Member
*****
Offline Offline

Activity: 538


NamecoinID: id/khal


View Profile WWW
April 28, 2011, 02:15:34 PM
 #3

Several people are working on different bitoin parts and propose patches (see : https://github.com/bitcoin/bitcoin/pulls).
So we can't say with that that all code has been reviewed, but it's a good start :p

NMC: N1KHAL5C1CRzy58NdJwp1tbLze3XrkFxx9 | NamecoinID: id/khal | Register .bit domain
BTC: 1KHAL8bUjnkMRMg9yd2dNrYnJgZGH8Nj6T | My bitcoin Identity: send messages to bitcoin users
Free bitcoins: Surf4Bitcoin.com | Charity Ad: Make a good deed without paying a cent
asdf
Hero Member
*****
Offline Offline

Activity: 527


View Profile
April 28, 2011, 02:47:59 PM
 #4

Many people have each revised parts of the code. Every part of the code has been revised by someone. good enough?
ribuck
Donator
Legendary
*
Offline Offline

Activity: 826


View Profile
April 28, 2011, 03:00:39 PM
 #5

Many people have each revised parts of the code. Every part of the code has been revised by someone. good enough?
You don't get total coverage by separately reviewing every part of the code, because the different parts of the code may interact in ways that were not anticipated.
LZ
Staff
Legendary
*
Offline Offline

Activity: 1456


Satoshi everywhere!


View Profile WWW
April 29, 2011, 09:38:56 AM
 #6

I've looked through most of it. All the important parts for payment verification anyway.
What you think about the 0.3.21 release? It seems that it requires mandatory fee. Undecided

"Never invest unless you can afford to lose your entire investment." © S3052
wumpus
Hero Member
*****
qt
Offline Offline

Activity: 798

No Maps for These Territories


View Profile
April 29, 2011, 10:37:07 AM
 #7

There is even a guy who implemented an entire bitcoin client in Java, so I guess he's looked at the entire source.

https://code.google.com/p/bitcoinj/

Bitcoin Core developer [PGP] Warning: For most, coin loss is a larger risk than coin theft. A disk can die any time. Regularly back up your wallet through FileBackup Wallet to an external storage or the (encrypted!) cloud. Use a separate offline wallet for storing larger amounts.
Pieter Wuille
Legendary
*
qt
Offline Offline

Activity: 1036


View Profile WWW
April 29, 2011, 10:37:53 AM
 #8

There is even a guy who implemented an entire bitcoin client in Java, so I guess he's looked at the entire source.

https://code.google.com/p/bitcoinj/

That guy was even the first to respond in this thread Smiley

aka sipa, core dev team

Tips and donations: 1KwDYMJMS4xq3ZEWYfdBRwYG2fHwhZsipa
wumpus
Hero Member
*****
qt
Offline Offline

Activity: 798

No Maps for These Territories


View Profile
April 29, 2011, 10:43:02 AM
 #9

Ha, didn't know his forum name Smiley

Bitcoin Core developer [PGP] Warning: For most, coin loss is a larger risk than coin theft. A disk can die any time. Regularly back up your wallet through FileBackup Wallet to an external storage or the (encrypted!) cloud. Use a separate offline wallet for storing larger amounts.
xf2_org
Member
**
Offline Offline

Activity: 70


View Profile
April 30, 2011, 12:37:51 AM
 #10

I've looked through most of it. All the important parts for payment verification anyway.
What you think about the 0.3.21 release? It seems that it requires mandatory fee. Undecided

Not sure what you mean by this?  Normal transactions remain free.

ShadowOfHarbringer
Legendary
*
Offline Offline

Activity: 1470


Bringing Legendary Har® to you since 1952


View Profile
April 30, 2011, 09:20:07 AM
 #11

I've looked through most of it. All the important parts for payment verification anyway.
What you think about the 0.3.21 release? It seems that it requires mandatory fee. Undecided

??

Explain.

Cdecker
Hero Member
*****
Offline Offline

Activity: 487



View Profile WWW
April 30, 2011, 10:54:34 AM
 #12

We could pass all revisions through Gerrit to enforce Code review and sign-off... Cheesy

Want to see what developers are chatting about? http://bitcoinstats.com/irc/bitcoin-dev/logs/
Bitcoin-OTC Rating
LZ
Staff
Legendary
*
Offline Offline

Activity: 1456


Satoshi everywhere!


View Profile WWW
April 30, 2011, 11:19:55 AM
 #13

Steps to reproduce:
1) withdraw X BTC from Mt.Gox;
2) then you will get it with 0.3.21;
3) try to send it to some address.

If you will close 0.3.21 and run <0.3.21 - it will send without any fee.

"Never invest unless you can afford to lose your entire investment." © S3052
Matt Corallo
Hero Member
*****
expert
Offline Offline

Activity: 751


View Profile
April 30, 2011, 11:27:38 AM
 #14

Steps to reproduce:
1) withdraw X BTC from Mt.Gox;
2) then you will get it with 0.3.21;
3) try to send it to some address.

If you will close 0.3.21 and run <0.3.21 - it will send without any fee.
Not the right thread, and gavin answered it at http://bitcointalk.org/index.php?topic=6642.msg99523#msg99523

Bitcoin Ubuntu PPA maintainer - donate to me personally: 1JBMattRztKDF2KRS3vhjJXA7h47NEsn2c
http://bitcoinrelaynetwork.org maintainer
PGP ID: 07DF 3E57 A548 CCFB 7530  7091 89BB B866 3E2E65CE
LZ
Staff
Legendary
*
Offline Offline

Activity: 1456


Satoshi everywhere!


View Profile WWW
April 30, 2011, 11:43:32 AM
 #15

Yeah, you are right, sorry about that. It is not the right thread. I just read Gavin's answer. Thanks.

"Never invest unless you can afford to lose your entire investment." © S3052
Pages: [1]
  Print  
 
Jump to:  

Sponsored by , a Bitcoin-accepting VPN.
Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!