kristoffernolgren (OP)
Newbie
 Offline
Activity: 23
Merit: 0
|
 |
April 28, 2011, 01:59:43 PM |
|
So the code is open-source and revisable wich is good, but has someomne actully looked through the entire code?
|
|
|
|
|
|
|
|
|
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction.
|
|
|
Mike Hearn
Legendary
Offline
Activity: 1526
Merit: 1129
|
|
April 28, 2011, 02:12:38 PM |
|
I've looked through most of it. All the important parts for payment verification anyway. I think a few others have too (Hal, for one).
Now, that doesn't mean I'm fully convinced it's correct. BitCoin is VERY complicated.
|
|
|
|
|
|
khal
|
|
April 28, 2011, 02:15:34 PM |
|
Several people are working on different bitoin parts and propose patches (see : https://github.com/bitcoin/bitcoin/pulls). So we can't say with that that all code has been reviewed, but it's a good start :p |
|
|
|
|
|
asdf
|
|
April 28, 2011, 02:47:59 PM |
|
Many people have each revised parts of the code. Every part of the code has been revised by someone. good enough?
|
|
|
|
|
ribuck
Donator
Hero Member
Offline
Activity: 826
Merit: 1039
|
|
April 28, 2011, 03:00:39 PM |
|
Many people have each revised parts of the code. Every part of the code has been revised by someone. good enough?
You don't get total coverage by separately reviewing every part of the code, because the different parts of the code may interact in ways that were not anticipated. |
|
|
|
|
LZ
Legendary
Offline
Activity: 1722
Merit: 1072
P2P Cryptocurrency
|
|
April 29, 2011, 09:38:56 AM |
|
I've looked through most of it. All the important parts for payment verification anyway. What you think about the 0.3.21 release? It seems that it requires mandatory fee.  |
My OpenPGP fingerprint: 5099EB8C0F2E68C63B4ECBB9A9D0993E04143362
|
|
|
|
wumpus
|
|
April 29, 2011, 10:37:07 AM |
|
There is even a guy who implemented an entire bitcoin client in Java, so I guess he's looked at the entire source. https://code.google.com/p/bitcoinj/ |
Bitcoin Core developer [PGP] Warning: For most, coin loss is a larger risk than coin theft. A disk can die any time. Regularly back up your wallet through File → Backup Wallet to an external storage or the (encrypted!) cloud. Use a separate offline wallet for storing larger amounts. |
|
|
|
Pieter Wuille
|
|
April 29, 2011, 10:37:53 AM |
|
That guy was even the first to respond in this thread  |
I do Bitcoin stuff.
|
|
|
|
wumpus
|
|
April 29, 2011, 10:43:02 AM |
|
Ha, didn't know his forum name |
Bitcoin Core developer [PGP] Warning: For most, coin loss is a larger risk than coin theft. A disk can die any time. Regularly back up your wallet through File → Backup Wallet to an external storage or the (encrypted!) cloud. Use a separate offline wallet for storing larger amounts. |
|
|
xf2_org
Member
Offline
Activity: 98
Merit: 13
|
|
April 30, 2011, 12:37:51 AM |
|
I've looked through most of it. All the important parts for payment verification anyway. What you think about the 0.3.21 release? It seems that it requires mandatory fee. Not sure what you mean by this? Normal transactions remain free. |
|
|
|
|
ShadowOfHarbringer
Legendary
Offline
Activity: 1470
Merit: 1005
Bringing Legendary Har® to you since 1952
|
|
April 30, 2011, 09:20:07 AM |
|
I've looked through most of it. All the important parts for payment verification anyway. What you think about the 0.3.21 release? It seems that it requires mandatory fee. ?? Explain. |
|
|
|
|
Cdecker
|
|
April 30, 2011, 10:54:34 AM |
|
We could pass all revisions through Gerrit to enforce Code review and sign-off...  |
|
|
|
LZ
Legendary
Offline
Activity: 1722
Merit: 1072
P2P Cryptocurrency
|
|
April 30, 2011, 11:19:55 AM |
|
Steps to reproduce:
1) withdraw X BTC from Mt.Gox;
2) then you will get it with 0.3.21;
3) try to send it to some address.
If you will close 0.3.21 and run <0.3.21 - it will send without any fee.
|
My OpenPGP fingerprint: 5099EB8C0F2E68C63B4ECBB9A9D0993E04143362
|
|
|
|
|
LZ
Legendary
Offline
Activity: 1722
Merit: 1072
P2P Cryptocurrency
|
|
April 30, 2011, 11:43:32 AM |
|
Yeah, you are right, sorry about that. It is not the right thread. I just read Gavin's answer. Thanks.
|
My OpenPGP fingerprint: 5099EB8C0F2E68C63B4ECBB9A9D0993E04143362
|
|
|
|
