Identifying the linked-to post in a topic (SMF patch)

[ibminer]

That's a cool idea (that is, using a content string on a ::before pseudo-element), but, besides the advantage of avoiding adding a <span> element (which, all concerned parties seem to agree will either not disturb, or be pretty easy to adjust their parsers for), there are a few drawbacks (in no particular order):
~

The other advantage went back to the customized style sheets people may be using, in the pseudo-element scenario using Style B, they'd have the ability to change the symbol/content.

The pseudo-element wouldn't have to happen on <a> though, I initially picked that because it was the line of code you were modifying in the patch, but it makes more sense on the <div> above that, to avoid the link interference.

Although, I'm kinda liking the black version on Style C myself now. But, if Style B makes it, I'd prefer the one-time use of the CSS as opposed to the <span> there, but that's just me... I guess I understand not wanting to add a 3rd file into the mix.

[theymos]

I like the idea. All proposed styles seem OK to me, though some alternative styling ideas which come to mind are:
 - Change the color of the entire post <tr>, using a different color than the usual alternating blue and grey (but not too different).
 - Add a little red(?) asterisk or something in the lower-right corner of the post icon (ie. td.td_headerandpost table tbody tr td a img).

When you open the HTML source of this page for example, there are a bunch of "shadow" posts under the OP. These are invisible posts that have the same HTML structure as real posts, but they don't have anything inside them. There is usually a random amount of these displayed, anywhere from one to three. So what is the deal with that, and where do they come from?

Those are decoy posts meant to confuse adblockers. This is also why a lot of the CSS classes randomize on each pageload. Now that there are no ads, I could remove both of these things. Would doing so break anyone's parsers?

[PowerGlove]

- Change the color of the entire post <tr>, using a different color than the usual alternating blue and grey (but not too different).

Yep. That's pretty much the first thing I tried, but, I couldn't find a color that struck a nice balance between (effectively) highlighting the post, and not drifting too far away from the SMF aesthetic. Maybe I wasn't persistent enough, and someone else might have better luck, but every time I managed to get the post to stand out, it looked ugly/wrong to me, and every time I managed to make it look nice/right, the post didn't really stand out.

- Add a little red(?) asterisk or something in the lower-right corner of the post icon (ie. td.td_headerandpost table tbody tr td a img).

Messing with the post icon is a cool idea...

Maybe this one's too subtle, but, a drop shadow on the icon looks kind of nice:



(That's a style="filter: drop-shadow(0 0 2px #355d8099);" on the <img> element; the #355d8099 is a 60% opacity dark/desaturated blue that I color-picked from the top-most gradient on the SMF menu.)

[joker_josue]

- Change the color of the entire post <tr>, using a different color than the usual alternating blue and grey (but not too different).

Yep. That's pretty much the first thing I tried, but, I couldn't find a color that struck a nice balance between (effectively) highlighting the post, and not drifting too far away from the SMF aesthetic. Maybe I wasn't persistent enough, and someone else might have better luck, but every time I managed to get the post to stand out, it looked ugly/wrong to me, and every time I managed to make it look nice/right, the post didn't really stand out.

What do you think if it's something like this:

Code:

bgcolor=#F7F8E0

Another more or less equivalent tone can be used. I don't think it gave much, and would only be applied in this specific scenario.

[ibminer]

If you can do something on the <td> with the entire post, maybe a simple border on the left/right:

Code:

border-left: 2px solid #537798;
border-right: 2px solid #537798;

edit:

maybe a little thicker:

[joker_josue]

If you can do something on the <td> with the entire post, maybe a simple border on the left/right:

Code:

border-left: 2px solid #537798;
border-right: 2px solid #537798;

It's also a good idea. But I didn't limit the highlights to the left and right border. It would include the top and bottom.

[LoyceV]

Those are decoy posts meant to confuse adblockers. This is also why a lot of the CSS classes randomize on each pageload. Now that there are no ads, I could remove both of these things. Would doing so break anyone's parsers?

I don't expect to have any problems with this.

[ibminer]

If you can do something on the <td> with the entire post, maybe a simple border on the left/right:

Code:

border-left: 2px solid #537798;
border-right: 2px solid #537798;

It's also a good idea. But I didn't limit the highlights to the left and right border. It would include the top and bottom.

I tried a border on the top/bottom as well but it felt too loud, with all of the other horizontal lines going on with quotes, posts, banner/sigs, etc. I don't mind the bgcolor on the title though, sort of what I was trying to do here. The yellow isn't too bad on a mobile device, but on a desktop the long yellow strip feels too much, for me at least.

- Change the color of the entire post <tr>, using a different color than the usual alternating blue and grey (but not too different).

Maybe a minor issue, but this could effect any styling/colors on a post that a user created to go with the current grey/blue. Also, this could lead to a way for a user to create text using whatever color is chosen, which would look normal on the thread, but a linked version to the post could then visually hide that text.

~Would doing so break anyone's parsers?

Looks good here. We're mainly using pages where these hidden posts don't exist anyway so it shouldn't effect BPIP's parsers.

--
I'm liking the thicker side borders myself, but I'm biased.

[joker_josue]

I tried a border on the top/bottom as well but it felt too loud, with all of the other horizontal lines going on with quotes, posts, banner/sigs, etc. I don't mind the bgcolor on the title though, sort of what I was trying to do here. The yellow isn't too bad on a mobile device, but on a desktop the long yellow strip feels too much, for me at least.

This option can also be interesting, but without the border. And in terms of color, you can use the same tone of blue that is used in the posts, with two shades interspersed. Placing the respective post, with the header having a different tone from the rest of the post.

I don't know if I made myself understood, but I'm a little lazy to take some images. Maybe later. 

[PowerGlove]

Hmm... I never noticed that the last (bold-faced) item in the link-tree is an actual link:



It has its text-decoration set to none and its cursor set to default, so it's easy to miss, I guess, but it kind of makes sense in a weird way; it's like it's saying: "this is where you are, yo."

Anyway, if that's an idea that's worth repeating, then the second diff for style C should be like this:

Code:

--- baseline/Themes/default/Display.template.php	2010-10-22 01:38:35.000000000 +0000
+++ modified/Themes/default/Display.template.php	2024-04-11 01:21:29.000000000 +0000
@@ -359,33 +359,34 @@
 					echo '
 								<a href="', $scripturl, '?action=pm;sa=send;u=', $message['member']['id'], '" title="', $message['member']['online']['label'], '">', $settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/im_' . ($message['member']['online']['is_online'] ? 'on' : 'off') . '.gif" alt="' . $message['member']['online']['label'] . '" border="0" />' : $message['member']['online']['label'], '</a>';
 			}
 		}
 		// Otherwise, show the guest's email.
 		elseif (empty($message['member']['hide_email']))
 			echo '
 								<br />
 								<br />
 								<a href="mailto:', $message['member']['email'], '">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/email_sm.gif" alt="' . $txt[69] . '" title="' . $txt[69] . '" border="0" />' : $txt[69]), '</a>';
 
 		// Done with the information about the poster... on to the post itself.
+		$is_requested_message = isset($context['requested_msg']) && $context['requested_msg'] == $message['id'];
 		echo '
 							</div>
 						</td>
 						<td valign="top" width="85%" height="100%">
 							<table width="100%" border="0"><tr>
 								<td valign="middle"><a href="', $message['href'], '"><img src="', $message['icon_url'] . '" alt="" border="0" /></a></td>
 								<td valign="middle">
 									<div style="font-weight: bold;" id="subject_', $message['id'], '">
-										<a href="', $message['href'], '">', $message['subject'], '</a>
+										<a ', $is_requested_message ? 'style="color: black; text-decoration: none; cursor: default;" ' : '', 'href="', $message['href'], '">', $message['subject'], '</a>
 									</div>';
 
 		// If this is the first post, (#0) just say when it was posted - otherwise give the reply #.
 		echo '
 									<div class="smalltext">&#171; <b>', !empty($message['counter']) ? $txt[146] . ' #' . $message['counter'] : '', ' ', $txt[30], ':</b> ', $message['time'], ' &#187;</div></td>
 								<td align="', !$context['right_to_left'] ? 'right' : 'left', '" valign="bottom" height="20" style="font-size: smaller;">';
 
 		// Can they reply? Have they turned on quick reply?
 		if ($context['can_reply'] && !empty($options['display_quick_reply']))
 			echo '
 					<a href="', $scripturl, '?action=post;quote=', $message['id'], ';topic=', $context['current_topic'], '.', $context['start'], ';num_replies=', $context['num_replies'], ';sesc=', $context['session_id'], '" onclick="doQuote(', $message['id'], ', \'', $context['session_id'], '\'); return false;">', $reply_button, '</a>';

(I see references in SMF to a "nav" class for the link-tree, and a reference to a "navPages" class for the page-list; makes me think that the idiomatic way to repeat this idea would be to add a "navMessage" class instead of doing this with an inline style.)

@theymos: I know this is off-topic, but, seeing as though you're watching the thread, and while I've got links on my mind: if/when you find some time, maybe you could quickly tackle this one? (I think that suggestion makes a lot of sense; when LoyceV first mentioned it, I remember thinking: "Ooh, that's a nice little improvement.")

P.S. I blew all of my theymos-sMerit on your April Fools gag, so I won't be able to merit your posts for a bit.

[joker_josue]

Hmm... I never noticed that the last (bold-faced) item in the link-tree is an actual link:



It has its text-decoration set to none and its cursor set to default, so it's easy to miss, I guess, but it kind of makes sense in a weird way; it's like it's saying: "this is where you are, yo."

Anyway, if that's an idea that's worth repeating, then the second diff for style C should be like this:

I'm sorry, but I didn't notice your adjustment to the proposal. 

What does the link-tree have to do with the title of the post?

[LoyceV]

Hmm... I never noticed that the last (bold-faced) item in the link-tree is an actual link:

You and me both, I didn't know it until you wrote it I read it here.

It has its text-decoration set to none and its cursor set to default, so it's easy to miss, I guess, but it kind of makes sense in a weird way; it's like it's saying: "this is where you are, yo."

Anyway, if that's an idea that's worth repeating

I like this one. It distinguishes the post, you could (if you know it exists....) right-click it to copy the link, and it still shows a direct link on the URL bar.

What does the link-tree have to do with the title of the post?

The title of the post could have the same style.

[joker_josue]

What does the link-tree have to do with the title of the post?

The title of the post could have the same style.

OK. Also put the title of the post in black.
It would be a described change that could help with this identification, but perhaps many would not notice the difference.

Now, if it's the solution that involves fewer code changes, it seems like a good solution to me.

[theymos]

Added, thanks! What looked best IMO was to do the arrow and black color, but without the text-decoration:none or cursor: default.

Also, while I was messing around with the topic HTML anyway, I decided to just completely remove the ad area. I don't foresee selling ads again anytime soon, and while maybe the factoids were providing some value, many of them were outdated.

[joker_josue]

Added, thanks! What looked best IMO was to do the arrow and black color, but without the text-decoration:none or cursor: default.

Also, while I was messing around with the topic HTML anyway, I decided to just completely remove the ad area. I don't foresee selling ads again anytime soon, and while maybe the factoids were providing some value, many of them were outdated.

The difference is confirmed! Thank you for accepting this change.

Old:

New:

Now, we just have to get used to this new thing.  

[NotFuzzyWarm]

Dang that was quickly done!
I like the new change.

[Synchronice]

Added, thanks! What looked best IMO was to do the arrow and black color, but without the text-decoration:none or cursor: default.

Also, while I was messing around with the topic HTML anyway, I decided to just completely remove the ad area. I don't foresee selling ads again anytime soon, and while maybe the factoids were providing some value, many of them were outdated.

I noticed this today when I checked reply on my post via Ninja's bot and I was like, am I tripping? Is this the first time I noticed this difference between quoted and other posts? But as it looks, this feature was implemented today. Nice, by the way it would be good if you convert tables into flexbox or grid because that would make this forum responsive. Just like I did here: https://bitcointalk.org/index.php?topic=5415839.msg61056851#msg61056851

What about community-updated factoid? I think that they were nice. It might surprise you but I love the idea of ads on this forum, it gives you a little break between original post and replies and also it's nice when you see something new displayed.

[LoyceV]

Added, thanks!

I got to your post by clicking:

Code:

https://bitcointalk.org/index.php?topic=5491546.msg64025684;topicseen#new

Shouldn't the post be black with this link too?

If I click the title of the post, I get:

Code:

https://bitcointalk.org/index.php?topic=5491546.msg64075749#msg64075749

This works as expected

On closer look, why does the "new" link have post #64025684 in the URL?

Let's test again:
"new":

Code:

https://bitcointalk.org/index.php?topic=5496329.msg64078469;topicseen#new

Post #64078469 is in a different topic:

Code:

https://bitcointalk.org/index.php?topic=5495745.msg64078469#msg64078469

Something's wrong

[joker_josue]

Let's test again:
"new":

Code:

https://bitcointalk.org/index.php?topic=5496329.msg64078469;topicseen#new

Post #64078469 is in a different topic:

Code:

https://bitcointalk.org/index.php?topic=5495745.msg64078469#msg64078469

Something's wrong

There is nothing wrong, it is working as intended.
The new graphics only appear when the link has #idpost, in other cases it remains normal.

This is because what gives the order to the browser to apply another graphic is the address ending with #idpost.
Because ;topicseen#new varies from post to post. In other words, it always points to the last post, regardless of the author of the post.

It's true that this could be adjusted, but I don't think it's that relevant.

[LoyceV]

There is nothing wrong

Compare the msgID in both URLs from my code-tags. Then open both URLs. I don't get where the "new" msgID comes from.