Armory 0.93 testing release! (with 0.05 BTC bug bounty)

[doug_armory]

Armory secure downloader for OS X is broken, when it finishes it won't let me save the file. It just displays a box with the file name and the folder to save it in, it's not a file browser, then I can't even save it.

Grrr! It's doing this on my system too. Must have something to do with how windows are handled. In any event, I'll put the Qt file dialog back for now.

I manually download it, then on top of that it 0.92.99.4 won't even open!

Code:

2015-01-27 21:54 (ERROR) -- Traceback (most recent call last):
  File "/Applications/Armory.app/Contents/MacOS/py/usr/lib/armory/ArmoryQt.py", line 40, in <module>
    from announcefetch import AnnounceDataFetcher, ANNOUNCE_URL, ANNOUNCE_URL_BACKUP, \
  File "/Applications/Armory.app/Contents/MacOS/py/usr/lib/armory/announcefetch.py", line 8, in <module>
    from armoryengine.ALL import *
  File "/Applications/Armory.app/Contents/MacOS/py/usr/lib/armory/armoryengine/ALL.py", line 10, in <module>
    from armoryengine.BDM import *
  File "/Applications/Armory.app/Contents/MacOS/py/usr/lib/armory/armoryengine/BDM.py", line 413, in <module>
    TheBDM = BlockDataManager(isOffline=False)
  File "/Applications/Armory.app/Contents/MacOS/py/usr/lib/armory/armoryengine/BDM.py", line 163, in __init__
    self.callback = PySide_CallBack(self).__disown__()
  File "/Applications/Armory.app/Contents/MacOS/py/usr/lib/armory/armoryengine/BDM.py", line 43, in __init__
    self.bdm = bdm
  File "/Applications/Armory.app/Contents/MacOS/py/usr/lib/armory/CppBlockUtils.py", line 4075, in <lambda>
    __setattr__ = lambda self, name, value: _swig_setattr(self, BDM_CallBack, name, value)
  File "/Applications/Armory.app/Contents/MacOS/py/usr/lib/armory/CppBlockUtils.py", line 51, in _swig_setattr
    return _swig_setattr_nondynamic(self, class_type, name, value, 0)
  File "/Applications/Armory.app/Contents/MacOS/py/usr/lib/armory/CppBlockUtils.py", line 45, in _swig_setattr_nondynamic
    object.__setattr__(self, name, value)
TypeError: can't apply this __setattr__ to instance object

Displays that in the log every time I try to start Armory.

I'm seeing it too. The build system was upgraded as part of an attempt to determine if perhaps the file system problem would go away with an upgrade. Looks like the upgrade didn't go quite as planned, so no OS X love for .4. We'll get it straightened out for .5, or people can build their own versions.

[1714609587]

1714609587

[Newar]

[...]
I have uploaded .4 to S3, and also pushed the "v0.92.99.4-testing" signed tag.  Hopefully we're finally nearing a releasable state.
[...]

.4 (as .3) works fine as regular node on my Lubuntu 14.04. Catching up of two days with the blockchain (using QT 0.9.4) took an hour, but once that was done the rest was quick.

[bitpop]

.4 works!

[doug_armory]

I'm seeing it too. The build system was upgraded as part of an attempt to determine if perhaps the file system problem would go away with an upgrade. Looks like the upgrade didn't go quite as planned, so no OS X love for .4. We'll get it straightened out for .5, or people can build their own versions.

Problem found. .5 should work correctly. If anybody out there is rolling their own versions, you'll need to avoid the latest version of SWIG on brew (3.0.4) and use an earlier version (<= 3.0.2). brew switch swig 3.0.2 should do the trick.

[zombieslayer9099]

Also I noticed something in there called Webshop, what exactly is that?

[zombieslayer9099]

Bug: Opened .4 on my windows computer, displayed spendable funds as 184.4 billion BTC. Will rebuild+rescan database and see if that helps.

[doug_armory]

Also I noticed something in there called Webshop, what exactly is that?

It's experimental code designed to show how armoryd could integrate with a web store. Regular users need not worry about it. AFAIK, the code has to be explicitly called by the user in order for it to do anything.

[bitpop]

You should put a store inside armory to monetize, sell Trezor and shirts

[zombieslayer9099]

Found a new bug, this one has to do with transaction times
If the transaction is unconfirmed, it displays the time it was executed.
If it is confirmed, it displays the time the first confirming block was mined.

http://prntscr.com/5y8jrv - 6 TX's allegedly happening at the exact same time
http://prntscr.com/5y8ket - TX detail window in Armory, note the TXID
http://prntscr.com/5y8luc - Block 340257 info, note the time (the block the TX is in)
http://prntscr.com/5y8nqn - Proof that the TX (with the same TXID) did not happen at 11:49:22 pm

[etotheipi]

Found a new bug, this one has to do with transaction times
If the transaction is unconfirmed, it displays the time it was executed.
If it is confirmed, it displays the time the first confirming block was mined.

http://prntscr.com/5y8jrv
http://prntscr.com/5y8ket
http://prntscr.com/5y8luc
http://prntscr.com/5y8nqn

That's intended behavior.  How would you suggest dealing with it otherwise?  We don't store any tx data in the wallet, so there's no way to save the tx-received time between loads.  The best we can do is simply give it the first confirming block time.

[zombieslayer9099]

That's intended behavior.  How would you suggest dealing with it otherwise?  We don't store any tx data in the wallet, so there's no way to save the tx-received time between loads.  The best we can do is simply give it the first confirming block time.

Oh, my mistake.

I also have a couple of questions, what does each file in the databases directory contain, excluding 'blocks' and 'headers'?
And does supernode have the same HDD optimizations that fullnode has? Armory is estimating it will take me a full day to build supernode, but fullnode takes less than 1.5 hours?

[bitpop]

Will we ever get to spend unconfirmed inputs?

[etotheipi]

Will we ever get to spend unconfirmed inputs?

You technically already can... If they are from yourself :-)

We added a command line arg after the malleability issues that does the opposite... It makes ALL unconfirmed unspendable even if they came from yourself.  It would probably not be hard to switch it to make them spendable instead, but we won't be adding that to any official releases.

If you're interested, search for IGNOREZC in the codebase (maybe IGNORE_ZC)

[Dmitry Morozov]

I have imported wallet with small amount. But after scanning Armory shows zero balance.

[goatpig]

Done traveling, ugh airports...

I have imported wallet with small amount. But after scanning Armory shows zero balance.

With .4?

I also have a couple of questions, what does each file in the databases directory contain, excluding 'blocks' and 'headers'?
And does supernode have the same HDD optimizations that fullnode has? Armory is estimating it will take me a full day to build supernode, but fullnode takes less than 1.5 hours?

The different databases holding relevant data like blocks, transactions hints (hash to DB key), headers and your wallets history. Lock files are self explanatory. I will be rolling some of the HDD optimizations into supernode soon, but eventually supernode will always horribly slow on a HDD. HDDs fail at high random access loads, and while I mitigated data fragmentation with the HDD opts, supernode tracks too much random data to manage that.

At any rate, supernode node is meant for server backends and power users. You should stay away from it, unless you have tons of RAM and ~90 GB disk space to spare for the DB.

Bug: Opened .4 on my windows computer, displayed spendable funds as 184.4 billion BTC. Will rebuild+rescan database and see if that helps.

Rescan should be enough. Remember what you did to get there? Also did you delete your .3 DB before trying .4?

You should put a store inside armory to monetize, sell Trezor and shirts

The webshop is for armoryd (RPC Armory), it doesn't work with ArmoryQt (GUI Armory). Those are independent codebases, even though they share the same C++ lib.

It's meant to demonstrate Armory's capabilities as a server backend, we don't intent to bring any of that to GUI interface.

[Dmitry Morozov]

Done traveling, ugh airports...

I have imported wallet with small amount. But after scanning Armory shows zero balance.

With .4?

With .4, after I had deleted Armory database and rebuild it Armory becomes showing right wallet amount

[STRML]

With HEAD on the 0.93-bugfix branch, we an interesting error in a TXSIGCOLLECT generated by armoryd. If there was a change output, the change output was an old-style multisig script, rather than the new p2sh style. For example, this testnet transaction, and its decomposition:

Code:

python armoryd.py --testnet createlockboxustxtoaddress msj42CCGruhRsFrGATiUuh25dtxYtnpbTx 0.00001
=====TXSIGCOLLECT-7wVXpYd2======================================
AQAAAAsRCQcAAAAAAf0yAwEAAAALEQkHFlKTRmxBEIR+RS7+7Bn3BHT1Knrc7z9X
teo0PybMXhwBAAAA4AEAAAABMHL7+n0jQTpbJEMuaGIWgk8bPIQAqVqLIktH9Rhs
kq8AAAAAa0gwRQIhAIUOb2E0rRgyH1GDH6M+zSe7Wywdn9SDh0WaF6G2iXJEAiBl
dLUvW2Y98+ts300DviZzHdCraWvvwdmGuiUGmgftlAEhAqrp5NO+YM0ZtRBP/fcB
YEfiGgenxpbnfmRzDfrd92UV/////wLEUNvCAQAAABl2qRQlHSkniekJJ+sqkMjw
HpdKOvMYx4isAKAlJgAAAAAXqRTGlTR6NgKKM+8ygdYqQaT0cskvWocAAAAA/QsB
U0EEcaqfnSuuk4Af7OcIjanGzUf2Y8Cx/gXLgv0q3URd5H1eczOHOCO3AWMYxTJ+
Lu651FCjylV3Kv1FLVsIQpDjWkEEzrop2hr5ag8u982mlQuL4rrrGt8SwNXv67cN
vKoIa6ApzYKgz7je32W4dgzycfK4pQRmu/C5M5xf/vvipBZTJkEE1aQrkOnXFWFV
Zhl5UwoJ0uEuJS70EE5WESdKeufisJQGVzB7EpvvlI6pMtLT8g4aBRPJ6E/YUPdD
7mai4zSNH0EE/+7DDlt2V/EvUiSearKC52inqCm3khOFCvYBId6kn9IwWYZ3kp5j
e+7ZYkv8+2JyH/fxSojZllIVIGUcmT4/QVSuAAD/////BEEEcaqfnSuuk4Af7OcI
janGzUf2Y8Cx/gXLgv0q3URd5H1eczOHOCO3AWMYxTJ+Lu651FCjylV3Kv1FLVsI
QpDjWgAAQQTOuinaGvlqDy73zaaVC4viuusa3xLA1e/rtw28qghroCnNgqDPuN7f
Zbh2DPJx8rilBGa78LkznF/+++KkFlMmAABBBNWkK5Dp1xVhVWYZeVMKCdLhLiUu
9BBOVhEnSnrn4rCUBlcwexKb75SOqTLS0/IOGgUTyehP2FD3Q+5mouM0jR8AAEEE
/+7DDlt2V/EvUiSearKC52inqCm3khOFCvYBId6kn9IwWYZ3kp5je+7ZYkv8+2Jy
H/fxSojZllIVIGUcmT4/QQAAAjQBAAAACxEJBxl2qRSF60f+mPNJBl1vBE4npKxU
Gvee4ois6AMAAAAAAAAAAAROT05FAAAA/SgBAQAAAAsRCQf9CwFTQQRxqp+dK66T
gB/s5wiNqcbNR/ZjwLH+BcuC/SrdRF3kfV5zM4c4I7cBYxjFMn4u7rnUUKPKVXcq
/UUtWwhCkONaQQTOuinaGvlqDy73zaaVC4viuusa3xLA1e/rtw28qghroCnNgqDP
uN7fZbh2DPJx8rilBGa78LkznF/+++KkFlMmQQTVpCuQ6dcVYVVmGXlTCgnS4S4l
LvQQTlYRJ0p65+KwlAZXMHsSm++Ujqky0tPyDhoFE8noT9hQ90PuZqLjNI0fQQT/
7sMOW3ZX8S9SJJ5qsoLnaKeoKbeSE4UK9gEh3qSf0jBZhneSnmN77tliS/z7YnIf
9/FKiNmWUhUgZRyZPj9BVK4IdSUmAAAAAAAABE5PTkUAAAA=
================================================================

...
  'outputs': [ { 'addrstr': '',
                 'authdata': '',
                 'authmethod': 'NONE',
                 'contribid': '',
                 'contriblabel': '',
                 'hasaddrstr': False,
                 'ismultisig': True,
                 'isp2sh': False,
                 'magicbytes': '0b110907',
                 'p2shscript': '',
                 'scripttypeint': 3,
                 'scripttypestr': 'Multi-Signature',
                 'txoutscript': '53410471aa9f9d2bae93801fece7088da9c6cd47f663c0b1fe05cb82fd2add445de47d5e7333873823b7016318c5327e2eeeb9d450a3ca55772afd452d5b084290e35a4104ceba29da1af96a0f2ef7cda6950b8be2baeb1adf12c0d5efebb70dbcaa086ba029cd82a0cfb8dedf65b8760cf271f2b8a50466bbf0b9339c5ffefbe2a41653264104d5a42b90e9d7156155661979530a09d2e12e252ef4104e5611274a7ae7e2b0940657307b129bef948ea932d2d3f20e1a0513c9e84fd850f743ee66a2e3348d1f4104ffeec30e5b7657f12f52249e6ab282e768a7a829b79213850af60121dea49fd230598677929e637beed9624bfcfb62721ff7f14a88d996521520651c993e3f4154ae',
                 'txoutvalue': 639989000,
                 'version': 1,
                 'wltlocator': ''},
               { 'addrstr': 'msj42CCGruhRsFrGATiUuh25dtxYtnpbTx',
                 'authdata': '',
                 'authmethod': 'NONE',
                 'contribid': '',
                 'contriblabel': '',
                 'hasaddrstr': True,
                 'ismultisig': False,
                 'isp2sh': False,
                 'magicbytes': '0b110907',
                 'p2shscript': '',
                 'scripttypeint': 0,
                 'scripttypestr': 'Standard (PKH)',
                 'txoutscript': '76a91485eb47fe98f349065d6f044e27a4ac541af79ee288ac',
                 'txoutvalue': 1000,
                 'version': 1,
                 'wltlocator': ''}],

...

Transaction summary:

   UnsignedTx ID:  G2EhcNgd
   Curr TxID    :  348a4c33feaafb73076cd070bcc57b6f0049584883af00925ff5192b236030df
   Version      :  1
   Lock Time    :  0
   Fee (BTC)    :  0.0001
   #Inputs      :  1
      1c5ecc26:1 / Multi-Signature* / (M=3, N=4) /   6.40000000 / PubSz: (65 65 65 65)
   #Outputs     :  2
      Recip: [Multisig 3-of-4] (not P2SH but would be 2NBMEXDBRPPeu3SGBV1bw79JycNnz4dwR19)         6.39989    BTC
      Recip: msj42CCGruhRsFrGATiUuh25dtxYtnpbTx          0.00001    BTC
   Tx has 1 inputs:
       (3-of-4) AllSigned: False  AllSlots: _ _ _ _   ReqSorted: _ _ _

This patch fixes the problem and the change output is properly created as a p2sh script.

Code:

diff --git a/armoryd.py b/armoryd.py
index e8052f1..185a4a5 100644
--- a/armoryd.py
+++ b/armoryd.py
@@ -1962,7 +1962,7 @@ class Armory_Json_Rpc_Server(jsonrpc.JSONRPC):
                                              self.convLBDictToList())
             outputPairs.append( [ustxScr['Script'], totalChange] )
          else:
-            outputPairs.append( [lbox.binScript, totalChange] )
+            outputPairs.append( [script_to_p2sh_script(lbox.binScript), totalChange] )
       random.shuffle(outputPairs)
 
       # If this has nothing to do with lockboxes, we need to make sure

[etotheipi]

Just pushed .5 .  It should return the OSX build to it's previously mostly-stable state, and includes a new ledger paging mechanism.  We normally wouldn't have made such a late change, but there was some issues with the old paging, and goatpig had already finished this, so we merged it in.  If you have a large transaction history, please try it out!  It follows the pattern of the infiniscroll websites such as imgur or facebook.  The more you scroll, the more it loads!

As usual, please get from the Secure Downloader if possible.

  Armory 0.92.99.5-testing for Windows XP, Vista, 7, 8+ (32- and 64-bit)
  Armory 0.92.99.5-testing for MacOSX 10.7+ (64bit)
  Armory 0.92.99.5-testing for Ubuntu 12.04+ (32bit)
  Armory 0.92.99.5-testing for Ubuntu 12.04+ (64bit)
  Armory 0.92.99.5-testing for RaspberryPi  (armhf)

  Armory 0.92.99.5-testing Offline Bundle for Ubuntu 12.04 exact (32bit)
  Armory 0.92.99.5-testing Offline Bundle for Ubuntu 12.04 exact (64bit)
  Armory 0.92.99.5-testing Offline Bundle for RaspberryPi  (armhf)

  Armory 0.92.99.5-testing: Signed hashes of all installers

[justusranvier]

Armory's startup time is lower than I can ever remember it being before.

[Carlton Banks]

Armory's startup time is lower than I can ever remember it being before.

How about the (reliably instant) shutdown time also? 0.92.3 can take several minutes to quit if you're unlucky.