Bitcoin Forum
July 29, 2015, 06:53:47 AM *
News: New! Latest stable version of Bitcoin Core: 0.11.0 [Torrent]
 
   Home   Help Search Donate Login Register  
Pages: « 1 ... 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 [660]
  Print  
Author Topic: [1500 TH] p2pool: Decentralized, DoS-resistant, Hop-Proof pool  (Read 1265208 times)
nreal
Full Member
***
Offline Offline

Activity: 182


View Profile

Ignore
July 25, 2015, 01:10:38 AM
 #13181

Its as easyer to find a block with btc conf 1000000 than nothing less, dead and orphan shares rise their heads with that setting. But im feeling that bitcoind works somehow better with stock settings or even + something. Ive found 5 or 6 blocks after may - and bfore that with 0.05 fees and so none. 182x is lucky number maybe

Stock settings might be the best?
1438152827
Hero Member
*
Offline Offline

Posts: 1438152827

View Profile Personal Message (Offline)

Ignore
1438152827
Reply with quote  #2

1438152827
Report to moderator
1438152827
Hero Member
*
Offline Offline

Posts: 1438152827

View Profile Personal Message (Offline)

Ignore
1438152827
Reply with quote  #2

1438152827
Report to moderator
1438152827
Hero Member
*
Offline Offline

Posts: 1438152827

View Profile Personal Message (Offline)

Ignore
1438152827
Reply with quote  #2

1438152827
Report to moderator
AntMiner S5 BITMAIN The most power efficient bitcoin miner on the market
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction. Advertise here.
1438152827
Hero Member
*
Offline Offline

Posts: 1438152827

View Profile Personal Message (Offline)

Ignore
1438152827
Reply with quote  #2

1438152827
Report to moderator
1438152827
Hero Member
*
Offline Offline

Posts: 1438152827

View Profile Personal Message (Offline)

Ignore
1438152827
Reply with quote  #2

1438152827
Report to moderator
1438152827
Hero Member
*
Offline Offline

Posts: 1438152827

View Profile Personal Message (Offline)

Ignore
1438152827
Reply with quote  #2

1438152827
Report to moderator
forrestv
Hero Member
*****
Offline Offline

Activity: 489


View Profile

Ignore
July 26, 2015, 04:25:18 AM
 #13182

Was reviewing the code and came across this one part:

https://github.com/forrestv/p2pool/blob/master/p2pool/data.py#L152

Question: Why limit it to "50 kB of new txns/share"?


i even contacted you about that bug months ago Wink was asking forrestv about it, but he didnt respond. created a hackish fix in my repo.

It's limited to prevent DoS attacks on P2Pool by e.g. making a bunch of fake transactions and then forcing them to be relayed across the entire P2Pool network. With this limit, an attacker can only force every other P2Pool node to download, at most, 50kB per share the attacker mines.

Given that 100kB transactions are possible, it should probably be 100kB, not 50kB, but it doesn't have much of an effect otherwise, since 50kB/share is comparable to the maximum transaction throughput allowed by Bitcoin (500kB/block).

K1773R, your "hackish fix" will result in your shares being orphaned if it ever results in differing behavior. The contents of the generate_transaction function are used to determine consensus, so if your version acts different, other nodes will see your shares as invalid.

1J1zegkNSbwX4smvTdoHSanUfwvXFeuV23
jonnybravo0311
Hero Member
*****
Offline Offline

Activity: 504


View Profile WWW

Ignore
July 26, 2015, 03:13:31 PM
 #13183

Thanks for the detailed reply, forrestv!  I appreciate that you've become more active in this thread again.  It's always nice to have the guy who wrote the code explaining it, rather than the rest of us trying to reverse engineer it in an effort to provide an explanation. Smiley

K1773R
Legendary
*
Offline Offline

Activity: 1218


/dev/null


View Profile

Ignore
July 27, 2015, 07:33:24 AM
 #13184

Was reviewing the code and came across this one part:

https://github.com/forrestv/p2pool/blob/master/p2pool/data.py#L152

Question: Why limit it to "50 kB of new txns/share"?


i even contacted you about that bug months ago Wink was asking forrestv about it, but he didnt respond. created a hackish fix in my repo.

It's limited to prevent DoS attacks on P2Pool by e.g. making a bunch of fake transactions and then forcing them to be relayed across the entire P2Pool network. With this limit, an attacker can only force every other P2Pool node to download, at most, 50kB per share the attacker mines.

Given that 100kB transactions are possible, it should probably be 100kB, not 50kB, but it doesn't have much of an effect otherwise, since 50kB/share is comparable to the maximum transaction throughput allowed by Bitcoin (500kB/block).

K1773R, your "hackish fix" will result in your shares being orphaned if it ever results in differing behavior. The contents of the generate_transaction function are used to determine consensus, so if your version acts different, other nodes will see your shares as invalid.
Good that we talk about it now. When i was still mining BTC with p2pool, i wondered why not all of my (sometimes bigger than 100kB) would be included in p2pool blocks. It didnt really bother me back then, as some other pool would mine them.
I think raising it (not as high as my hackish fix) would be a good addition to a future hardfork.

Im absolutely aware that i would get my shares rejected. I wasnt using it for BTC.
I wanted to mine the huge ANC stuck txs, so i had to create my own p2pool and set the limit higher.

[GPG Public Key]  [Devcoin Builds]  [BBQCoin Builds]  [Multichain Blockexplorer]  [Multichain Blockexplorer - PoS Coins]  [Ufasoft Miner Linux Builds]
BTC/DVC/TRC/FRC: 1K1773RbXRZVRQSSXe9N6N2MUFERvrdu6y ANC/XPM AK1773RTmRKtvbKBCrUu95UQg5iegrqyeA NMC: NK1773Rzv8b4ugmCgX789PbjewA9fL9Dy1 LTC: LKi773RBuPepQH8E6Zb1ponoCvgbU7hHmd EMC: EK1773RxUes1HX1YAGMZ1xVYBBRUCqfDoF BQC: bK1773R1APJz4yTgRkmdKQhjhiMyQpJgfN
Pages: « 1 ... 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 [660]
  Print  
 
Jump to:  

Sponsored by , a Bitcoin-accepting VPN.
Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!