Electrum 1.9 released

[adamas]

changes:

* Fix for offline signing
* Coinbase Buyback plugin

  Is there a more detailed description of these changes?

[1714815446]

1714815446

[1714815446]

1714815446

[1714815446]

1714815446

[Tachikoma]

Offline transactions had problems; this should be fixed. As far as I understand the Coinbase Buyback plugin let's you buy back coins you sent after a transactions. Please correct me if I'm wrong

[SebastianJu]

1.9.7... when you delete a label of an address then its stored only temporarely when you have the label plugin enabled. The empty string isnt saved but the old string is restored.

[serendib]

I entered my master public key on a separate internet connected computer to create a watching only wallet, but if I right click on a public address and click on "private key", I can see the address's private key without it asking me for my password.  Am I wrong or is this in effect no different than having an unencrypted wallet? If someone could hack into my computer, they could see the private keys for all my addresses.  Until this is clarified, I have transferred all my funds out of electrum wallets for the time being (though electrum is otherwise great).

Does this happen to anyone else?

I guess you are talking about the wallet that has your seed (not the watching-only wallet), and that you forgot to encrypt it.
just add a password..

or maybe you selected 'restore from seed' and typed your master public key there

Nope.  It is my watching-only wallet on a computer that has never had a hot wallet on it.  I even erased the watching only wallet, reentered my MPK and it still happens.  However, I compared the private keys shown on the watching-only wallet to the cold storage wallet the private keys are different.  Could a dev or someone explain what is going on?  Does this mean I am okay?

you definitely selected 'restore from seed' instead of 'restore from master public key', and typed your master public key there

Hi ThomasV,
 
I am EXTREMELY puzzled.... Does this mean that the MPK is enough for the software to derive the full seed from it? This sort-of makes offline transactions useless, as the MPK goes to the onlne PC where it could be vulnerable.

I just tried again on a fresh install. Yes, just pasting the MPK into the wrong box creates a fully working wallet, as the software is able to derive the private keys from the Master Private Key. 

I think the name  "Master PUBLIC Key" is EXTREMELY misleading, as the word "Public" makes me think it's harmless to bring it around (i.e. to the online PC)

Did I mix things up, or is this how it's supposed to work?

[Abdussamad]

Hi ThomasV,
 
I am EXTREMELY puzzled.... Does this mean that the MPK is enough for the software to derive the full seed from it? This sort-of makes offline transactions useless, as the MPK goes to the onlne PC where it could be vulnerable.

I just tried again on a fresh install. Yes, just pasting the MPK into the wrong box creates a fully working wallet, as the software is able to derive the private keys from the Master Private Key. 

I think the name  "Master PUBLIC Key" is EXTREMELY misleading, as the word "Public" makes me think it's harmless to bring it around (i.e. to the online PC)

Did I mix things up, or is this how it's supposed to work?

You mixed things up. The master public key cannot be used to derive the private keys. You probably have the seed in hex confused with the master public key. The MPK consists of 128 hexadecimal digits while the seed is made up of 32 hex digits.

[serendib]

I have now double checked by re-installing Electrum on a fresh XP VM, and I am pretty sure I can confirm the issue, unless I am really mixing things up.

Please follow my process...

I select to restore from seed but then I copy the MPK (128 hex chars), not the seed: https://i.imgur.com/FMOOCFX.png

I get a wallet with my BTCs, and it does not seem a watch-only wallet: http://imgur.com/nZHymGe

I send a payment and get "payment sent" http://imgur.com/MBndxHG

the transaction appears to be signed:

{
    "hex": "01000000013fca0752d65f3903f51a3e7f8b7abd01bdafd255343a261df4bbe230eb93435c00000 0008a47304402202cd08bf90ac63784afb2dcf4f6e97b3c8781d3831c1897d379423d8343f9537c 0220275d30b59d7609508f1a4466e6bc414549c93cd6cda84f1ad9796c8eeb4679b1014104a9999 add8b93702c671b3ebceeab3b5a69bcd60d984372de4d73848b73e13fe3d25d1d9e7ab76f5dd74f abcbe831b44bdf9d8c6e2029344b6f3ec6fd401c2269ffffffff0260182300000000001976a914c b7801827ada1c3e2e7726762eddada2de61c83e88ac20043600000000001976a9147d4977a484da 53b5573032ca6d580996f133a63a88ac00000000",
    "complete": true
}

and seems to have been accepted (even not yet visible on the blockchain) http://imgur.com/jMVqVRV

BTW, the same address shows two transactions I generated earlier today with the same mechanism.

Again, I am very puzzled.

I also checked on the offline PC with Tools-Master Public Key and I get a window "Master Pulic Key" with the same MPK I pasted in the online PC (8206 .... 3835)

EDIT: the transaction in now in the blockchain: http://blockexplorer.com/tx/476f440dea98b03d4c495676e2d169a69e9f5ae963955570ef6f78b45dd03a13#o0

[ThomasV]

Please follow my process...
...

If you select 'restore from seed' and enter any hexadecimal string, it will use it directly as your seed.
It works with any hex string, whether it is a master public key or not.

The wallet created that way is not the same as the original wallet, that produced the master public key.
There is no risk for your original wallet.

Additional note: of course, I do not recommend this method to create a wallet.
There is no guarantee that a user chose hexadecimal string has enough randomness.