Armory 0.93 testing release! (with 0.05 BTC bug bounty)

[jammers]

yep, i will when it finishes again

btw, i can't get into the import wallet screen any more when the blockchain is loading, was that a bugfix?

[goatpig]

Especially important for our more-hardcore users, we now have a "supernode" mode, that doubles Armory's DB size, but indexes all scripts on the blockchain.

My supernode database file is 85.2 GB. This is 2.6x the size of the old Armory DB. Is this size expected? Can someone report the size of the new Armory's fullnode DB size? (I'd imagine it doesn't vary significantly from machine to machine)

85.2 GB - new Armory supernode
32.9 GB - old Armory fullnode
31.5 GB - Bitcoin Core
26.6 GB - raw blockchain

Yeah supernode will be very large, it averages 90GB on my machine. That's partly due to LMDB. The Fullnode DB itself sits at around 50GB. The optimized version should approach a 1:1 ratio with Core's blocks folder.

[zombieslayer9099]

snip

Fullnode will be slow on HDD until I'm done with the current round of optimizations. Ignore supernode on HDDs. There will be a testing release when the changes are solid. Don't toy with the current version if you don't have a SSD.

I'm using an SSHD (hybrid drive)

[goatpig]

snip

Fullnode will be slow on HDD until I'm done with the current round of optimizations. Ignore supernode on HDDs. There will be a testing release when the changes are solid. Don't toy with the current version if you don't have a SSD.

I'm using an SSHD (hybrid drive)

I doubt that will help. These usually top at 32GB of SSD, and most of that is occupied by your OS files. You'll have to wait for HDD opts. If all goes well I'll have something ready for early next week.

[TimS]

Is the "ignore list" option meant to be disabled when deleting a wallet? Why is it shown at all?

[TimS]

I found another bug related to changing ownership: the tooltip on Security doesn't update immediately, it updates whenever you close and reopen the window. Here are two images with it showing the wrong tooltip due to this bug.



Also, the images show that Armory thinks 2 addresses were used by this wallet, though 3 really were (all 3 have had 1 tx sent come in to it, no txs out).

[TimS]

I found another bug related to changing ownership: the tooltip on Security doesn't update immediately, it updates whenever you close and reopen the window. Here are two images with it showing the wrong tooltip due to this bug.

The same thing happens when adding/removing the encryption from a wallet.

[TimS]

(Armory 0.92.99.2 supernode) Attempting to sweep the private key 5HpHagT65TZzG1PH3CSu63k8DbpvD8s5ip4nEB3kEsreAnchuDf (listed at http://directory.io/). The window shown here opened itself rapidly many times:



Until there were enough open to cause Armory to crash:



This was repeated in the log file 43 times:
2015-01-16 07:15 (INFO) -- ArmoryQt.py:3523 - finishSweepScan
2015-01-16 07:15 (INFO) -- ArmoryQt.py:3404 - createSweepAddrTx

[lightlord]

Well I found a grammar mistake

[helgabutters]

1) When "Sending Bitcoin" if you put a negative value in one of the "Amount" spots and then hit "MAX" in another spot, the max value is calculated incorrectly.

https://i.imgur.com/GlIwW9N.png

2) Create a transaction that makes a new change address. While there are still 0 confirmations, "Send Bitcoins" > "Coin Control" and select the address that is change. Now try to make a transaction with that address and hit "Send". This is in the log:

(ERROR) Traceback (most recent call last):
  File "/usr/lib/armory/ui/TxFrames.py", line 757, in createTxAndBroadcast
    ustx = self.validateInputsGetUSTX()
  File "/usr/lib/armory/ui/TxFrames.py", line 597, in validateInputsGetUSTX
    utxoList = self.getUsableTxOutList(totalSend)
  File "/usr/lib/armory/ui/TxFrames.py", line 833, in getUsableTxOutList
    utxos = self.wlt.getAddrTxOutList(a160)
  File "/usr/lib/armory/armoryengine/PyBtcWallet.py", line 52, in inner
    return func(*args, **kwargs)
  File "/usr/lib/armory/armoryengine/PyBtcWallet.py", line 502, in getAddrTxOutList
    return cppAddr.getSpendableTxOutList(IGNOREZC);
  File "/usr/lib/armory/CppBlockUtils.py", line 1926, in getSpendableTxOutList
    def getSpendableTxOutList(self, ignoreZC=True): return _CppBlockUtils.ScrAddrObj_getSpendableTxOutList(self, ignoreZC)
RuntimeError: Iterator must be created within Transaction

Traceback (most recent call last):
  File "/usr/lib/armory/ui/TxFrames.py", line 757, in createTxAndBroadcast
    ustx = self.validateInputsGetUSTX()
  File "/usr/lib/armory/ui/TxFrames.py", line 597, in validateInputsGetUSTX
    utxoList = self.getUsableTxOutList(totalSend)
  File "/usr/lib/armory/ui/TxFrames.py", line 833, in getUsableTxOutList
    utxos = self.wlt.getAddrTxOutList(a160)
  File "/usr/lib/armory/armoryengine/PyBtcWallet.py", line 52, in inner
    return func(*args, **kwargs)
  File "/usr/lib/armory/armoryengine/PyBtcWallet.py", line 502, in getAddrTxOutList
    return cppAddr.getSpendableTxOutList(IGNOREZC);
  File "/usr/lib/armory/CppBlockUtils.py", line 1926, in getSpendableTxOutList
    def getSpendableTxOutList(self, ignoreZC=True): return _CppBlockUtils.ScrAddrObj_getSpendableTxOutList(self, ignoreZC)
RuntimeError: Iterator must be created within Transaction

As a comparison, not using "Coin Control" you can make this transaction successfully.

3) (Supernode) "Wallet Properties" > "Delete/Remove Wallet" > "Delete private keys, make watching-only" > "Delete". When making a watching-only wallet by deleting the private keys, the wallet breaks until you restart Armory.

https://www.youtube.com/watch?v=0Qg2X6hpkys

4) (Supernode) "Lockbox" > Right-Click "Rescan Lockbox" > "Yes". When trying to rescan a lockbox it isn't successful and this is the log:

(ERROR) Traceback (most recent call last):
  File "/usr/lib/armory/ui/MultiSigDialogs.py", line 1506, in showLboxContextMenu
    self.main.setWalletIsScanning(lbox)
AttributeError: 'ArmoryMainWindow' object has no attribute 'setWalletIsScanning'

Traceback (most recent call last):
  File "/usr/lib/armory/ui/MultiSigDialogs.py", line 1506, in showLboxContextMenu
    self.main.setWalletIsScanning(lbox)           
AttributeError: 'ArmoryMainWindow' object has no attribute 'setWalletIsScanning'

[jammers]

Just finished scanning after another two days, and there's a big gap for some reason.



rebooted and it's going through things again :/ scanning's taking forever, so i'm going to roll back to the stable build. once the next build comes out with db improvements, i'll try again.

[Newar]

[...] once the next build comes out with db improvements, i'll try again.

Same for me. No special flag, I had it build the DB for some 60 hours or so. It's at 64% now. Going the last 4% of that took ~8 hours.

Seems a 2012 model laptop with an i5-3317U and 6GB RAM is not enough for a regular installation?

[Jouke]

I checked out github 0.93-bugfix, and started armoryd with --supernode, added three watch only wallets, created a new lockbox (first I received a timeout, but the lockbox seems to be created, the second lockbox was created quite quick) and sent 0.001 bitcoins to the lockbox.

Tx not confirmed:
getreceivedbyaddress: shows correct balance
createlockboxustxtoaddress <addr> <0.001> <0>: notEnoughCoinsError "You have 0 satoshis" (because it was not confirmed? I would like to have the option to spend unconfirmed txes)
getledger <lockbox>: shows the following in the server output:

Code:

Traceback (most recent call last):
  File "/xxx/BitcoinArmory-0.93-bugfix/armoryengine/Decorators.py", line 79, in inner
    rv = func(*args, **kwargs)
  File "armoryd.py", line 1280, in jsonrpc_getledger
    cppHead = TheBDM.bdv().getHeaderPtrForTx(cppTx)
  File "/xxx/BitcoinArmory-0.93-bugfix/CppBlockUtils.py", line 2075, in getHeaderPtrForTx
    def getHeaderPtrForTx(self, *args): return _CppBlockUtils.BlockDataViewer_getHeaderPtrForTx(self, *args)
RuntimeError: TxRef in Tx object is not set, cannot get header ptr

tx confirmed:
getledger <locxbox>: shows the correct transactions
createlockboxustxtoaddress <addr> <0.001> <0>: NotEnoughCoinsError "You can't afford the fee!" (I set fee to zero)

Traceback (most recent call last):
  File "/xxx/BitcoinArmory-0.93-bugfix/armoryengine/Decorators.py", line 79, in inner
    rv = func(*args, **kwargs)
  File "armoryd.py", line 1112, in jsonrpc_createlockboxustxtoaddress
    [[str(ustxScr['Script']), amtCoin]], self.curLB.uniqueIDB58, fee)
  File "armoryd.py", line 1932, in create_unsigned_transaction
    raise NotEnoughCoinsError, "You can't afford the fee!"

createlockboxustxtoaddress <addr> <0.001> <0.00001>: CoinSelectError ""Coin selection failed. This shouldn't happen."

Traceback (most recent call last):
  File "/xxx/BitcoinArmory-0.93-bugfix/armoryengine/Decorators.py", line 79, in inner
    rv = func(*args, **kwargs)
  File "armoryd.py", line 1112, in jsonrpc_createlockboxustxtoaddress
    [[str(ustxScr['Script']), amtCoin]], self.curLB.uniqueIDB58, fee)
  File "armoryd.py", line 1938, in create_unsigned_transaction
    raise CoinSelectError, "Coin selection failed. This shouldn't happen."
CoinSelectError: Coin selection failed. This shouldn't happen.

createlockboxustxtoaddress <addr> <0.001> <0.001>: CoinSelectError ""Coin selection failed. This shouldn't happen."

Traceback (most recent call last):
  File "/xxx/BitcoinArmory-0.93-bugfix/armoryengine/Decorators.py", line 79, in inner
    rv = func(*args, **kwargs)
  File "armoryd.py", line 1112, in jsonrpc_createlockboxustxtoaddress
    [[str(ustxScr['Script']), amtCoin]], self.curLB.uniqueIDB58, fee)
  File "armoryd.py", line 1938, in create_unsigned_transaction
    raise CoinSelectError, "Coin selection failed. This shouldn't happen."
CoinSelectError: Coin selection failed. This shouldn't happen.

createlockboxustxtoaddress <addr> <0.0005>:works
There is now a transactions created that will send 0.0005 bitcoins to the addr, with a fee of 0.0001.

createlockboxustxtoaddress <addr> <0.00099> <0.000001>: NotEnoughCoinsError "A fee of 10000 is necessary for this transaction to go through. You put 1000 as the fee."

createlockboxustxtoaddress <addr> <0.0009> <0.00001>: works

Edit: P.s. Would also be really cool if one could create a transaction from a lockbox, and add the lockbox information into that transactions as well, so for example a cold wallet doesn't need to import the lockbox before it can sign the transaction.

Edit2: you guys don't have an IRC-channel right?

[zombieslayer9099]

Just saw the HDD Optimization branch, goatpig seems to be working hard! BTC

[zombieslayer9099]

Receive Bitcoins never ending Loading window is still there

Click on Receive Bitcoins and close it, Loading window with a progress bar doesn't go away until you close it.

[goatpig]

Just saw the HDD Optimization branch, goatpig seems to be working hard! BTC

If I'm lucky, it should be done tonight. Otherwise, I'd say sometimes tomorrow

[zombieslayer9099]

You sir, along with all Armory devs, deserve a tip

[goatpig]

You should first wait and see if that code works =P

[zombieslayer9099]

You should first wait and see if that code works =P

Right after you posted that Armory had a SIGABRT error and it won't stop doing that *insert worried face here*

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000

Application Specific Information:
abort() called
terminating with uncaught exception of type LMDBException: Failed to close env tx (MDB_BAD_TXN: Transaction cannot recover - it must be aborted)

[goatpig]

you're checking out that branch?