semiel
Newbie
Offline
Activity: 16
Merit: 0
|
|
December 09, 2014, 01:28:13 AM |
|
Thank you for the thorough review! I'll take a look at addressing the issues when I get the chance. (Might be a day or so.)
Update: I've made some quick fixes for the two issues identified as blockers. I've added test cases for both, and they're both pushed to the repo: https://github.com/PeterBorah/ethereum-powerballThat might be enough to fulfill the conditions of the bounty. However, as a matter of professional pride, I want to spend a little more time working on the quality of the code. The sorts of bugs found reveal what the weak spots are, and I have some ideas for making it more robust.* So, I'm going to try to work on that over the next couple evenings. * For the programmers in the audience: I've basically got an implicit state machine with some pretty complex effects. I want to model it more directly so that it's easier to reason about and harder to end up in weird partial states. I'm also not dealing with storing data in a very principled way, so I want to think about encapsulating some of that.
|
|
|
|
Matt Y
|
|
December 09, 2014, 02:10:41 AM |
|
Pretty sweet. Nicely done.
|
|
|
|
prophetx
Legendary
Offline
Activity: 1666
Merit: 1010
he who has the gold makes the rules
|
|
December 09, 2014, 03:00:35 AM Last edit: December 09, 2014, 11:05:23 PM by prophetx |
|
Thank you for the thorough review! I'll take a look at addressing the issues when I get the chance. (Might be a day or so.)
Update: I've made some quick fixes for the two issues identified as blockers. I've added test cases for both, and they're both pushed to the repo: https://github.com/PeterBorah/ethereum-powerballThat might be enough to fulfill the conditions of the bounty. However, as a matter of professional pride, I want to spend a little more time working on the quality of the code. The sorts of bugs found reveal what the weak spots are, and I have some ideas for making it more robust.* So, I'm going to try to work on that over the next couple evenings. * For the programmers in the audience: I've basically got an implicit state machine with some pretty complex effects. I want to model it more directly so that it's easier to reason about and harder to end up in weird partial states. I'm also not dealing with storing data in a very principled way, so I want to think about encapsulating some of that. Can you reply to this post with your XCP/BTC address. Then I will send the link to the people who pledged to support your coding of this smart contract. Me - 50 XCP Matt Y - 20 XCP Ivana - 10 XCP Niceplum - 10 XCP 5 XCP (edit sorry i made a mistake too many numbers )Tyhmakulho - 10 XCP Ian - 10 XCP Dante - not sure, expressed interest Tusk - 2 XCP Jonathan O - 3 XCP Grand total: 115 XCP 110 XCP (EDIT) or about $600 equivalent at today's rates. I am going to ask them all to send it directly to you as I don't want to be the middleman. Anyone sending please post here to confirm (if you have a bitcointalk account, some people may not). Also, as I didn't explicit a reward for the code review, if you would not mind perhaps sharing a % of it to the person who did the code review. https://gist.github.com/jorisbontje/353f69515a16cef7de7b I will ask him to put his XCP/BTC address in the git repo. I have not had time yet to get this running on the testnet to try it out but will spend some time this week to learn how to do that (haven't run counterpartyd since Feb so that will be interesting...), and then am also asking some people around who know people in the gaming space to see if we could perhaps demo this capability for them and get them interested in using XCP and Ethereum for their business. Thanks!
|
|
|
|
semiel
Newbie
Offline
Activity: 16
Merit: 0
|
|
December 09, 2014, 04:00:40 AM |
|
Can you reply to this post with your XCP/BTC address.
Then I will send the link to the people who pledged to support your coding of this smart contract.
Here you go: 1LeygZteCpjBstARoyt3uHgPhV8aJHsBAg Again, thank you so much for setting this up! I think this is the first cryptocurrency I've actually earned, rather than buying. I was definitely planning to pass some of the bounty to the code reviewer. As I said, it was a very good and thorough review. Does 20% seem fair to everyone? Let me know if you have any other smart contract work you need done. And I'm still planning on trying out some code improvements over the next few days. I'll be happy to help debug if you run into any issues with your testing.
|
|
|
|
prophetx
Legendary
Offline
Activity: 1666
Merit: 1010
he who has the gold makes the rules
|
|
December 09, 2014, 04:24:52 AM |
|
Can you reply to this post with your XCP/BTC address.
Then I will send the link to the people who pledged to support your coding of this smart contract.
Here you go: 1LeygZteCpjBstARoyt3uHgPhV8aJHsBAg Again, thank you so much for setting this up! I think this is the first cryptocurrency I've actually earned, rather than buying. I was definitely planning to pass some of the bounty to the code reviewer. As I said, it was a very good and thorough review. Does 20% seem fair to everyone? Let me know if you have any other smart contract work you need done. And I'm still planning on trying out some code improvements over the next few days. I'll be happy to help debug if you run into any issues with your testing. cool I put in the withdraw request of 50 xcp on poloniex to your address, i think they are installing a new server network card so it might take a few hours. I will post the tx ID when I see it. I also sent an IM to all the others for the remaining amounts and will follow up.
|
|
|
|
pankogulo
Full Member
Offline
Activity: 121
Merit: 100
Counterparty General Manager
|
|
December 09, 2014, 06:32:08 AM |
|
Thank you for the thorough review! I'll take a look at addressing the issues when I get the chance. (Might be a day or so.)
Update: I've made some quick fixes for the two issues identified as blockers. I've added test cases for both, and they're both pushed to the repo: https://github.com/PeterBorah/ethereum-powerballThat might be enough to fulfill the conditions of the bounty. However, as a matter of professional pride, I want to spend a little more time working on the quality of the code. The sorts of bugs found reveal what the weak spots are, and I have some ideas for making it more robust.* So, I'm going to try to work on that over the next couple evenings. * For the programmers in the audience: I've basically got an implicit state machine with some pretty complex effects. I want to model it more directly so that it's easier to reason about and harder to end up in weird partial states. I'm also not dealing with storing data in a very principled way, so I want to think about encapsulating some of that. Can you reply to this post with your XCP/BTC address. Then I will send the link to the people who pledged to support your coding of this smart contract. Me - 50 XCP Matt Y - 20 XCP Ivana - 10 XCP Niceplum - 10 XCP Tyhmakulho - 10 XCP Ian - 10 XCP Dante - not sure, expressed interest Tusk - 2 XCP Jonathan O - 3 XCP Grand total: 115 XCP or about $600 equivalent at today's rates. I am going to ask them all to send it directly to you as I don't want to be the middleman. Anyone sending please post here to confirm (if you have a bitcointalk account, some people may not). Also, as I didn't explicit a reward for the code review, if you would not mind perhaps sharing a % of it to the person who did the code review. https://gist.github.com/jorisbontje/353f69515a16cef7de7b I will ask him to put his XCP/BTC address in the git repo. I have not had time yet to get this running on the testnet to try it out but will spend some time this week to learn how to do that (haven't run counterpartyd since Feb so that will be interesting...), and then am also asking some people around who know people in the gaming space to see if we could perhaps demo this capability for them and get them interested in using XCP and Ethereum for their business. Thanks! 10 XCP on its way from Ivana http://www.blockscan.com/txInfo/11540071Thanks guys, great work!
|
|
|
|
Equality 7-2521
Member
Offline
Activity: 118
Merit: 10
A difference which makes a difference
|
|
December 09, 2014, 08:21:49 AM |
|
Block 333500 passed. Bring on the multisig and free asset issuance features in Counterwallet!
|
|
|
|
|
pankogulo
Full Member
Offline
Activity: 121
Merit: 100
Counterparty General Manager
|
|
December 09, 2014, 02:13:47 PM |
|
Block 333500 passed. Bring on the multisig and free asset issuance features in Counterwallet! Multisig and Free asset names now live in Counterwallet!
|
|
|
|
Equality 7-2521
Member
Offline
Activity: 118
Merit: 10
A difference which makes a difference
|
|
December 09, 2014, 03:45:45 PM |
|
Block 333500 passed. Bring on the multisig and free asset issuance features in Counterwallet! Multisig and Free asset names now live in Counterwallet! Great! And they're off to a flying start - https://www.blockscan.com/asset!
|
|
|
|
|
prophetx
Legendary
Offline
Activity: 1666
Merit: 1010
he who has the gold makes the rules
|
|
December 09, 2014, 04:14:52 PM |
|
Block 333500 passed. Bring on the multisig and free asset issuance features in Counterwallet! Multisig and Free asset names now live in Counterwallet! Great! And they're off to a flying start - https://www.blockscan.com/asset! no squatting huh Adam? Now every counterpartyd instance has to use computing power to process this spam If I was an evil miner and didn't like counterparty I would stuff the transaction block with as many of these as possible to impact the performance of xcp software Asset [Most Recent] Age Owner Circulation Locked Divisible A10000000000000000000 5 mins 1Bemb8LJMY5TxWJPvbW4QFEYRQ6wXKRFo2 1 No Yes A101010101010101010 5 mins 1QD5oHa3QZdeaXVbtwqWkSiW8nLUB1jrCx 3 No Yes A11111111111111111111 5 mins 1QD5oHa3QZdeaXVbtwqWkSiW8nLUB1jrCx 1 No Yes A11236064932333773000 5 mins 19cnM4Y7uhMMWT28Pqyq7XjGpt5RkH61L3 100 No Yes A12341234123412341234 5 mins 18AHSWhk7xU6TB2sZJnZKLyGneB452nmG7 1234 No Yes A12345123451234512345 5 mins 18AHSWhk7xU6TB2sZJnZKLyGneB452nmG7 12345 No Yes A13371337133713371337 5 mins 1LM5nQV7AFyrKfX2jkxjK9dF7s5vLiWQFz 1 No Yes A424242424242424242 5 mins 1QEx9kdYQqmNzC8HW8FPQS3Mb7vVXYa7bK 42 No Yes A430424198609196410 5 mins 1Bemb8LJMY5TxWJPvbW4QFEYRQ6wXKRFo2 1 No Yes A800850000000000000 5 mins 1QEx9kdYQqmNzC8HW8FPQS3Mb7vVXYa7bK 80085 No Yes A9876543210123456789 5 mins 1Bemb8LJMY5TxWJPvbW4QFEYRQ6wXKRFo2 1 No Yes A1000000000000000001 39 mins 18AHSWhk7xU6TB2sZJnZKLyGneB452nmG7 2 No Yes A100000000000000001 39 mins 18AHSWhk7xU6TB2sZJnZKLyGneB452nmG7 1 No Yes A1010101010101010101 39 mins 1CRvrpEd1Afw1ZXDBzhcS4MN2TbnLzSYKL 1 No Yes A123123123123123123 51 mins 18AHSWhk7xU6TB2sZJnZKLyGneB452nmG7 123 No Yes
|
|
|
|
PhantomPhreak (OP)
Sr. Member
Offline
Activity: 476
Merit: 300
Counterparty Chief Scientist and Co-Founder
|
|
December 09, 2014, 04:27:05 PM |
|
Block 333500 passed. Bring on the multisig and free asset issuance features in Counterwallet! Multisig and Free asset names now live in Counterwallet! Great! And they're off to a flying start - https://www.blockscan.com/asset! no squatting huh Adam? Now every counterpartyd instance has to use computing power to process this spam If I was an evil miner and didn't like counterparty I would stuff the transaction block with as many of these as possible to impact the performance of xcp software It has, and always will be, possible to use Counterparty to create useless transactions (as with Bitcoin). The computing power required to process them is as near to zero as you can get, and certainly not a cost-effective way of impacting performance.
|
|
|
|
prophetx
Legendary
Offline
Activity: 1666
Merit: 1010
he who has the gold makes the rules
|
|
December 09, 2014, 04:32:31 PM |
|
Block 333500 passed. Bring on the multisig and free asset issuance features in Counterwallet! Multisig and Free asset names now live in Counterwallet! Great! And they're off to a flying start - https://www.blockscan.com/asset! no squatting huh Adam? Now every counterpartyd instance has to use computing power to process this spam If I was an evil miner and didn't like counterparty I would stuff the transaction block with as many of these as possible to impact the performance of xcp software It has, and always will be, possible to use Counterparty to create useless transactions (as with Bitcoin). The computing power required to process them is as near to zero as you can get, and certainly not a cost-effective way of impacting performance. ok i hope you are correct on that last point
|
|
|
|
Equality 7-2521
Member
Offline
Activity: 118
Merit: 10
A difference which makes a difference
|
|
December 09, 2014, 04:35:20 PM |
|
Block 333500 passed. Bring on the multisig and free asset issuance features in Counterwallet! Multisig and Free asset names now live in Counterwallet! Great! And they're off to a flying start - https://www.blockscan.com/asset! no squatting huh Adam? Now every counterpartyd instance has to use computing power to process this spam If I was an evil miner and didn't like counterparty I would stuff the transaction block with as many of these as possible to impact the performance of xcp software It has, and always will be, possible to use Counterparty to create useless transactions (as with Bitcoin). The computing power required to process them is as near to zero as you can get, and certainly not a cost-effective way of impacting performance. Indeed, the additional computation required is trivial. And don't forget the Bitcoin transaction fee to prevent spam.
|
|
|
|
Anotheranonlol
|
|
December 09, 2014, 04:47:24 PM |
|
Summit, NJ and Palo Alto, CA (November 3, 2014) – TeraExchange® today announced that it has exclusively partnered with BitGo®, the leading bitcoin security platform, to provide multi-signature blockchain based custodial services for USD/Bitcoin swaps executed on its swap execution facility. By partnering with BitGo, TeraExchange is the only player in the industry to provide its market participants with the ability to collateralize bitcoin derivative trades in a completely secure and auditable trading environment. The TeraExchange institutional trading platform will use Bitcoin’s cryptographic ledger system – known as the blockchain – combined with BitGo’s revolutionary multi-sig security platform to replace the physical third-party custodianship model required of traditional collateral depositaries. “The relationship with BitGo fills in the missing piece of the Bitcoin derivatives trading workflow,” said Leonard Nuara, President and co-founder of TeraExchange. “Participants can now trade with the confidence of knowing that the required collateral is in place which serves to create a safe and sound marketplace.” Am i wrong in thinking CounterWallet can now achieve a similar thing with introduction of multisig on mainnet? transactions can be secured & auditable. also even without the second signer being a 'centralised' service a la https://cryptocorp.co/product.htm users can still benefit from a kind of 2fa? (within the constraints of the setup) Block 333500 passed. Bring on the multisig and free asset issuance features in Counterwallet! Multisig and Free asset names now live in Counterwallet! Great! And they're off to a flying start - https://www.blockscan.com/asset! Nice job . It would be good if there was a toggle switch on block explorer to hide/show numerical assets.
|
|
|
|
prophetx
Legendary
Offline
Activity: 1666
Merit: 1010
he who has the gold makes the rules
|
|
December 09, 2014, 05:30:23 PM |
|
Can you reply to this post with your XCP/BTC address.
Then I will send the link to the people who pledged to support your coding of this smart contract.
Here you go: 1LeygZteCpjBstARoyt3uHgPhV8aJHsBAg Again, thank you so much for setting this up! I think this is the first cryptocurrency I've actually earned, rather than buying. I was definitely planning to pass some of the bounty to the code reviewer. As I said, it was a very good and thorough review. Does 20% seem fair to everyone? Let me know if you have any other smart contract work you need done. And I'm still planning on trying out some code improvements over the next few days. I'll be happy to help debug if you run into any issues with your testing. cool I put in the withdraw request of 50 xcp on poloniex to your address, i think they are installing a new server network card so it might take a few hours. I will post the tx ID when I see it. I also sent an IM to all the others for the remaining amounts and will follow up. just an update... poloniex is having withdraw issues with there system.... so it might take another 12-24 hours before their tech people figure out that they need to restart some processes...
|
|
|
|
mtbitcoin
Legendary
Offline
Activity: 876
Merit: 1000
Etherscan.io
|
|
December 09, 2014, 05:57:30 PM |
|
... It would be good if there was a toggle switch on block explorer to hide/show numerical assets.
The toggle switch is next to the "Asset" column header (drop down box).
|
|
|
|
Equality 7-2521
Member
Offline
Activity: 118
Merit: 10
A difference which makes a difference
|
|
December 09, 2014, 10:34:23 PM |
|
What is the ELI5 on how to use the Multisig feature in Counterwallet?
|
|
|
|
ninjaboon
Legendary
Offline
Activity: 2128
Merit: 1002
|
|
December 09, 2014, 10:46:10 PM |
|
What is the ELI5 on how to use the Multisig feature in Counterwallet?
I wanted to know the same, still new at this XCP features.
|
|
|
|
|