|
I will have to look through the details and see when that actually happened. I will see if I can add them later today.
|
|
|
|
|
First official multisig transaction, first official distributed exchange message could be added.
|
|
|
|
I have code ready which can send MasterCoins. Here is what it looks like in action (ignore the first line which is from a previous run):  Source code is here: https://github.com/dacoinminster/MasterCoin-Adviser/blob/master/MasterCoinAdvisor.pyAnd here: https://github.com/dacoinminster/MasterCoin-Adviser/blob/master/base58_found.pyIn order to use this source code, you will need to install python 2.7 and also pycrypto for python 2.7, which I got here: http://www.voidspace.org.uk/python/modules.shtml#pycryptoOn one PC I had to mess with my PATH environment variable to find python and the pycrypto libraries, but when I tried it again on a different PC, I didn't have to mess with the PATH variable at all. Your mileage may vary. If you wish to avoid compiling, and you are a trusting sort of person, you can use the executable I made using py2exe: https://github.com/dacoinminster/MasterCoin-Adviser/raw/master/MasterCoinAdvisorExecutable.zip - I think the executable will only work if you have the right version of Microsoft's C Runtime DLL: http://www.microsoft.com/downloads/en/details.aspx?FamilyID=9b2da534-3e03-4391-8a4d-074b9f2bc1bf&displaylang=enThose of you who are affected by the Android wallet security problem should try this out right away. Let me know if you see anything weird. Please note that I still have some testing to do of this code - I just wanted to make sure you guys got hold of this functionality as soon as possible! If something isn't right in this code, I'll try to make sure that nothing you do gets lost. Still, sending MasterCoins from one address to another to another to another might not be a good idea yet! There are some debug outputs commented out in the code right now, but you might want to turn them back on if you are playing with this code. This code does NOT parse the block chain to see if you actually have MasterCoins to send, or track MasterCoins which have been sent. That is the next milestone after the giveaway thread. Hi dacoin and everyone, I need to make a transfer. Is this still the current best method? If you are on OS X or a Linux variant you could try my wallet software. Otherwise, until Zathras releases his client, this is probably your best bet. |
|
|
|
Haha no I just updated it, we were on at the same time, you didn't miss it  |
|
|
|
That's fine as well. I'm just saying that it specified nowhere how Purchase Orders should be paid. I just think the spec should be clear on the fact that you don't have to pay everything in one go. I've added some clarification it in this pull request. |
|
|
|
|
Good, I was hoping for that answer. I am about to head to bed but will write up a PR in the morning. If somebody disagrees let me know.
|
|
|
|
|
That still doesn't answer the main question though.
Should multiple transaction be accumulated and should the sum be used to match the purchase order
or
Should the highest transaction be counted and matched to a purchase order
|
|
|
|
|
My suggestion around luke's patch would be the following.
Create a BIP32 key/pair and supply the public part of the key.
Every implementation of the Mastercoin protocol should use this chain and check a list of addresses based on transaction volume of the last 25 blocks. We would start with a gap limit of 50 and retarget this number if the average volume across the last 25 blocks was more then half of this number to avoid collisions. We could also just hardcode a list but this solution should offer a bit more scaling and save some CPU cycles.
|
|
|
|
|
Yeah that's one of the other suggestions that I offered. It would make parsing easier but reduce the flexibility of the system.
|
|
|
|
I just discovered there is a part of the spec that we (developers) haven't discussed yet that's very open to interpretation. I just created a post to discuss the consequences of this part in the spec and closed my Selling Order until we can update the spec on how to parse these transactions. |
|
|
|
I've added a PR to group the selling/purchase offer clarifications. Developers, please read through them and see if you agree so far. I also found out I missed a line in the spec that said that the actual purchase offer should be adjusted based on the amount of funds received in the actual payment. I missed this and will need to add it to mastercoin-explorer. Now how should we deal with this? Should we only count the highest payment to an address? Should we collect all payments send in the timeframe and add them together? Allowing to be paid in parts? Should we change the spec to say we only allow the exact payment amount? I personally would like to collect all payments received during the block time limit and group them together and then adjust the Purchase Offer according to how many coins were received in total, although the amount can never be more then the Purchase Offer's initial amount. Example 1 User A creates a Selling Offer for 10 MSC @ 0.1 a coin with a time limit of 6 in block 20. User B sends a Purchase Offer to buy 5 MSC in block 22. User B sends a payment to User A of 0.3 BTC in block 23. Nothing more happens. User B Purchase Offer gets adjusted to buy 3 MSC and gets validated. Example 2 User A creates a Selling Offer for 10 MSC @ 0.1 a coin with a time limit of 6 in block 20. User B sends a Purchase Offer to buy 5 MSC in block 22. User B sends a payment to User A of 0.3 BTC in block 23. User B sends a payment to User A of 0.8 BTC in block 24. User B paid 0.11BTC in total, enough to completely satisfy his order. |
|
|
|
Your original transaction was present when I checked mastercoin-explorer, you can see it here. I've removed the 'insufficient' pay status again. It was mostly just very confusing. You either pay or you don't but it won't update the status if it received coins but it was not enough. This should also fix the 'I cannot pay' problem. Sorry about that, that's what you get when you code for 17 hours straight Same thing happened to me earlier. On that same note, I placed a purchase offer for 1.0 test mastercoin and even though I never broadcast a payment transaction ME and the wallet say that I have a balance of 1.0 test mastercoin. My assumption is that it's challenging to differentiate between a purchase offer and the payment transaction. If the purchase offer transaction exceeds the amount of bitcoin to finalize the exchange, will it finalize the exchange? Could you give me the transaction ids of the purchase offers in question. I think there is still a bug in my code where it will accept the Purchase Offer as payment if it was enough to satisfy the offer. It is not in the spec yet but I think the payment should always come one block _after_ the purchase offer. I'm also getting the "not enough received" message on two separate tx's: 27937e5ba11231560c650a64dbe5b02c5406c04863e4074991e70762cccff806be2005200503273686a26604076bb03a67fdaad6755d9599ae539ffde663491eI notice that despite the trades not completing, the balance of the sell offer continues to decline. Also, on the first tx, it took, I think around 7 or 8 hours to get a confirmation, I think because the amounts were small..hopefully not a sign of things to come. EDIT: sanity check - is it just showing not enough received because I now just need to do a multisend of btc to the 3 addresses (the amount I need to buy and the two 0.0006 sends)? I can't recall what I did last time but I guess I was thinking the wallet will handle everything on both parts.. Yeah sorry again for the confusion. I thought I was making things more transparent by using this extra status but it doesn't. Shouldn't happen again  |
|
|
|
Sudo should work although RVM is always recommended, although slightly harder. In later versions once things are more stable I will try to build .app packages for easy use on OS X. I really need to turn in. I will check out things in the morning. Have fun breaking my stuff and a big thanks to everybody who participated so far |
|
|
|
Ah no sorry I was addressing the person on this forum called LOL, not the best of usernames |
|
|
|
LOL: This transaction was yours right? It seems it was mis-parsed and I need to send your coins back again. Please confirm and I will send them asap |
|
|
|
I will do an other test as soon as I go through everything |
|
|
|
|
Can everybody who sent me coins for the Selling Offer, write down their transaction-ids for me. In case something changes I want to be able to refund the transactions.
|
|
|
|
Aw man I live in the wrong time zone! You guys are having all the fun! Great work!
Trying to get v0.0.9 running now but having trouble. Cleared the config, relaunched and input my key/password. then when attempting to relaunch I get:
/Users/xxx/.rvm/gems/ruby-1.9.3-p448/gems/mastercoin-wallet-0.0.9/lib/mastercoin-wallet/gui/main_window.rb:135:in `method_missing': undefined method `setText' for #<Qt::TreeWidgetItem:0x007fd2433f5a08> (NoMethodError)
from /Users/xxx/.rvm/gems/ruby-1.9.3-p448/gems/mastercoin-wallet-0.0.9/lib/mastercoin-wallet/gui/main_window.rb:135:in `add_offer_row'
from /Users/xxx/.rvm/gems/ruby-1.9.3-p448/gems/mastercoin-wallet-0.0.9/lib/mastercoin-wallet/gui/main_window.rb:155:in `block in update_order_book'
from /Users/xxx/.rvm/gems/ruby-1.9.3-p448/gems/httparty-0.12.0/lib/httparty/response.rb:62:in `each'
from /Users/xxx/.rvm/gems/ruby-1.9.3-p448/gems/httparty-0.12.0/lib/httparty/response.rb:62:in `method_missing'
from /Users/xxx/.rvm/gems/ruby-1.9.3-p448/gems/mastercoin-wallet-0.0.9/lib/mastercoin-wallet/gui/main_window.rb:154:in `update_order_book'
from /Users/xxx/.rvm/rubies/ruby-1.9.3-p448/lib/ruby/1.9.1/observer.rb:195:in `block in notify_observers'
from /Users/xxx/.rvm/rubies/ruby-1.9.3-p448/lib/ruby/1.9.1/observer.rb:194:in `each'
from /Users/xxx/.rvm/rubies/ruby-1.9.3-p448/lib/ruby/1.9.1/observer.rb:194:in `notify_observers'
from /Users/xxx/.rvm/gems/ruby-1.9.3-p448/gems/mastercoin-wallet-0.0.9/lib/mastercoin-wallet/network/selling_offer.rb:10:in `retrieve!'
from /Users/xxx/.rvm/gems/ruby-1.9.3-p448/gems/mastercoin-wallet-0.0.9/lib/mastercoin-wallet/gui/main_window.rb:87:in `sync'
from /Users/xxx/.rvm/gems/ruby-1.9.3-p448/gems/mastercoin-wallet-0.0.9/lib/mastercoin-wallet/gui/main_window.rb:78:in `initialize'
from /Users/xxx/.rvm/gems/ruby-1.9.3-p448/gems/mastercoin-wallet-0.0.9/bin/mastercoin-wallet:10:in `new'
from /Users/xxx/.rvm/gems/ruby-1.9.3-p448/gems/mastercoin-wallet-0.0.9/bin/mastercoin-wallet:10:in `<top (required)>'
from /Users/xxx/.rvm/gems/ruby-1.9.3-p448/bin/mastercoin-wallet:23:in `load'
from /Users/xxx/.rvm/gems/ruby-1.9.3-p448/bin/mastercoin-wallet:23:in `<main>'
from /Users/xxx/.rvm/gems/ruby-1.9.3-p448/bin/ruby_executable_hooks:15:in `eval'
from /Users/xxx/.rvm/gems/ruby-1.9.3-p448/bin/ruby_executable_hooks:15:in `<main>'
Suggestions?
edit - config.json:
"balance":0,"test_balance":0,"spendable_outputs":[],"bought_transactions":[],"created_transactions":[],"sold_transactions":[],"bitcoin_transactions":[],"exodus_transactions":[],"sent_transactions":[],"received_transactions":[],"btc_balance":0,"private_key":"xxx","address":"16rAwebBXhJAM9ALf3fLFbaHKz24r2o3UN"}
Sorry about that, it seems that QT parses 0 as nil and then gives an error. I just pushed 0.0.10 that should fix that |
|
|
|
|
As soon as I gathered all the data from this single experience and make sure all sites offer the same interpretation :}
|
|
|
|
|
Show Posts
