Bitcoin Forum
November 02, 2024, 12:39:51 AM *
News: Latest Bitcoin Core release: 28.0 [Torrent]
 
   Home   Help Search Login Register More  
Pages: « 1 ... 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 [179] 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 ... 486 »
  Print  
Author Topic: [BBR] Boolberry: Privacy and Security - Guaranteed Since 2014  (Read 1210765 times)
This is a self-moderated topic. If you do not want to be moderated by the person who started this topic, create a new topic.
tacotime
Legendary
*
Offline Offline

Activity: 1484
Merit: 1005



View Profile
September 04, 2014, 02:31:08 PM
 #3561

I expected nothing less than 'grumpy smooth' to be the result of BBR pulling even in volume with XMR.   Cheesy

I assure you my irritation has nothing to do with trading and everything to do with not being properly credited for the work that rfreeman_w and I did (he first discovered the source of the problem and I came up with the sizeof*8 fix).

And I caught the section of code with the problem last night:
https://bitcointalk.org/index.php?topic=583449.msg8665829#msg8665829

Code:
XMR: 44GBHzv6ZyQdJkjqZje6KLZ3xSyN1hBSFAnLP6EAqJtCRVzMzZmeXTC2AHKDS9aEDTRKmo6a6o9r9j86pYfhCWDkKjbtcns
smooth
Legendary
*
Offline Offline

Activity: 2968
Merit: 1198



View Profile
September 04, 2014, 02:32:57 PM
 #3562

I expected nothing less than 'grumpy smooth' to be the result of BBR pulling even in volume with XMR.   Cheesy

I assure you my irritation has nothing to do with trading and everything to do with not being properly credited for the work that rfreeman_w and I did (he first discovered the source of the problem and I came up with the sizeof*8 fix).

And I caught the section of code with the problem last night:
https://bitcointalk.org/index.php?topic=583449.msg8665829#msg8665829

Already edited above as you were writing that Smiley
iCEBREAKER
Legendary
*
Offline Offline

Activity: 2156
Merit: 1072


Crypto is the separation of Power and State.


View Profile WWW
September 04, 2014, 02:37:33 PM
 #3563

I expected nothing less than 'grumpy smooth' to be the result of BBR pulling even in volume with XMR.   Cheesy

I assure you my irritation has nothing to do with trading and everything to do with not being properly credited for the work that rfreeman_w and I did (he first discovered the source of the problem and I came up with the sizeof*8 fix).

EDIT: tacotime also deserves credit for pointing to the tree-hash function based on the transaction count in the poison block used for the attack. It was a great intuition.

OMG How Dare You forget to credit TT in the first place?   Cheesy 

Oh I see, when you make an attribution oversight it's just a little oopsie but if CZ does pretty much the same it indicts his character unless he does as *you* say.

All of us paying attention don't really need CZ or you to tell us what we just saw happen.  Stop being petty about who said what and when, it reflects poorly on XMR.


██████████
█████████████████
██████████████████████
█████████████████████████
████████████████████████████
████
████████████████████████
█████
███████████████████████████
█████
███████████████████████████
██████
████████████████████████████
██████
████████████████████████████
██████
████████████████████████████
██████
███████████████████████████
██████
██████████████████████████
█████
███████████████████████████
█████████████
██████████████
████████████████████████████
█████████████████████████
██████████████████████
█████████████████
██████████

Monero
"The difference between bad and well-developed digital cash will determine
whether we have a dictatorship or a real democracy." 
David Chaum 1996
"Fungibility provides privacy as a side effect."  Adam Back 2014
Buy and sell XMR near you
P2P Exchange Network
Buy XMR with fiat
Is Dash a scam?
Lordoftherigs
Sr. Member
****
Offline Offline

Activity: 313
Merit: 250


View Profile
September 04, 2014, 02:43:27 PM
 #3564

CZ updated the statement and acknowledged the XMR devs without any protests or reservation. This was most likely unintentional. Simple misunderstanding. The reactions of XMR devs are bit harsh IMHO....
tacotime
Legendary
*
Offline Offline

Activity: 1484
Merit: 1005



View Profile
September 04, 2014, 02:45:06 PM
 #3565

CZ updated the statement and acknowledged the XMR devs without any protests or reservation. This was most likely unintentional. Simple misunderstanding. The reactions of XMR devs are bit harsh IMHO....

We're just cranky because most of us haven't slept much  Cheesy

Code:
XMR: 44GBHzv6ZyQdJkjqZje6KLZ3xSyN1hBSFAnLP6EAqJtCRVzMzZmeXTC2AHKDS9aEDTRKmo6a6o9r9j86pYfhCWDkKjbtcns
Hotmetal
Sr. Member
****
Offline Offline

Activity: 378
Merit: 250


View Profile
September 04, 2014, 02:49:01 PM
 #3566

CZ updated the statement and acknowledged the XMR devs without any protests or reservation. This was most likely unintentional. Simple misunderstanding. The reactions of XMR devs are bit harsh IMHO....

We're just cranky because most of us haven't slept much  Cheesy

AMEN. So lets put this to bed and move on. Where to from here? XMR & BBR joining SuperNET together? Tongue
tifozi
Hero Member
*****
Offline Offline

Activity: 742
Merit: 501


View Profile
September 04, 2014, 02:52:00 PM
 #3567

CZ updated the statement and acknowledged the XMR devs without any protests or reservation. This was most likely unintentional. Simple misunderstanding. The reactions of XMR devs are bit harsh IMHO....

We're just cranky because most of us haven't slept much  Cheesy

Great job in always watching the chain tacotime.

Also looks like the fixes implemented are going to be different? Are you going with reduced max block size ?
whap
Member
**
Offline Offline

Activity: 106
Merit: 10


View Profile
September 04, 2014, 02:53:48 PM
 #3568

CZ updated the statement and acknowledged the XMR devs without any protests or reservation. This was most likely unintentional. Simple misunderstanding. The reactions of XMR devs are bit harsh IMHO....

We're just cranky because most of us haven't slept much  Cheesy

AMEN. So lets put this to bed and move on. Where to from here? XMR & BBR joining SuperNET together? Tongue

I would cry of joy. Boonero, Monerry, whatever.
smooth
Legendary
*
Offline Offline

Activity: 2968
Merit: 1198



View Profile
September 04, 2014, 02:54:14 PM
 #3569

CZ updated the statement and acknowledged the XMR devs without any protests or reservation. This was most likely unintentional. Simple misunderstanding. The reactions of XMR devs are bit harsh IMHO....

We're just cranky because most of us haven't slept much  Cheesy

Great job in always watching the chain tacotime.

Also looks like the fixes implemented are going to be different? Are you going with reduced max block size ?

No that was just a temporarily work-around we were going to push out while continuing to work on the real fix (and CZ said he would do if needed for BBR). It won't be needed now, at least not for this bug.
tacotime
Legendary
*
Offline Offline

Activity: 1484
Merit: 1005



View Profile
September 04, 2014, 02:55:29 PM
 #3570

Great job in always watching the chain tacotime.

Also looks like the fixes implemented are going to be different? Are you going with reduced max block size ?

Nah, it was a simple overflow bug, the basic fix is the same, to just fix the horrible C code line that caused it.

The long term fix is just tossing all the horribly dangerous C code that contains naked pointers and moving to something somewhat less terrible like C++.

Code:
XMR: 44GBHzv6ZyQdJkjqZje6KLZ3xSyN1hBSFAnLP6EAqJtCRVzMzZmeXTC2AHKDS9aEDTRKmo6a6o9r9j86pYfhCWDkKjbtcns
crypto_zoidberg (OP)
Hero Member
*****
Offline Offline

Activity: 976
Merit: 646



View Profile WWW
September 04, 2014, 02:55:39 PM
 #3571

UPD: Actually have to say that Monero devs has also fixed this bug independently in their own way. Good job.

Let's be clear about this.

We have a different fix on github, but we also sent the exact same fix to you for your opinion well before "Cryptonote" (whoever that is) sent it out.  

Crediting it to "Cryptonote" when rfreeman_w and I had already debugged it and sent you the exact same fix first is pretty sad. At least give credit where credit is due.

I expected better from you.


Hey!
You asked me to review your fix, but i said that i need time for it (because you rewrote whole merkle function), and then 15 minutes later arrived email from CryptoNote, with tiny little fix(with one line) - for me it was just more clear and obviouse that this fixed the problem. So why i have to wait and keep reading your fix?

And despite this i also noticed later that you guys also has solved the problem and made good job.

Sorry that i made you sad but you wrong. And i don't care what you expected.


tifozi
Hero Member
*****
Offline Offline

Activity: 742
Merit: 501


View Profile
September 04, 2014, 03:05:10 PM
 #3572

Great job in always watching the chain tacotime.

Also looks like the fixes implemented are going to be different? Are you going with reduced max block size ?

Nah, it was a simple overflow bug, the basic fix is the same, to just fix the horrible C code line that caused it.

The long term fix is just tossing all the horribly dangerous C code that contains naked pointers and moving to something somewhat less terrible like C++.

Yes I got the merkle tree overflow stuff. I was asking specifically about the tree hash bug and what the fix was going to be ..

To me both chains need to be co-exist. It is pretty obvious that XMR will continue to get targeted. It will only make the code better in the long term, but there will be targeted disruptions from time to time.
smooth
Legendary
*
Offline Offline

Activity: 2968
Merit: 1198



View Profile
September 04, 2014, 03:09:06 PM
 #3573

Great job in always watching the chain tacotime.

Also looks like the fixes implemented are going to be different? Are you going with reduced max block size ?

Nah, it was a simple overflow bug, the basic fix is the same, to just fix the horrible C code line that caused it.

The long term fix is just tossing all the horribly dangerous C code that contains naked pointers and moving to something somewhat less terrible like C++.

Yes I got the merkle tree overflow stuff. I was asking specifically about the tree hash bug and what the fix was going to be ..

To me both chains need to be co-exist. It is pretty obvious that XMR will continue to get targeted. It will only make the code better in the long term, but there will be targeted disruptions from time to time.

Both chains exist in the sense that they're stored on some computers somewhere, but the longest chain is the consensus.

tifozi
Hero Member
*****
Offline Offline

Activity: 742
Merit: 501


View Profile
September 04, 2014, 03:10:33 PM
 #3574

Great job in always watching the chain tacotime.

Also looks like the fixes implemented are going to be different? Are you going with reduced max block size ?

Nah, it was a simple overflow bug, the basic fix is the same, to just fix the horrible C code line that caused it.

The long term fix is just tossing all the horribly dangerous C code that contains naked pointers and moving to something somewhat less terrible like C++.

Yes I got the merkle tree overflow stuff. I was asking specifically about the tree hash bug and what the fix was going to be ..

To me both chains need to be co-exist. It is pretty obvious that XMR will continue to get targeted. It will only make the code better in the long term, but there will be targeted disruptions from time to time.

Both chains exist in the sense that they're stored on some computers somewhere, but the longest chain is the consensus.



I meant BBR and XMR, in the light of continued questions about BBR being the smaller network and folks questioning it from time to time.
rdnkjdi
Legendary
*
Offline Offline

Activity: 1256
Merit: 1009


View Profile
September 04, 2014, 03:12:17 PM
 #3575

Quote
Sorry that i made you sad but you wrong. And i don't care what you expected.

This rivalry cracks me up beyond belief. 
smooth
Legendary
*
Offline Offline

Activity: 2968
Merit: 1198



View Profile
September 04, 2014, 03:13:51 PM
 #3576

You asked me to review your fix, but i said that i need time for it (because you rewrote whole merkle function)

Probably some confusion in communication. We had both fixes. rfreeman_w's code clean up in git hub and my *8 fix in IRC:

[13:35] <rfreeman_w> it will break faster on 32 bit
[13:35] <rfreeman_w> maybe for some implementation it would even pass for 514?
[13:35] <sk00t3r> How can I confirm I am on the correct chain? My deamon has not been on in a few days.
[13:36] <smooth> rfreeman_w sizeof(size_t)*8 i think. it should be bits not bytes
[13:36] * taaku has quit (Client Quit)

I thought both were sent to you but perhaps I'm mistaken. Anyway, I'm glad this all got worked out, and I appreciate your help in analyzing the problem and helping us to fix our coin. Perhaps some day we can and (if so will) repay the favor, though hopefully not in kind.



tacotime
Legendary
*
Offline Offline

Activity: 1484
Merit: 1005



View Profile
September 04, 2014, 03:16:03 PM
 #3577

Yes I got the merkle tree overflow stuff. I was asking specifically about the tree hash bug and what the fix was going to be ..

To me both chains need to be co-exist. It is pretty obvious that XMR will continue to get targeted. It will only make the code better in the long term, but there will be targeted disruptions from time to time.

The fix is to stop coding in C, which should never be used for distributed consensus, and to refactor the codebase.

Code:
XMR: 44GBHzv6ZyQdJkjqZje6KLZ3xSyN1hBSFAnLP6EAqJtCRVzMzZmeXTC2AHKDS9aEDTRKmo6a6o9r9j86pYfhCWDkKjbtcns
aminorex
Legendary
*
Offline Offline

Activity: 1596
Merit: 1030


Sine secretum non libertas


View Profile
September 04, 2014, 03:18:06 PM
 #3578

Quote
Sorry that i made you sad but you wrong. And i don't care what you expected.
This rivalry cracks me up beyond belief. 
Welcome to Aspberger's School of Charm and Dignity.

Give a man a fish and he eats for a day.  Give a man a Poisson distribution and he eats at random times independent of one another, at a constant known rate.
iCEBREAKER
Legendary
*
Offline Offline

Activity: 2156
Merit: 1072


Crypto is the separation of Power and State.


View Profile WWW
September 04, 2014, 03:20:10 PM
 #3579

The long term fix is just tossing all the horribly dangerous C code that contains naked pointers and moving to something somewhat less terrible like C++.

Maybe the Cryptonote Foundation can hire Peter Todd or gmaxwell to port the entire thing over to an expanded Bitcoin codebase.  Once the modularization is done, of course.


██████████
█████████████████
██████████████████████
█████████████████████████
████████████████████████████
████
████████████████████████
█████
███████████████████████████
█████
███████████████████████████
██████
████████████████████████████
██████
████████████████████████████
██████
████████████████████████████
██████
███████████████████████████
██████
██████████████████████████
█████
███████████████████████████
█████████████
██████████████
████████████████████████████
█████████████████████████
██████████████████████
█████████████████
██████████

Monero
"The difference between bad and well-developed digital cash will determine
whether we have a dictatorship or a real democracy." 
David Chaum 1996
"Fungibility provides privacy as a side effect."  Adam Back 2014
Buy and sell XMR near you
P2P Exchange Network
Buy XMR with fiat
Is Dash a scam?
adaseb
Legendary
*
Offline Offline

Activity: 3878
Merit: 1733


View Profile
September 04, 2014, 03:29:36 PM
 #3580

Any idea why Bittrex wallet is disabled?
Pages: « 1 ... 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 [179] 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 ... 486 »
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!