tacotime
Legendary
Offline
Activity: 1484
Merit: 1005
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2014, 02:31:08 PM |
|
I expected nothing less than 'grumpy smooth' to be the result of BBR pulling even in volume with XMR. ![Cheesy](https://bitcointalk.org/Smileys/default/cheesy.gif) I assure you my irritation has nothing to do with trading and everything to do with not being properly credited for the work that rfreeman_w and I did (he first discovered the source of the problem and I came up with the sizeof*8 fix). And I caught the section of code with the problem last night: https://bitcointalk.org/index.php?topic=583449.msg8665829#msg8665829
|
XMR: 44GBHzv6ZyQdJkjqZje6KLZ3xSyN1hBSFAnLP6EAqJtCRVzMzZmeXTC2AHKDS9aEDTRKmo6a6o9r9j86pYfhCWDkKjbtcns
|
|
|
smooth
Legendary
Offline
Activity: 2968
Merit: 1198
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2014, 02:32:57 PM |
|
I expected nothing less than 'grumpy smooth' to be the result of BBR pulling even in volume with XMR. ![Cheesy](https://bitcointalk.org/Smileys/default/cheesy.gif) I assure you my irritation has nothing to do with trading and everything to do with not being properly credited for the work that rfreeman_w and I did (he first discovered the source of the problem and I came up with the sizeof*8 fix). And I caught the section of code with the problem last night: https://bitcointalk.org/index.php?topic=583449.msg8665829#msg8665829Already edited above as you were writing that ![Smiley](https://bitcointalk.org/Smileys/default/smiley.gif)
|
|
|
|
iCEBREAKER
Legendary
Offline
Activity: 2156
Merit: 1072
Crypto is the separation of Power and State.
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2014, 02:37:33 PM |
|
I expected nothing less than 'grumpy smooth' to be the result of BBR pulling even in volume with XMR. ![Cheesy](https://bitcointalk.org/Smileys/default/cheesy.gif) I assure you my irritation has nothing to do with trading and everything to do with not being properly credited for the work that rfreeman_w and I did (he first discovered the source of the problem and I came up with the sizeof*8 fix). EDIT: tacotime also deserves credit for pointing to the tree-hash function based on the transaction count in the poison block used for the attack. It was a great intuition. OMG How Dare You forget to credit TT in the first place? Oh I see, when you make an attribution oversight it's just a little oopsie but if CZ does pretty much the same it indicts his character unless he does as *you* say. All of us paying attention don't really need CZ or you to tell us what we just saw happen. Stop being petty about who said what and when, it reflects poorly on XMR.
|
██████████ ██████████████████ ██████████████████████ ██████████████████████████ ████████████████████████████ ██████████████████████████████ ████████████████████████████████ ████████████████████████████████ ██████████████████████████████████ ██████████████████████████████████ ██████████████████████████████████ ██████████████████████████████████ ██████████████████████████████████ ████████████████████████████████ ██████████████ ██████████████ ████████████████████████████ ██████████████████████████ ██████████████████████ ██████████████████ ██████████ Monero
|
| "The difference between bad and well-developed digital cash will determine whether we have a dictatorship or a real democracy." David Chaum 1996 "Fungibility provides privacy as a side effect." Adam Back 2014
|
| | |
|
|
|
Lordoftherigs
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2014, 02:43:27 PM |
|
CZ updated the statement and acknowledged the XMR devs without any protests or reservation. This was most likely unintentional. Simple misunderstanding. The reactions of XMR devs are bit harsh IMHO....
|
|
|
|
tacotime
Legendary
Offline
Activity: 1484
Merit: 1005
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2014, 02:45:06 PM |
|
CZ updated the statement and acknowledged the XMR devs without any protests or reservation. This was most likely unintentional. Simple misunderstanding. The reactions of XMR devs are bit harsh IMHO....
We're just cranky because most of us haven't slept much ![Cheesy](https://bitcointalk.org/Smileys/default/cheesy.gif)
|
XMR: 44GBHzv6ZyQdJkjqZje6KLZ3xSyN1hBSFAnLP6EAqJtCRVzMzZmeXTC2AHKDS9aEDTRKmo6a6o9r9j86pYfhCWDkKjbtcns
|
|
|
Hotmetal
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2014, 02:49:01 PM |
|
CZ updated the statement and acknowledged the XMR devs without any protests or reservation. This was most likely unintentional. Simple misunderstanding. The reactions of XMR devs are bit harsh IMHO....
We're just cranky because most of us haven't slept much ![Cheesy](https://bitcointalk.org/Smileys/default/cheesy.gif) AMEN. So lets put this to bed and move on. Where to from here? XMR & BBR joining SuperNET together? ![Tongue](https://bitcointalk.org/Smileys/default/tongue.gif)
|
|
|
|
tifozi
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2014, 02:52:00 PM |
|
CZ updated the statement and acknowledged the XMR devs without any protests or reservation. This was most likely unintentional. Simple misunderstanding. The reactions of XMR devs are bit harsh IMHO....
We're just cranky because most of us haven't slept much ![Cheesy](https://bitcointalk.org/Smileys/default/cheesy.gif) Great job in always watching the chain tacotime. Also looks like the fixes implemented are going to be different? Are you going with reduced max block size ?
|
|
|
|
whap
Member
![*](https://bitcointalk.org/Themes/custom1/images/star.gif)
Offline
Activity: 106
Merit: 10
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2014, 02:53:48 PM |
|
CZ updated the statement and acknowledged the XMR devs without any protests or reservation. This was most likely unintentional. Simple misunderstanding. The reactions of XMR devs are bit harsh IMHO....
We're just cranky because most of us haven't slept much ![Cheesy](https://bitcointalk.org/Smileys/default/cheesy.gif) AMEN. So lets put this to bed and move on. Where to from here? XMR & BBR joining SuperNET together? ![Tongue](https://bitcointalk.org/Smileys/default/tongue.gif) I would cry of joy. Boonero, Monerry, whatever.
|
|
|
|
smooth
Legendary
Offline
Activity: 2968
Merit: 1198
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2014, 02:54:14 PM |
|
CZ updated the statement and acknowledged the XMR devs without any protests or reservation. This was most likely unintentional. Simple misunderstanding. The reactions of XMR devs are bit harsh IMHO....
We're just cranky because most of us haven't slept much ![Cheesy](https://bitcointalk.org/Smileys/default/cheesy.gif) Great job in always watching the chain tacotime. Also looks like the fixes implemented are going to be different? Are you going with reduced max block size ? No that was just a temporarily work-around we were going to push out while continuing to work on the real fix (and CZ said he would do if needed for BBR). It won't be needed now, at least not for this bug.
|
|
|
|
tacotime
Legendary
Offline
Activity: 1484
Merit: 1005
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2014, 02:55:29 PM |
|
Great job in always watching the chain tacotime.
Also looks like the fixes implemented are going to be different? Are you going with reduced max block size ?
Nah, it was a simple overflow bug, the basic fix is the same, to just fix the horrible C code line that caused it. The long term fix is just tossing all the horribly dangerous C code that contains naked pointers and moving to something somewhat less terrible like C++.
|
XMR: 44GBHzv6ZyQdJkjqZje6KLZ3xSyN1hBSFAnLP6EAqJtCRVzMzZmeXTC2AHKDS9aEDTRKmo6a6o9r9j86pYfhCWDkKjbtcns
|
|
|
crypto_zoidberg (OP)
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2014, 02:55:39 PM |
|
UPD: Actually have to say that Monero devs has also fixed this bug independently in their own way. Good job.
Let's be clear about this. We have a different fix on github, but we also sent the exact same fix to you for your opinion well before "Cryptonote" (whoever that is) sent it out. Crediting it to "Cryptonote" when rfreeman_w and I had already debugged it and sent you the exact same fix first is pretty sad. At least give credit where credit is due. I expected better from you. Hey! You asked me to review your fix, but i said that i need time for it (because you rewrote whole merkle function), and then 15 minutes later arrived email from CryptoNote, with tiny little fix(with one line) - for me it was just more clear and obviouse that this fixed the problem. So why i have to wait and keep reading your fix? And despite this i also noticed later that you guys also has solved the problem and made good job. Sorry that i made you sad but you wrong. And i don't care what you expected.
|
|
|
|
tifozi
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2014, 03:05:10 PM |
|
Great job in always watching the chain tacotime.
Also looks like the fixes implemented are going to be different? Are you going with reduced max block size ?
Nah, it was a simple overflow bug, the basic fix is the same, to just fix the horrible C code line that caused it. The long term fix is just tossing all the horribly dangerous C code that contains naked pointers and moving to something somewhat less terrible like C++. Yes I got the merkle tree overflow stuff. I was asking specifically about the tree hash bug and what the fix was going to be .. To me both chains need to be co-exist. It is pretty obvious that XMR will continue to get targeted. It will only make the code better in the long term, but there will be targeted disruptions from time to time.
|
|
|
|
smooth
Legendary
Offline
Activity: 2968
Merit: 1198
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2014, 03:09:06 PM |
|
Great job in always watching the chain tacotime.
Also looks like the fixes implemented are going to be different? Are you going with reduced max block size ?
Nah, it was a simple overflow bug, the basic fix is the same, to just fix the horrible C code line that caused it. The long term fix is just tossing all the horribly dangerous C code that contains naked pointers and moving to something somewhat less terrible like C++. Yes I got the merkle tree overflow stuff. I was asking specifically about the tree hash bug and what the fix was going to be .. To me both chains need to be co-exist. It is pretty obvious that XMR will continue to get targeted. It will only make the code better in the long term, but there will be targeted disruptions from time to time. Both chains exist in the sense that they're stored on some computers somewhere, but the longest chain is the consensus.
|
|
|
|
tifozi
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2014, 03:10:33 PM |
|
Great job in always watching the chain tacotime.
Also looks like the fixes implemented are going to be different? Are you going with reduced max block size ?
Nah, it was a simple overflow bug, the basic fix is the same, to just fix the horrible C code line that caused it. The long term fix is just tossing all the horribly dangerous C code that contains naked pointers and moving to something somewhat less terrible like C++. Yes I got the merkle tree overflow stuff. I was asking specifically about the tree hash bug and what the fix was going to be .. To me both chains need to be co-exist. It is pretty obvious that XMR will continue to get targeted. It will only make the code better in the long term, but there will be targeted disruptions from time to time. Both chains exist in the sense that they're stored on some computers somewhere, but the longest chain is the consensus. I meant BBR and XMR, in the light of continued questions about BBR being the smaller network and folks questioning it from time to time.
|
|
|
|
rdnkjdi
Legendary
Offline
Activity: 1256
Merit: 1009
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2014, 03:12:17 PM |
|
Sorry that i made you sad but you wrong. And i don't care what you expected.
This rivalry cracks me up beyond belief.
|
|
|
|
smooth
Legendary
Offline
Activity: 2968
Merit: 1198
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2014, 03:13:51 PM |
|
You asked me to review your fix, but i said that i need time for it (because you rewrote whole merkle function)
Probably some confusion in communication. We had both fixes. rfreeman_w's code clean up in git hub and my *8 fix in IRC: [13:35] <rfreeman_w> it will break faster on 32 bit [13:35] <rfreeman_w> maybe for some implementation it would even pass for 514? [13:35] <sk00t3r> How can I confirm I am on the correct chain? My deamon has not been on in a few days. [13:36] <smooth> rfreeman_w sizeof(size_t)*8 i think. it should be bits not bytes [13:36] * taaku has quit (Client Quit)
I thought both were sent to you but perhaps I'm mistaken. Anyway, I'm glad this all got worked out, and I appreciate your help in analyzing the problem and helping us to fix our coin. Perhaps some day we can and (if so will) repay the favor, though hopefully not in kind.
|
|
|
|
tacotime
Legendary
Offline
Activity: 1484
Merit: 1005
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2014, 03:16:03 PM |
|
Yes I got the merkle tree overflow stuff. I was asking specifically about the tree hash bug and what the fix was going to be ..
To me both chains need to be co-exist. It is pretty obvious that XMR will continue to get targeted. It will only make the code better in the long term, but there will be targeted disruptions from time to time.
The fix is to stop coding in C, which should never be used for distributed consensus, and to refactor the codebase.
|
XMR: 44GBHzv6ZyQdJkjqZje6KLZ3xSyN1hBSFAnLP6EAqJtCRVzMzZmeXTC2AHKDS9aEDTRKmo6a6o9r9j86pYfhCWDkKjbtcns
|
|
|
aminorex
Legendary
Offline
Activity: 1596
Merit: 1029
Sine secretum non libertas
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2014, 03:18:06 PM |
|
Sorry that i made you sad but you wrong. And i don't care what you expected.
This rivalry cracks me up beyond belief. Welcome to Aspberger's School of Charm and Dignity.
|
Give a man a fish and he eats for a day. Give a man a Poisson distribution and he eats at random times independent of one another, at a constant known rate.
|
|
|
iCEBREAKER
Legendary
Offline
Activity: 2156
Merit: 1072
Crypto is the separation of Power and State.
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2014, 03:20:10 PM |
|
The long term fix is just tossing all the horribly dangerous C code that contains naked pointers and moving to something somewhat less terrible like C++.
Maybe the Cryptonote Foundation can hire Peter Todd or gmaxwell to port the entire thing over to an expanded Bitcoin codebase. Once the modularization is done, of course.
|
██████████ ██████████████████ ██████████████████████ ██████████████████████████ ████████████████████████████ ██████████████████████████████ ████████████████████████████████ ████████████████████████████████ ██████████████████████████████████ ██████████████████████████████████ ██████████████████████████████████ ██████████████████████████████████ ██████████████████████████████████ ████████████████████████████████ ██████████████ ██████████████ ████████████████████████████ ██████████████████████████ ██████████████████████ ██████████████████ ██████████ Monero
|
| "The difference between bad and well-developed digital cash will determine whether we have a dictatorship or a real democracy." David Chaum 1996 "Fungibility provides privacy as a side effect." Adam Back 2014
|
| | |
|
|
|
adaseb
Legendary
Offline
Activity: 3836
Merit: 1723
Up to 300% + 200 FS deposit bonuses
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2014, 03:29:36 PM |
|
Any idea why Bittrex wallet is disabled?
|
|
|
|
|