djm34
Legendary
Offline
Activity: 1400
Merit: 1050
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2015, 12:00:35 PM Last edit: September 04, 2015, 12:13:47 PM by djm34 |
|
Nah, 6.5 on both boxes. Slightly older 6.5.12 on Linux and 6.5.19 (the latest 6.5 + compute 5.2 support I think) on Windows. Tried x64 builds too, doesn't seem to make much of a difference either way. Weird shit. I did manage to make the win build a little better by manually unrolling stuff, just looks like the win version of nvcc isn't really trying to figure stuff out itself. Which brings me back to weird shit.
You should fork my branch and merge the lyra2 changes. My fork is already 500KHASH faster than the DJM34's opensource without modding the lyra2(only the other algos). Big donations are waiting. hmmm. I doubt that... I tried to use your modified kernels (cubehash, blakekeccak,bmw) and I mostly see no difference. there are some variability in the result but on a medium/long run it goes down to the same values I get with the standard kernels... edit: actually the main difference I saw from my original setting, was by raising the intensity (which is a parameter adjustable by the user even in my release)
|
djm34 facebook pageBTC: 1NENYmxwZGHsKFmyjTc5WferTn5VTFb7Ze Pledge for neoscrypt ccminer to that address: 16UoC4DmTz2pvhFvcfTQrzkPTrXkWijzXw
|
|
|
sp_ (OP)
Legendary
Offline
Activity: 2926
Merit: 1087
Team Black developer
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2015, 12:12:01 PM |
|
hmmm. I doubt that... I tried to use your modified kernels (cubehash, blakekeccak,bmw) and I mostly see no difference. there are some variability in the result but on a medium/long run it goes down to the same values I get with the standard kernels...
If the values go down over time it meens that your cards are trottling, because of heat or too low voltage. On my gtx 970 the miner is mining 500KHASH faster than yours. Release 62 standard clocks: (the 980ti is clocked at 1260 on the core) ![](https://ip.bitcointalk.org/?u=http%3A%2F%2Fi62.tinypic.com%2Fflekq9.png%26t%3D556%26c%3DVuerk7Dz1hH9uA&t=665&c=m-IBc-yUNDQzvw)
|
|
|
|
djm34
Legendary
Offline
Activity: 1400
Merit: 1050
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2015, 12:24:43 PM |
|
hmmm. I doubt that... I tried to use your modified kernels (cubehash, blakekeccak,bmw) and I mostly see no difference. there are some variability in the result but on a medium/long run it goes down to the same values I get with the standard kernels...
If the values go down over time it meens that your cards are trottling, because of heat or too low voltage. On my gtx 970 the miner is mining 500KHASH faster than yours. Release 62 standard clocks: (the 980ti is clocked at 1260 on the core) well, the argument isn't really relevant, if throttling happens it happens in the same way for every kernels (slow or fast), so if a kernel is faster it will remain faster no matter of any throttling and here it isn't the case... (test was done using default clock and tdp target of 100%)
|
djm34 facebook pageBTC: 1NENYmxwZGHsKFmyjTc5WferTn5VTFb7Ze Pledge for neoscrypt ccminer to that address: 16UoC4DmTz2pvhFvcfTQrzkPTrXkWijzXw
|
|
|
pallas
Legendary
Offline
Activity: 2716
Merit: 1094
Black Belt Developer
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2015, 12:28:26 PM |
|
hmmm. I doubt that... I tried to use your modified kernels (cubehash, blakekeccak,bmw) and I mostly see no difference. there are some variability in the result but on a medium/long run it goes down to the same values I get with the standard kernels...
If the values go down over time it meens that your cards are trottling, because of heat or too low voltage. On my gtx 970 the miner is mining 500KHASH faster than yours. Release 62 standard clocks: (the 980ti is clocked at 1260 on the core) well, the argument isn't really relevant, if throttling happens it happens in the same way for every kernels (slow or fast), so if a kernel is faster it will remain faster no matter of any throttling and here it isn't the case... (test was done using default clock and tdp target of 100%) If a kernel is faster it probably also draw more power, which in turn means more heat so higher chance of throttling. If an enhancement to a kernel has the same performance/watt ratio as the original, the card may throttle and bring the same performance using the same power but a lower clock speed. I'm talking general as I don't know if it's valid for this specific case.
|
|
|
|
go6ooo1212
Legendary
Offline
Activity: 1512
Merit: 1000
quarkchain.io
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2015, 12:48:32 PM |
|
Just got some GTX950 for weekend testing... Very exited... ![Smiley](https://bitcointalk.org/Smileys/default/smiley.gif)
|
|
|
|
bensam1231
Legendary
Offline
Activity: 1750
Merit: 1024
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2015, 02:19:55 PM |
|
hmmm. I doubt that... I tried to use your modified kernels (cubehash, blakekeccak,bmw) and I mostly see no difference. there are some variability in the result but on a medium/long run it goes down to the same values I get with the standard kernels...
If the values go down over time it meens that your cards are trottling, because of heat or too low voltage. On my gtx 970 the miner is mining 500KHASH faster than yours. Release 62 standard clocks: (the 980ti is clocked at 1260 on the core) well, the argument isn't really relevant, if throttling happens it happens in the same way for every kernels (slow or fast), so if a kernel is faster it will remain faster no matter of any throttling and here it isn't the case... (test was done using default clock and tdp target of 100%) Hypothetical... Faster kernel uses more power > cards get hotter > cards slow down. Although not always true. Sometimes it could mean that the card will use the same amount of power, it'll just be more heavily utilized and produce more heat. (Pallas beat me to this)
|
I buy private Nvidia miners. Send information and/or inquiries to my PM box.
|
|
|
djm34
Legendary
Offline
Activity: 1400
Merit: 1050
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2015, 02:41:52 PM |
|
hmmm. I doubt that... I tried to use your modified kernels (cubehash, blakekeccak,bmw) and I mostly see no difference. there are some variability in the result but on a medium/long run it goes down to the same values I get with the standard kernels...
If the values go down over time it meens that your cards are trottling, because of heat or too low voltage. On my gtx 970 the miner is mining 500KHASH faster than yours. Release 62 standard clocks: (the 980ti is clocked at 1260 on the core) well, the argument isn't really relevant, if throttling happens it happens in the same way for every kernels (slow or fast), so if a kernel is faster it will remain faster no matter of any throttling and here it isn't the case... (test was done using default clock and tdp target of 100%) If a kernel is faster it probably also draw more power, which in turn means more heat so higher chance of throttling. If an enhancement to a kernel has the same performance/watt ratio as the original, the card may throttle and bring the same performance using the same power but a lower clock speed. I'm talking general as I don't know if it's valid for this specific case. heat isn't really part of the equation, the 980 never runs hotter than 75°C (and currently are running at 71°C and the limit before throttling is the standard nvidia one 81°C), also the power hungry in this miner is lyra (well... the private one...) basically the other algo don't use a lots of power in lyra2re setup (keccak, bmw256 and blake are very fast algo and are used with a much smaller throughput than the one they can handle alone... so they is no big difference in power consumption in this setup
|
djm34 facebook pageBTC: 1NENYmxwZGHsKFmyjTc5WferTn5VTFb7Ze Pledge for neoscrypt ccminer to that address: 16UoC4DmTz2pvhFvcfTQrzkPTrXkWijzXw
|
|
|
pallas
Legendary
Offline
Activity: 2716
Merit: 1094
Black Belt Developer
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2015, 03:09:51 PM |
|
I've pushed some little patches with more compact code and little speedups for quark and x11 (also less build warnings). Sorry Sp_ for the 4 pull requests instead of one: I made them on github directly and couldn't find a way to send a single pull request with more patches (or make a single patch from multiple file edits).
|
|
|
|
flipclip
Member
![*](https://bitcointalk.org/Themes/custom1/images/star.gif)
Offline
Activity: 111
Merit: 10
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 04, 2015, 04:33:54 PM |
|
Sorry Sp_ for the 4 pull requests instead of one: I made them on github directly and couldn't find a way to send a single pull request with more patches (or make a single patch from multiple file edits).
I don't believe there is a way via the web interface. This could be a workaround, but haven't tried it (from: http://stackoverflow.com/questions/17815895/can-i-edit-two-files-then-make-one-commit-using-github-web-based-editor): Create a temporary branch, switch to it; Edit multiple files, commit each file separately; Make pull request; Merge pull request and delete temporary branch.
|
|
|
|
Slava_K
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 05, 2015, 07:54:14 AM Last edit: September 05, 2015, 08:59:46 AM by Slava_K |
|
Pallas patches broke compilation... ![Grin](https://bitcointalk.org/Smileys/default/grin.gif) OOOPS...Redownload ant try to recompilate! Errores in groestl_functions_quad.cu and cuda_helper.h Win10 and ms vs2013
|
|
|
|
pallas
Legendary
Offline
Activity: 2716
Merit: 1094
Black Belt Developer
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 05, 2015, 09:20:05 AM |
|
Pallas patches broke compilation... ![Grin](https://bitcointalk.org/Smileys/default/grin.gif) OOOPS...Redownload ant try to recompilate! Errores in groestl_functions_quad.cu and cuda_helper.h Win10 and ms vs2013 I didn't modify cuda_helper.h Try compiling from scratch. EDIT: could you please paste the errors here?
|
|
|
|
Slava_K
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 05, 2015, 09:40:21 AM |
|
Error 18 error : identifier "uint8" is undefined c:\ccminer-windows\groestl_functions_quad.cu 489 1 ccminer Error 19 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 489 1 ccminerError 18 error : identifier "uint8" is undefined c:\ccminer-windows\groestl_functions_quad.cu 489 1 ccminer Error 19 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 489 1 ccminer Error 20 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 489 1 ccminer Error 21 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 489 1 ccminer Error 22 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 489 1 ccminer Error 23 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 496 1 ccminer Error 24 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 496 1 ccminer Error 25 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 496 1 ccminer Error 26 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 496 1 ccminer Error 27 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 497 1 ccminer Error 28 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 497 1 ccminer Error 29 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 497 1 ccminer Error 30 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 497 1 ccminer Error 31 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 501 1 ccminer Error 32 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 501 1 ccminer Error 33 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 501 1 ccminer Error 34 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 501 1 ccminer Error 35 error MSB3721: The command ""C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v6.5\bin\nvcc.exe" -gencode=arch=compute_50,code=\"sm_50,compute_50\" -gencode=arch=compute_52,code=\"sm_52,compute_52\" --use-local-env --cl-version 2013 -ccbin "C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\bin" -I. -Icompat -I"compat\curl-for-windows\curl\include" -Icompat\jansson -Icompat\getopt -Icompat\pthreads -I"compat\curl-for-windows\openssl\openssl\include" -I"compat\curl-for-windows\zlib" -I"C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v6.5\include" -I"C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v6.5\include" -I"C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v6.5\include" --keep --keep-dir Release -maxrregcount=80 --ptxas-options=-v --machine 32 --compile -cudart static --ptxas-options="-O3" -DWIN32 -DNDEBUG -D_CONSOLE -D_CRT_SECURE_NO_WARNINGS -DCURL_STATICLIB -DUSE_WRAPNVML -DSCRYPT_KECCAK512 -DSCRYPT_CHACHA -DSCRYPT_CHOOSE_COMPILETIME -D_MBCS -Xcompiler "/EHsc /W3 /nologo /Ox /Zi /MT " -o Release\cuda_groestlcoin.cu.obj "C:\ccminer-windows\cuda_groestlcoin.cu"" exited with code 2. C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\BuildCustomizations\CUDA 6.5.targets 593 9 ccminer
|
|
|
|
djm34
Legendary
Offline
Activity: 1400
Merit: 1050
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 05, 2015, 10:08:38 AM |
|
Error 18 error : identifier "uint8" is undefined c:\ccminer-windows\groestl_functions_quad.cu 489 1 ccminer Error 19 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 489 1 ccminerError 18 error : identifier "uint8" is undefined c:\ccminer-windows\groestl_functions_quad.cu 489 1 ccminer Error 19 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 489 1 ccminer Error 20 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 489 1 ccminer Error 21 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 489 1 ccminer Error 22 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 489 1 ccminer Error 23 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 496 1 ccminer Error 24 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 496 1 ccminer Error 25 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 496 1 ccminer Error 26 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 496 1 ccminer Error 27 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 497 1 ccminer Error 28 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 497 1 ccminer Error 29 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 497 1 ccminer Error 30 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 497 1 ccminer Error 31 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 501 1 ccminer Error 32 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 501 1 ccminer Error 33 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 501 1 ccminer Error 34 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 501 1 ccminer Error 35 error MSB3721: The command ""C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v6.5\bin\nvcc.exe" -gencode=arch=compute_50,code=\"sm_50,compute_50\" -gencode=arch=compute_52,code=\"sm_52,compute_52\" --use-local-env --cl-version 2013 -ccbin "C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\bin" -I. -Icompat -I"compat\curl-for-windows\curl\include" -Icompat\jansson -Icompat\getopt -Icompat\pthreads -I"compat\curl-for-windows\openssl\openssl\include" -I"compat\curl-for-windows\zlib" -I"C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v6.5\include" -I"C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v6.5\include" -I"C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v6.5\include" --keep --keep-dir Release -maxrregcount=80 --ptxas-options=-v --machine 32 --compile -cudart static --ptxas-options="-O3" -DWIN32 -DNDEBUG -D_CONSOLE -D_CRT_SECURE_NO_WARNINGS -DCURL_STATICLIB -DUSE_WRAPNVML -DSCRYPT_KECCAK512 -DSCRYPT_CHACHA -DSCRYPT_CHOOSE_COMPILETIME -D_MBCS -Xcompiler "/EHsc /W3 /nologo /Ox /Zi /MT " -o Release\cuda_groestlcoin.cu.obj "C:\ccminer-windows\cuda_groestlcoin.cu"" exited with code 2. C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\BuildCustomizations\CUDA 6.5.targets 593 9 ccminer
needs to include cuda_vector.h instead of cuda_helper.h
|
djm34 facebook pageBTC: 1NENYmxwZGHsKFmyjTc5WferTn5VTFb7Ze Pledge for neoscrypt ccminer to that address: 16UoC4DmTz2pvhFvcfTQrzkPTrXkWijzXw
|
|
|
pallas
Legendary
Offline
Activity: 2716
Merit: 1094
Black Belt Developer
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 05, 2015, 10:21:06 AM |
|
Error 18 error : identifier "uint8" is undefined c:\ccminer-windows\groestl_functions_quad.cu 489 1 ccminer Error 19 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 489 1 ccminerError 18 error : identifier "uint8" is undefined c:\ccminer-windows\groestl_functions_quad.cu 489 1 ccminer Error 19 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 489 1 ccminer Error 20 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 489 1 ccminer Error 21 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 489 1 ccminer Error 22 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 489 1 ccminer Error 23 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 496 1 ccminer Error 24 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 496 1 ccminer Error 25 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 496 1 ccminer Error 26 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 496 1 ccminer Error 27 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 497 1 ccminer Error 28 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 497 1 ccminer Error 29 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 497 1 ccminer Error 30 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 497 1 ccminer Error 31 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 501 1 ccminer Error 32 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 501 1 ccminer Error 33 error : expected an expression c:\ccminer-windows\groestl_functions_quad.cu 501 1 ccminer Error 34 error : expected a ")" c:\ccminer-windows\groestl_functions_quad.cu 501 1 ccminer Error 35 error MSB3721: The command ""C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v6.5\bin\nvcc.exe" -gencode=arch=compute_50,code=\"sm_50,compute_50\" -gencode=arch=compute_52,code=\"sm_52,compute_52\" --use-local-env --cl-version 2013 -ccbin "C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\bin" -I. -Icompat -I"compat\curl-for-windows\curl\include" -Icompat\jansson -Icompat\getopt -Icompat\pthreads -I"compat\curl-for-windows\openssl\openssl\include" -I"compat\curl-for-windows\zlib" -I"C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v6.5\include" -I"C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v6.5\include" -I"C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v6.5\include" --keep --keep-dir Release -maxrregcount=80 --ptxas-options=-v --machine 32 --compile -cudart static --ptxas-options="-O3" -DWIN32 -DNDEBUG -D_CONSOLE -D_CRT_SECURE_NO_WARNINGS -DCURL_STATICLIB -DUSE_WRAPNVML -DSCRYPT_KECCAK512 -DSCRYPT_CHACHA -DSCRYPT_CHOOSE_COMPILETIME -D_MBCS -Xcompiler "/EHsc /W3 /nologo /Ox /Zi /MT " -o Release\cuda_groestlcoin.cu.obj "C:\ccminer-windows\cuda_groestlcoin.cu"" exited with code 2. C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\BuildCustomizations\CUDA 6.5.targets 593 9 ccminer
needs to include cuda_vector.h instead of cuda_helper.h I didn't modify the includes. Furthermore, it compiles fine on Linux... I know the build files on windows have been enhanced recently, maybe it's related to that. I can't help because I never built on win.
|
|
|
|
sp_ (OP)
Legendary
Offline
Activity: 2926
Merit: 1087
Team Black developer
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 05, 2015, 10:41:20 AM |
|
I submitted a fix for the build
|
|
|
|
sp_ (OP)
Legendary
Offline
Activity: 2926
Merit: 1087
Team Black developer
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 05, 2015, 10:59:13 AM |
|
Quark is a bit slower with the last commits.
old hasrate: 55091
last hashrate: 54550
|
|
|
|
ldp5500
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 05, 2015, 11:14:07 AM |
|
Someone with GTX750 mining it? Quark and X11 speed? Which version of the software used? THX!
|
|
|
|
pallas
Legendary
Offline
Activity: 2716
Merit: 1094
Black Belt Developer
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 05, 2015, 11:34:36 AM |
|
Quark is a bit slower with the last commits.
old hasrate: 55091
last hashrate: 54550
I don't think it can be because of the vector operations. So it must be the rotr32 of cuda_helper, but that has been used on most of the other files for months. As a test, could you replace rotr32 definition with "rotate" and see if it's faster?
|
|
|
|
sp_ (OP)
Legendary
Offline
Activity: 2926
Merit: 1087
Team Black developer
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 05, 2015, 11:45:12 AM |
|
I reverted the jh512 change and the rotr32 change. The compiler is already using the funnelshift to do the rotl32. And when you use the "fast" method. the exefile get 3kb bigger.
I think it's because the compiler is unable to precalculate and remove instructions that operate on contant data when we use inline asm. rotl(const,x)
the jh512 change is bad on the 750ti loose 100khash
|
|
|
|
pallas
Legendary
Offline
Activity: 2716
Merit: 1094
Black Belt Developer
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
September 05, 2015, 11:52:32 AM |
|
I reverted the jh512 change and the rotr change.
That is suspect: quark jh and x11 bmw were redefining rotr32 with the original sph code, while all the rest use the cuda_helper version which has specific cuda code. If the cuda specific code is slower, than we should replace the rotr32 definition in cuda_helper because all the other files will benefit from it. But I highly doubt that it's the case: cuda_helper has been worked on for months and it can't be slower than sph code, unless the compiler is so smart that it can detect it's a rotate and replace it with even more optimized code. In brief, I wouldn't reput the double definitions (it's a warning...) but adjust the cuda_helper version, so we have the best rotr32 on all algos.
|
|
|
|
|