Sampey (OP)
Legendary
Offline
Activity: 2632
Merit: 1040
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
January 29, 2017, 04:44:28 PM |
|
FYI, I'm using C.A.T. 4.6 and I'm still seeing trades on Poloniex being calculated incorrectly. For example, I buy 0.80 BTC worth of Qora at 10 satoshi's using CAT (8000000.00000000 qora). Fee is 0.15%, which is 12,000 qora. However, CAT leaves behind 0.1 % or 8,000 qora. These are not sold at 11 satoshis. Instead, only 7980000 are sold, 8,000 fewer than should have been.
Is the Poloniex API returning the wrong fee or is CAT still hard-coded for 0.25% for Poloniex for all trades?
Fees for polo on 4.6 are calculate right. I need to take a look at rules for PONG creation after a trade. Do you have a log where this Qora order is created? This could help me understand
|
|
|
|
otp
Newbie
Offline
Activity: 21
Merit: 0
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
January 29, 2017, 06:17:30 PM |
|
Here is the log -- is this the right log or do I need to locate the api log? Here is the gain log:
|
|
|
|
Sampey (OP)
Legendary
Offline
Activity: 2632
Merit: 1040
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
January 29, 2017, 06:36:09 PM |
|
it seems that FEES were 0.25% (Taker) For that trade.
In fact if i remove the 0.25% expressed as QTY from the 8000000 QTY of the PING TRADE i get exactly 7980000
|
|
|
|
otp
Newbie
Offline
Activity: 21
Merit: 0
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
January 29, 2017, 06:41:54 PM |
|
No, it was a market making trade. The market was static, and the buy order was placed as a buy order at 10 satoshis when Qora was trading between 12 and 13 satoshis. Perhaps the error is in Poloniex's API results? I'm printing the API call results to the CAT console and doing another market making trade. I will paste the API results in a new reply when I have them.
|
|
|
|
otp
Newbie
Offline
Activity: 21
Merit: 0
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
January 29, 2017, 06:55:15 PM |
|
Here are the API results of another test trade (PING BUY ORDER STATIC): 2017-01-29 12:44:11| https://poloniex.com/tradingApi[{"globalTradeID":77611357,"tradeID":"123546","date":"2017-01-29 18:40:52","rate":"0.00000011","amount":"99999.99999999","total":"0.01099999","fee":"0.00150000","orderNumber":"1087563427","type":"buy","category":"exchange"} And here is how CAT created the PONG sell order: And now I have 100 Qora sitting idle (0.10% of 99999.99999999 ). CAT treated the trade as one with a 0.25% fee. This is CAT 4.6 I'm running. The pong sell trade should have been 99849.99999999.
|
|
|
|
Sampey (OP)
Legendary
Offline
Activity: 2632
Merit: 1040
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
January 29, 2017, 07:12:33 PM |
|
Here are the API results of another test trade (PING BUY ORDER STATIC): 2017-01-29 12:44:11| https://poloniex.com/tradingApi[{"globalTradeID":77611357,"tradeID":"123546","date":"2017-01-29 18:40:52","rate":"0.00000011","amount":"99999.99999999","total":"0.01099999","fee":"0.00150000","orderNumber":"1087563427","type":"buy","category":"exchange"} And here is how CAT created the PONG sell order: And now I have 100 Qora sitting idle (0.10% of 99999.99999999 ). CAT treated the trade as one with a 0.25% fee. This is CAT 4.6 I'm running. The pong sell trade should have been 99849.99999999. I'm looking at the code, but fees are readed from the fees field and the applied over the total amount. I need to check somewhere else. Just a question : if you load your trades from the market explorer, are your fees calculated in the right way?
|
|
|
|
Sampey (OP)
Legendary
Offline
Activity: 2632
Merit: 1040
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
January 29, 2017, 07:21:13 PM |
|
OK, i've found the problem. The routine that calculate the fees to subtract from a trade ping use the "default" market fees of 25% I will write the fix for the 4.7 version. This problem occurs only on exchange where fees are dynamic (taker fees different from maker fees). Thank you so much for finding this ![Wink](https://bitcointalk.org/Smileys/default/wink.gif)
|
|
|
|
otp
Newbie
Offline
Activity: 21
Merit: 0
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
January 29, 2017, 08:01:26 PM |
|
Glad to help! :-)
Now, I mentioned GDAX API as a possible new exchange for CAT. However, they do have user id verification requirements. I will see if there are exceptions to this, or if a developer like you could work with their API Sandbox without the need to go through the process. I'll be sure to post back here what I find.
Thanks. I've found C.A.T. 4.6 to be the best version C.A.T. yet. Works better than previous versions.
|
|
|
|
Sampey (OP)
Legendary
Offline
Activity: 2632
Merit: 1040
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
January 29, 2017, 08:04:13 PM |
|
Thank you so much, and 4.7 I hope will works better ![Grin](https://bitcointalk.org/Smileys/default/grin.gif)
|
|
|
|
Sampey (OP)
Legendary
Offline
Activity: 2632
Merit: 1040
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
January 29, 2017, 09:47:37 PM |
|
Hi C.A.T. users, this is the 4.7 ChangeLog - Added TuxExchange API - Addeq Liqui API - Added the LOGS MANAGER. You can reach it from the MAIN Toolbar TOOLS -> LOG MANAGER. You'll be able to delete logs from CATSystem Folder. - Various GUI/Code Fix/Improvements/Some Algo Parameters has been moved to a more appropriate panel - Big Improvements in some market log messages (more verbose, more info, easier to read) - XRP Markets on Bitstamps are Available - Complete Review Of Current Parameters Print Routine (Parameters are reorded according to parameter tabs) - Now Api calls are able to maintains original data result even if an error occurs. When an api parse error occurs (for any reason) you will have a CONSOLE LOG with Error + Api Response + Error Trace. This will help me a lot to give support and you to understand some errors (ex "Error:Too Many Api Call") - On The Rock Trading Exchange/Poloniex you can now have Available and Held Portfolio Amount. - After a Ping-Pong complete a full summary of the ping-pong will be added in the MARKET LOG (with Green Font). - 2 Advanced Options Are Added : A - Consider % Of Your Real <Market>/<Partner> Balance (this will allows CAT to consider less than your real portfolio value) B - Subtract All Buy/Sell Pool Current Values While Considering Available Amounts (this will allows CAT to subtract the temporary buy/sell pool values from available amounts) - 1 Buy/Sell Pool Option is Added : "If Necessary, Adequate Pool Order to Min Total (Qty*Price)" this option will be only for new PING From Pool. The old Option is renamed to "If Necessary, Adequate Ping/Pong Order to Min Total (Qty*Price)" and it will works for all the other cases. - 2 Buy/Sell Pool Option Added : - Add Fix <MARKET> Amount into Sell Pool Every Pool Lookup (expressed as MARKET QTY, CAT will convert into <Partner> using last market price) - Add Fix <PARTNER> Amount into Buy Pool Every Pool Lookup (expressed as PARTNER QTY) - Added a Check Option for Buy/Sell Pool : If Pool Values > Available Amount then Adequate Pool Values to Available Amount - Added a Buy/Sell Pool Option "RESET BSP if current left value is < X" - Options "Stop Ping Sell/Buy Creation if Value is >/< X" are renamed into "Stop Ping Creation If Current Market Sell/Buy Value is >/< X" and are moved into Buy/Sell Pool Options And they works also for STATIC Algorithm (previously they works only for Dynamic Algorithm) - Options "Stop Ping Creation After X Ping-Pong Completed"/"Stop Ping Creation If number Of Active Orders Is"/"Stop Ping Creation If Total Order Amount is > X" Are moved to Buy/Sell Pool Options
And these are the next steps : - I will complete my tasks with Liqui/TuxExchange admins - I will start giving (you can already PM me now, CAT 4.7 Beta to all CAT users who ask me) - I will update the full guide according to 4.7 Version - I will release 4.7 Official To all CAT Users
|
|
|
|
Sampey (OP)
Legendary
Offline
Activity: 2632
Merit: 1040
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
January 29, 2017, 11:10:45 PM |
|
|
|
|
|
Velgelm
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
January 30, 2017, 08:13:06 AM |
|
we will waiting .... ![Smiley](https://bitcointalk.org/Smileys/default/smiley.gif)
|
|
|
|
chem1cals
Newbie
Offline
Activity: 2
Merit: 0
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
January 30, 2017, 01:59:00 PM |
|
|
|
|
|
Sampey (OP)
Legendary
Offline
Activity: 2632
Merit: 1040
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
January 30, 2017, 03:03:21 PM |
|
i think i found a bug v4.7 ![](https://ip.bitcointalk.org/?u=http%3A%2F%2Fimageshack.com%2Fa%2Fimg924%2F9265%2FkH97lx.jpg&t=665&c=oodkyug28Y82DA) I cannot understand from one image if these are orders or trades. And if they are active at the same time. I didn't touch the merge routines from 4.6 to 4.7
|
|
|
|
Sampey (OP)
Legendary
Offline
Activity: 2632
Merit: 1040
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
January 30, 2017, 09:36:29 PM |
|
Don't forget to ask me the 4.7 Version Beta. BETA is usually the definitive version, only if someone found a bug i will fix it before official release. ![Wink](https://bitcointalk.org/Smileys/default/wink.gif)
|
|
|
|
Jatenocide
Newbie
Offline
Activity: 10
Merit: 0
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
January 31, 2017, 01:36:00 AM |
|
Can you please add huobi API?
|
|
|
|
Sampey (OP)
Legendary
Offline
Activity: 2632
Merit: 1040
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
January 31, 2017, 07:44:44 AM |
|
Can you please add huobi API?
Actually is not planned ![Undecided](https://bitcointalk.org/Smileys/default/undecided.gif) But if a lot of people are interested in i could add in the future.
|
|
|
|
Sampey (OP)
Legendary
Offline
Activity: 2632
Merit: 1040
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
January 31, 2017, 11:54:35 PM |
|
|
|
|
|
Sampey (OP)
Legendary
Offline
Activity: 2632
Merit: 1040
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
February 01, 2017, 09:48:42 AM |
|
IMPORTANT FOR BETA TESTER
A little problem i've already fix (it's a regression problem you won't be affected if you don't load an XML file from CAT 4.6)
- The parameter "STOP PING CREATION IF CURRENT MARKET SELL PRICE IS > X" have default value 0 in CAT 4.6 and 99999+ in CAT 4.7
So if you load a 4.6 XML File, you will have a console message like :
2017-01-31 17:36:27| BSP : |Stop Ping Creation If Current Market Sell Price is > 0.0000| Current Market Sell Price Is : 879.9996
And PING creation won't continue.
Solution : Update that parameter to 9999999 (That is CAT 4.7 Default Value).
I Repeat : In 4.7 OFFICIAL, i've added a check to let's you load a 4.6 File without problems.
Thanks
|
|
|
|
ewibit
Legendary
Offline
Activity: 2955
Merit: 1050
|
![](https://bitcointalk.org/Themes/custom1/images/post/xx.gif) |
February 03, 2017, 03:48:34 PM |
|
IMPORTANT FOR BETA TESTER
A little problem i've already fix (it's a regression problem you won't be affected if you don't load an XML file from CAT 4.6)
- The parameter "STOP PING CREATION IF CURRENT MARKET SELL PRICE IS > X" have default value 0 in CAT 4.6 and 99999+ in CAT 4.7
So if you load a 4.6 XML File, you will have a console message like :
2017-01-31 17:36:27| BSP : |Stop Ping Creation If Current Market Sell Price is > 0.0000| Current Market Sell Price Is : 879.9996
And PING creation won't continue.
Solution : Update that parameter to 9999999 (That is CAT 4.7 Default Value).
I Repeat : In 4.7 OFFICIAL, i've added a check to let's you load a 4.6 File without problems.
Thanks
I was shocked about this and CAT is tranquilized since I got the beta because of no delight to sacrifice pointless time done again... hope it will work in future
|
|
|
|
|