ThomasV (OP)
Moderator
Legendary
Offline
Activity: 1896
Merit: 1353
|
|
December 11, 2011, 10:16:52 AM |
|
I don't quite understand this random number generation algorithm (the "randrange_from_seed_trytryagain"). It seems overly complicated to me.
this function call is not needed. It is still in the code because it was used in the first version of Electrum, where the key was derived from a user-chosen passphrase. Since user-chosen passphrases are not secure enough, I replaced them with 128 bits random seeds, but I kept this function call in the code for backward compatibility. I will remove it when we switch to type 2 wallets.
|
Electrum: the convenience of a web wallet, without the risks
|
|
|
molecular
Donator
Legendary
Offline
Activity: 2772
Merit: 1019
|
|
December 11, 2011, 02:35:01 PM |
|
A suggestion: it would be nice to see the number of confimations of each transaction in the history tab.
|
PGP key molecular F9B70769 fingerprint 9CDD C0D3 20F8 279F 6BE0 3F39 FC49 2362 F9B7 0769
|
|
|
ThomasV (OP)
Moderator
Legendary
Offline
Activity: 1896
Merit: 1353
|
|
December 11, 2011, 02:38:31 PM |
|
A suggestion: it would be nice to see the number of confimations of each transaction in the history tab.
you have it in the tooltip, and also in the details of the transaction (navigate the history and press enter). I did not want to display it directly, because it makes bitcoin look complicated, and it becomes irrelevant after a few blocks (who wants to know if a tx has 452 or 435 confirmations?)
|
Electrum: the convenience of a web wallet, without the risks
|
|
|
BTCurious
|
|
December 11, 2011, 02:48:45 PM |
|
Litecoin has this nice clock-like icon for pending transactions. If it has 6 or more, it just shows a check-mark. If it has less, it's a pie-chart that fills up, and changes from red for no confirmations, to green for 5 confirmations.
|
|
|
|
ThomasV (OP)
Moderator
Legendary
Offline
Activity: 1896
Merit: 1353
|
|
December 11, 2011, 02:53:51 PM |
|
Litecoin has this nice clock-like icon for pending transactions. If it has 6 or more, it just shows a check-mark. If it has less, it's a pie-chart that fills up, and changes from red for no confirmations, to green for 5 confirmations.
yes, we could do that; for the moment there are only 2 icons (pending and confirmed) but we can add more
|
Electrum: the convenience of a web wallet, without the risks
|
|
|
|
molecular
Donator
Legendary
Offline
Activity: 2772
Merit: 1019
|
|
December 13, 2011, 12:39:47 AM |
|
A suggestion: it would be nice to see the number of confimations of each transaction in the history tab.
you have it in the tooltip, and also in the details of the transaction (navigate the history and press enter). I did not want to display it directly, because it makes bitcoin look complicated, and it becomes irrelevant after a few blocks (who wants to know if a tx has 452 or 435 confirmations?) lol, maybe I should read some book about this gui? Enter? Really? That works? I've been double-clicking the stuff in history to death . The tooltips (everywhere) only work very seldomly here. Please enable double-click, so people can find this feature Any other hidden rooms or secret keys to press?
|
PGP key molecular F9B70769 fingerprint 9CDD C0D3 20F8 279F 6BE0 3F39 FC49 2362 F9B7 0769
|
|
|
ThomasV (OP)
Moderator
Legendary
Offline
Activity: 1896
Merit: 1353
|
|
December 13, 2011, 06:40:25 AM |
|
lol, maybe I should read some book about this gui? Enter? Really? That works? I've been double-clicking the stuff in history to death . The tooltips (everywhere) only work very seldomly here. Please enable double-click, so people can find this feature ok, that's done. thanks for the feedback, btw. Any other hidden rooms or secret keys to press?
well, I guess you already noticed that labels can be edited
|
Electrum: the convenience of a web wallet, without the risks
|
|
|
grondilu
Legendary
Offline
Activity: 1288
Merit: 1080
|
|
December 13, 2011, 07:24:13 AM |
|
As I am translating the client, I have a few comments/suggestions: - Shouldn't the wallet store its own version number? Otherwise we'll need to guess it when we recover an old wallet. - It would be nice if a standard data format such as JSON was used to communicate with the server - The 'for_change' thing in 'create_new_address' is a bit odd. I suggest considering the created address to be 'for change' when no password is provided. - In the wallet, addresses should be stored in a dictionnary, not an array. Pretty much everything should be stored in a dictionnary anyway. We don't need sequential access, except maybe for the change_addresses index. - There is way too many Object Orientation in the code, imho. Objects are useful when instanciation is needed. Otherwise packages or modules are just fine. Other ideas I may forget may be seen in my repo: http://github.com/grondilu/Perlectrum in Bitcoin/Electrum/Client.pm
|
|
|
|
finway
|
|
December 13, 2011, 07:27:23 AM |
|
Hope the Qt edition comes out quickly, can't run it right now.
|
|
|
|
ThomasV (OP)
Moderator
Legendary
Offline
Activity: 1896
Merit: 1353
|
|
December 13, 2011, 08:32:19 AM |
|
- Shouldn't the wallet store its own version number? Otherwise we'll need to guess it when we recover an old wallet.
the wallet stores its version number. see SEED_VERSION. Also remember that the current version is not the final one. there will be at lese one more change to the seed generation. - It would be nice if a standard data format such as JSON was used to communicate with the server
indeed - The 'for_change' thing in 'create_new_address' is a bit odd. I suggest considering the created address to be 'for change' when no password is provided.
I do not understand what you mean. the password is necessary to create a new address (for now, until we have type 2 wallets) - In the wallet, addresses should be stored in a dictionnary, not an array. Pretty much everything should be stored in a dictionnary anyway.
Yes this is one option. Someone else suggested using ParseConfig
|
Electrum: the convenience of a web wallet, without the risks
|
|
|
slush
Legendary
Offline
Activity: 1386
Merit: 1097
|
|
December 13, 2011, 09:40:55 AM |
|
Hope the Qt edition comes out quickly,
I'm spending much more time in my job than I expected, so Qt must wait few days, sorry .
|
|
|
|
molecular
Donator
Legendary
Offline
Activity: 2772
Merit: 1019
|
|
December 13, 2011, 02:15:26 PM |
|
I found a small annoyance: Traceback (most recent call last): File "/mnt/sda3/home/nick/bitcoin/electrum/client/gui.py", line 491, in update_wallet_thread self.wallet.new_session() File "client/electrum.py", line 474, in new_session self.session_id, self.message = ast.literal_eval( self.request( repr ( ('session', repr(self.addresses) )))) File "client/electrum.py", line 452, in request s.connect(( self.host, self.port)) File "/usr/lib/python2.7/socket.py", line 224, in meth return getattr(self._sock,name)(*args) error: [Errno 101] Network is unreachable Traceback (most recent call last): File "/mnt/sda3/home/nick/bitcoin/electrum/client/gui.py", line 491, in update_wallet_thread self.wallet.new_session() File "client/electrum.py", line 474, in new_session self.session_id, self.message = ast.literal_eval( self.request( repr ( ('session', repr(self.addresses) )))) File "client/electrum.py", line 452, in request s.connect(( self.host, self.port)) File "/usr/lib/python2.7/socket.py", line 224, in meth return getattr(self._sock,name)(*args) error: [Errno 101] Network is unreachable
clearly the network is unrechable (which can happen at times, of course) nothing more after that. I guess this happens when my dynamic ip changes. Electrum doesn't seem to try to reconnect after that, just sits there. An unsuspecting gui user might wait indefinitely for some money to show up, for example and start to worry. The gui doesn't show any problem, I think it even shows a "green light" (will observe that again)
|
PGP key molecular F9B70769 fingerprint 9CDD C0D3 20F8 279F 6BE0 3F39 FC49 2362 F9B7 0769
|
|
|
ThomasV (OP)
Moderator
Legendary
Offline
Activity: 1896
Merit: 1353
|
|
December 13, 2011, 02:17:21 PM |
|
Electrum doesn't seem to try to reconnect after that, just sits there.
what makes you believe that it did not reconnect ? did the icon remain red?
|
Electrum: the convenience of a web wallet, without the risks
|
|
|
molecular
Donator
Legendary
Offline
Activity: 2772
Merit: 1019
|
|
December 13, 2011, 02:24:25 PM |
|
Electrum doesn't seem to try to reconnect after that, just sits there.
what makes you believe that it did not reconnect ? did the icon remain red? Didn't say the icon was red. I even assumed it stayed green. I'm pretty sure it didn't reconnect, because I had some money sent and it didn't show in history (after many hours). It showed right away after a restart.
|
PGP key molecular F9B70769 fingerprint 9CDD C0D3 20F8 279F 6BE0 3F39 FC49 2362 F9B7 0769
|
|
|
GideonGono
|
|
December 14, 2011, 12:56:22 AM |
|
I have an old wallet.dat file (the one before encryption) can I recover the wallet using Electrum? If so, how?
|
|
|
|
Red Emerald
|
|
December 14, 2011, 06:49:39 AM |
|
Can you add support for green addresses?
Essentially its a list of addresses that you will trust even with 0 confirmations.
|
|
|
|
ThomasV (OP)
Moderator
Legendary
Offline
Activity: 1896
Merit: 1353
|
|
December 14, 2011, 10:52:21 AM |
|
I have an old wallet.dat file (the one before encryption) can I recover the wallet using Electrum? If so, how?
no, you need to use the official bitcoin client in order to open wallet.dat; Electrum uses a different wallet format. did you try with the official bitcoin client?
|
Electrum: the convenience of a web wallet, without the risks
|
|
|
GideonGono
|
|
December 15, 2011, 03:32:10 AM |
|
I have an old wallet.dat file (the one before encryption) can I recover the wallet using Electrum? If so, how?
no, you need to use the official bitcoin client in order to open wallet.dat; Electrum uses a different wallet format. did you try with the official bitcoin client? Yeah and it's not working. It just stays at 0 blocks downloaded no matter how long I wait. If I just start the original client with a new wallet it downloads the block chain with no problems.
|
|
|
|
ThomasV (OP)
Moderator
Legendary
Offline
Activity: 1896
Merit: 1353
|
|
December 15, 2011, 02:57:29 PM |
|
Can you add support for green addresses?
Essentially its a list of addresses that you will trust even with 0 confirmations.
what would be the desired behaviour when coins come from such an address?
|
Electrum: the convenience of a web wallet, without the risks
|
|
|
|