Bitcoin Forum
December 11, 2016, 02:31:40 AM *
News: To be able to use the next phase of the beta forum software, please ensure that your email address is correct/functional.
 
   Home   Help Search Donate Login Register  
Pages: « 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 [27] 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 ... 96 »
  Print  
Author Topic: [ANNOUNCE] Electrum - Lightweight Bitcoin Client  (Read 243528 times)
duncant
Jr. Member
*
Offline Offline

Activity: 53


View Profile
May 17, 2012, 05:39:17 AM
 #521

Hi! I have 5 bugs to report:


1) I get the following error when running "electrum addresses -k" with imported keys (and an unencrypted wallet). I strongly suspect that this is due to how tags are stored with imported keys. It manages to print all the keys that do not have tags until it reaches one that does. Then the error occurs. Furthermore, if I manually remove the tagged key from my wallet file, this error does not occur.
Code:
Traceback (most recent call last):
  File "./electrum", line 364, in <module>
    addr += ':' + str(wallet.get_private_key_base58(addr, password))
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/electrum/wallet.py", line 375, in get_private_key_base58
    pk = self.get_private_key(address, password)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/electrum/wallet.py", line 386, in get_private_key
    secexp = int( b.encode('hex'), 16)
AttributeError: 'bool' object has no attribute 'encode'



2) When my wallet is encrypted, I experience the same problem as flatfly. I have done nothing nonstandard with my wallet file; I just imported a bunch of keys and tagged a few. (perhaps this is related to the above error?)


3) Additionally, I get this error when changing my password (which appears to work anyway, despite the error):
Code:
Traceback (most recent call last):
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/electrum/gui_qt.py", line 702, in <lambda>
    sb.addPermanentWidget( StatusBarButton( QIcon(":icons/lock.png"), "Password", lambda: self.change_password_dialog(self.wallet, self) ) )
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/electrum/gui_qt.py", line 941, in change_password_dialog
    wallet.update_password(seed, new_password)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/electrum/wallet.py", line 856, in update_password
    b = self.pw_decode(a, password)
NameError: global name 'password' is not defined



These last two are the important ones
4) When you "electrum -w <wallet> import <pub>:<priv>" followed by "electrum -w <wallet> deseed" then "electrum -w <wallet> addresses -k", <priv> is still displayed. I'm not sure if this is expected behavior, but at the very least there should be a caveat that offline wallets are currently incompatible with imported keys.


5) The secret keys of imported keys appear in plaintext in the wallet file when the wallet file is encrypted.


Thank you for the time you've put in creating this awesome software.
1481423500
Hero Member
*
Offline Offline

Posts: 1481423500

View Profile Personal Message (Offline)

Ignore
1481423500
Reply with quote  #2

1481423500
Report to moderator
1481423500
Hero Member
*
Offline Offline

Posts: 1481423500

View Profile Personal Message (Offline)

Ignore
1481423500
Reply with quote  #2

1481423500
Report to moderator
1481423500
Hero Member
*
Offline Offline

Posts: 1481423500

View Profile Personal Message (Offline)

Ignore
1481423500
Reply with quote  #2

1481423500
Report to moderator
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction. Advertise here.
1481423500
Hero Member
*
Offline Offline

Posts: 1481423500

View Profile Personal Message (Offline)

Ignore
1481423500
Reply with quote  #2

1481423500
Report to moderator
1481423500
Hero Member
*
Offline Offline

Posts: 1481423500

View Profile Personal Message (Offline)

Ignore
1481423500
Reply with quote  #2

1481423500
Report to moderator
1481423500
Hero Member
*
Offline Offline

Posts: 1481423500

View Profile Personal Message (Offline)

Ignore
1481423500
Reply with quote  #2

1481423500
Report to moderator
ThomasV
Legendary
*
Offline Offline

Activity: 1722



View Profile WWW
May 17, 2012, 06:00:48 AM
 #522

Hi! I have 5 bugs to report [...]

trying to reproduce those...
just to make sure: what is your OS, version of python and version of Electrum?

Electrum: the convenience of a web wallet, without the risks
duncant
Jr. Member
*
Offline Offline

Activity: 53


View Profile
May 17, 2012, 06:04:23 AM
 #523

Mac OS X 10.7.4, Python 2.7.3, The latest from gitorious (I did a git pull before reporting these bugs, just to make sure)
ThomasV
Legendary
*
Offline Offline

Activity: 1722



View Profile WWW
May 17, 2012, 06:07:37 AM
 #524

other question: did you use deseed/reseed? did you change your password?
before or after the import?

I am trying to reproduce it but no success so far

Electrum: the convenience of a web wallet, without the risks
ThomasV
Legendary
*
Offline Offline

Activity: 1722



View Profile WWW
May 17, 2012, 06:21:34 AM
 #525

ok, I found it.
things go wrong if you import keys and later change your password using the gui

Electrum: the convenience of a web wallet, without the risks
duncant
Jr. Member
*
Offline Offline

Activity: 53


View Profile
May 17, 2012, 06:25:38 AM
 #526

To reproduce (3):
encrypt wallet
import key
decrypt wallet/change password

To reproduce (1):
encrypt wallet
import key
tag imported key
decrypt wallet
"electrum -w <wallet> addresses -k"


I'm working on replicating the other bugs from scratch, I'll post again when I've done it.
duncant
Jr. Member
*
Offline Offline

Activity: 53


View Profile
May 17, 2012, 06:26:41 AM
 #527

....and I see you've already done that Tongue
duncant
Jr. Member
*
Offline Offline

Activity: 53


View Profile
May 17, 2012, 06:36:19 AM
 #528

Additional, minor bug:
"electrum -w <wallet> create" and "electrum -w <wallet> restore" prompts for a password to encrypt your wallet, but appears not to actually encrypt the wallet if the password is supplied.
ThomasV
Legendary
*
Offline Offline

Activity: 1722



View Profile WWW
May 17, 2012, 06:44:00 AM
 #529

I commited two fixes.
let me know if there are still problems.

Electrum: the convenience of a web wallet, without the risks
ThomasV
Legendary
*
Offline Offline

Activity: 1722



View Profile WWW
May 17, 2012, 06:49:58 AM
 #530

Additional, minor bug:
"electrum -w <wallet> create" and "electrum -w <wallet> restore" prompts for a password to encrypt your wallet, but appears not to actually encrypt the wallet if the password is supplied.

that too (third commit)

Electrum: the convenience of a web wallet, without the risks
flatfly
Hero Member
*****
Offline Offline

Activity: 938


View Profile
May 17, 2012, 07:34:18 AM
 #531

I commited two fixes.
let me know if there are still problems.


Thanks, things look good to me so far.

1111127SpvabYpoeDoiz5L7QPkfiSh2Q. Only donate if you have a reason to.
flatfly
Hero Member
*****
Offline Offline

Activity: 938


View Profile
May 17, 2012, 07:49:12 AM
 #532

A separate issue: the wallet restoration process often appears to stall at the very last address.

In those cases, I then have to close the 'restore' progress dialog manually, then the main window opens normally, but, synchronizing then takes a long time (minutes) - is it possible to show some kind of progress (in %, or blocks) in the status bar? Just so the user knows if the program is actually doing something or not.

1111127SpvabYpoeDoiz5L7QPkfiSh2Q. Only donate if you have a reason to.
ThomasV
Legendary
*
Offline Offline

Activity: 1722



View Profile WWW
May 17, 2012, 08:50:16 AM
 #533

A separate issue: the wallet restoration process often appears to stall at the very last address.

In those cases, I then have to close the 'restore' progress dialog manually, then the main window opens normally, but, synchronizing then takes a long time (minutes) -

the client has to find a gap with 5 empty addresses in order to know that it arrived at the 'last' address.

in addition, it downloads address statuses and histories separately.
if you have very long histories and a slow connection, it can take some extra time to request and download them.
this extra time will belong to the progress dialog unless you close it.

Quote
is it possible to show some kind of progress (in %, or blocks) in the status bar? Just so the user knows if the program is actually doing something or not.
there's no way to know in advance how much time is remaining, but the client could display kilobytes downloaded

Electrum: the convenience of a web wallet, without the risks
ThomasV
Legendary
*
Offline Offline

Activity: 1722



View Profile WWW
May 17, 2012, 09:00:27 AM
 #534

I released version 0.49b with the above fixes.

changelog:
* fix bug caused by interaction between imported keys and encryption

Electrum: the convenience of a web wallet, without the risks
flatfly
Hero Member
*****
Offline Offline

Activity: 938


View Profile
May 17, 2012, 10:38:57 AM
 #535

I released version 0.49b with the above fixes.

changelog:
* fix bug caused by interaction between imported keys and encryption


Great! My Win stand-alone build is now available too. (link in my signature)
SHA-1: 11ade02b8022efcefd2f908381a3e8edfa4faccb


1111127SpvabYpoeDoiz5L7QPkfiSh2Q. Only donate if you have a reason to.
flatfly
Hero Member
*****
Offline Offline

Activity: 938


View Profile
May 17, 2012, 10:42:56 AM
 #536


Quote
...
way to know in advance how much time is remaining, but the client could display kilobytes downloaded


Yes, this would be good as well - the little touches like that definitely help the end-user experience IMHO

1111127SpvabYpoeDoiz5L7QPkfiSh2Q. Only donate if you have a reason to.
ThomasV
Legendary
*
Offline Offline

Activity: 1722



View Profile WWW
May 17, 2012, 11:16:51 AM
 #537


Quote
...
way to know in advance how much time is remaining, but the client could display kilobytes downloaded


Yes, this would be good as well - the little touches like that definitely help the end-user experience IMHO

ok, I added it to the qt dialog. see version 0.49c.

Electrum: the convenience of a web wallet, without the risks
flatfly
Hero Member
*****
Offline Offline

Activity: 938


View Profile
May 17, 2012, 11:34:36 AM
 #538


Quote
...
way to know in advance how much time is remaining, but the client could display kilobytes downloaded


Yes, this would be good as well - the little touches like that definitely help the end-user experience IMHO

ok, I added it to the qt dialog

Thanks. I just tested it, and now I can see that when the process stalls
at the last address (115 for me) there is no more data received, and I have to
manually close the window. (First, I tried to wait for 3 minutes but nothing else
was happening)
 
For your info, I currently have about 250 entries/transactions in my history.

Screenshot:


1111127SpvabYpoeDoiz5L7QPkfiSh2Q. Only donate if you have a reason to.
ThomasV
Legendary
*
Offline Offline

Activity: 1722



View Profile WWW
May 17, 2012, 11:40:52 AM
 #539

Thanks. I just tested it, and now I can see that when the process stalls
at the last address (115 for me) there is no more data received, and I have to
manually close the window. (First, I tried to wait for 3 minutes but nothing else
was happening)
 
For your info, I currently have about 250 entries/transactions in my history.

ok, if it stalls then there might be another bug.
it could be related to the large size of your wallet;

right after you close the window, does the client display "synchronizing", or is it immediately ready?

Electrum: the convenience of a web wallet, without the risks
flatfly
Hero Member
*****
Offline Offline

Activity: 938


View Profile
May 17, 2012, 11:49:32 AM
 #540

Thanks. I just tested it, and now I can see that when the process stalls
at the last address (115 for me) there is no more data received, and I have to
manually close the window. (First, I tried to wait for 3 minutes but nothing else
was happening)
 
For your info, I currently have about 250 entries/transactions in my history.

ok, if it stalls then there might be another bug.
it could be related to the large size of your wallet;

right after you close the window, does the client display "synchronizing", or is it immediately ready?

It displays "synchronizing", but it seems that I do have to kill and restart it before it actually synchronizes.
My wallet file is approximately 500KB.

EDIT: I tried again, this time all went fine with no hiccups, and I found out that I actually have
152 addresses, not 115. So for some reason, it sometimes hangs at or around 115 for me.

1111127SpvabYpoeDoiz5L7QPkfiSh2Q. Only donate if you have a reason to.
Pages: « 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 [27] 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 ... 96 »
  Print  
 
Jump to:  

Sponsored by , a Bitcoin-accepting VPN.
Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!