[1500 TH] p2pool: Decentralized, DoS-resistant, Hop-Proof pool

[tubexc]

I don't see anyone with the majority of shares!
P2pool.org included!!!  

[1714130743]

1714130743

[1714130743]

1714130743

[1714130743]

1714130743

[davidadrake]

v17 is getting majority shares?

Yes
http://www.imageup.ru/img72/2719941/segwit.png

I don't get it, where is v17

[sawa]

Where is v17 to download? that address still points to v16

I don't get it, where is v17

https://bitcointalk.org/index.php?topic=18313.msg17990237#msg17990237

[pokapeski]

thanks, sawa.
why is this not in p2pool.in? I thought that was the official site.

[sawa]

thanks, sawa.
why is this not in p2pool.in? I thought that was the official site.

Probably because the owner of p2pool.in does not support SegWit.

Forrestv, can the fact that you did not include SegWit patches to the official repository be considered as an expression of your position?

[SixOfFive]

Where is v17 to download? that address still points to v16

I don't get it, where is v17

https://bitcointalk.org/index.php?topic=18313.msg17990237#msg17990237

2017-03-25 09:59:53.292243 p2pool (version 15.0-33-gf6a6ea0)

States version 15 on load ... does it switch to v17 when running? never bothered to bring it up that far as all variants I have found are 16 or pre-16

[sawa]

Where is v17 to download? that address still points to v16

I don't get it, where is v17

https://bitcointalk.org/index.php?topic=18313.msg17990237#msg17990237

2017-03-25 09:59:53.292243 p2pool (version 15.0-33-gf6a6ea0)

States version 15 on load ... does it switch to v17 when running? never bothered to bring it up that far as all variants I have found are 16 or pre-16

"Node p2pool version" and "Protocol version" is not the same thing.
You have "version 15.0-33-gf6a6ea0", and it's a "Node p2pool version".
"Protocol version" must be 1700.

Here https://bitcointalk.org/index.php?topic=18313.msg17990237#msg17990237 is the instruction for those who already had a working p2pool installed from https://github.com/p2pool/p2pool.git

[windpath]

thanks, sawa.
why is this not in p2pool.in? I thought that was the official site.

Probably because the owner of p2pool.in does not support SegWit.

Forrestv, can the fact that you did not include SegWit patches to the official repository be considered as an expression of your position?

This is a gross mis-characterization. Forrest is not active in the bitcoin world any longer and I doubt he has an opinion either way. A patch has been written and the pull request is pending, but AFAIK no one has tested it. In the conversation on github Forrest asked when it would activate, however that is still a question that remains unanswered.

If SegWit is ready to activate I'm sure the code will be merged (after it's reviewed/tested), otherwise I would not expect a response from Forrest here.

Edit: as a side note p2pool nodes can signal for whatever client they prefer.

[forrestv]

Hi all. As windpath said, I'm not very active with Bitcoin recently. However, I will continue to merge/develop, test, and release changes necessary to keep P2Pool working with any Bitcoin hardforks.

There's an issue tracking SegWit support in P2Pool here which references veqtrus's awesome work adding SegWit support.

I don't plan to merge/test/release that until it looks like SegWit activation is actually happening, which according to http://segwit.co/, won't be in the near future.


As a separate issue, I now realize that current P2Pool doesn't allow *expressing* support for SegWit, due to line 372 in work.py, which veqtrus's changes don't touch:

Code:

version=max(self.current_work.value['version'], 0x20000000),

If anyone can confirm that fixing that is as simple as changing it to

Code:

version=max(self.current_work.value['version'], 0x20000002),

, then I will publish a new P2Pool release with that change.

[windpath]

... However, I will continue to merge/develop, test, and release changes necessary to keep P2Pool working with any Bitcoin hardforks.

Many thanks Forrest! You're continued work on p2pool is very much appreciated.

[sawa]

Forrestv, can the fact that you did not include SegWit patches to the official repository be considered as an expression of your position?

This is a gross mis-characterization.

Do not over exaggerate please, it was a question and not a characteristic of Forrest.

[windpath]

Probably because the owner of p2pool.in does not support SegWit.

This is not a question, it's an inflammatory statement in line with the current community drama. I can't speak for Forrest or any other p2pool miner, but I'm 100% sure that this debates arena is not here, the only decentralized mining pools thread.

P2Pool by its nature is implementation agnostic, and while I have my own opinions, they will remain as such in the p2pool context because we are literary designed to give the p2pool miner their own node, and vote, whatever that preference may be.

[sawa]

Forrest, thank you very much for your support of our community.

As a separate issue, I now realize that current P2Pool doesn't allow *expressing* support for SegWit

Exactly.

[veqtrus]

As a separate issue, I now realize that current P2Pool doesn't allow *expressing* support for SegWit, due to line 372 in work.py, which veqtrus's changes don't touch:

Code:

version=max(self.current_work.value['version'], 0x20000000),

If anyone can confirm that fixing that is as simple as changing it to

Code:

version=max(self.current_work.value['version'], 0x20000002),

This is wrong. I changed p2pool to signal whatever BIP9 compatible fork a client supports in the CSV commit.

[sawa]

As a separate issue, I now realize that current P2Pool doesn't allow *expressing* support for SegWit, due to line 372 in work.py, which veqtrus's changes don't touch:

Code:

version=max(self.current_work.value['version'], 0x20000000),

If anyone can confirm that fixing that is as simple as changing it to

Code:

version=max(self.current_work.value['version'], 0x20000002),

, then I will publish a new P2Pool release with that change.

This is wrong. I changed p2pool to signal whatever BIP9 compatible fork a client supports in the CSV commit.

How to get out of this situation? Now for my node I use veqtrus patches from the segwit1+empty_block_fix1 branch of a https://github.com/veqtrus/p2pool.git repository.
When my node's  hashrate was raised and the amount of v17 shares was increased above then 50%, the message with a link to  p2pool.in appeared on another nodes. But there is no announcement about a new version. Owners of other nodes will not do anything.
What to do if the main developers can not agree?

[windpath]

...But there is no announcement about a new version...

Because there is no new version, you are running a fork.

The current version at https://github.com/p2pool/p2pool allows BIP9 signaling thanks to veqtrus's work. Please leave the politics elsewhere.

[veqtrus]

Windpath is correct. There is no rush in activating segwit in p2pool as we are far from activation on the bitcoin network. Plus more independent testing would be desirable...

[sawa]

Windpath is correct. There is no rush in activating segwit in p2pool as we are far from activation on the bitcoin network. Plus more independent testing would be desirable...

Thank you. I understood.

[forrestv]

As a separate issue, I now realize that current P2Pool doesn't allow *expressing* support for SegWit, due to line 372 in work.py, which veqtrus's changes don't touch:

Code:

version=max(self.current_work.value['version'], 0x20000000),

If anyone can confirm that fixing that is as simple as changing it to

Code:

version=max(self.current_work.value['version'], 0x20000002),

This is wrong. I changed p2pool to signal whatever BIP9 compatible fork a client supports in the CSV commit.

Ah, oops. I misread max as what it used to be (min). Great, so that's not a problem.

How to get out of this situation? Now for my node I use veqtrus patches from the segwit1+empty_block_fix1 branch of a https://github.com/veqtrus/p2pool.git repository.
When my node's  hashrate was raised and the amount of v17 shares was increased above then 50%, the message with a link to  p2pool.in appeared on another nodes. But there is no announcement about a new version. Owners of other nodes will not do anything.
What to do if the main developers can not agree?

sawa, you shouldn't be using the fork right now. The main branch does everything you could want right now (namely, just indicate SegWit support). A majority of P2Pool hashrate using a fork will indeed confuse other miners.

[sawa]

sawa, you shouldn't be using the fork right now. The main branch does everything you could want right now (namely, just indicate SegWit support). A majority of P2Pool hashrate using a fork will indeed confuse other miners.

That's what I wanted to find out. I returned to the official source code.
Thank you.