numismatist
Legendary
Offline
Activity: 1245
Merit: 1004
|
|
February 09, 2015, 02:55:48 PM |
|
Ultimately we aren't preventing anyone from writing an additional implementation and submitting a PR, and we will at the very least have a BerkleyDB fall-back implementation for environments that don't play well with large MMAPs.
Hmm... BerkleyDB is a typo? Bitcoin itself had migrated from BerkleyDB to LevelDB... Meanwhiles, on http://coinmarketcap.com/currencies/views/filter-non-mineable-and-premined/ MonaCoin gets ready to buypass Monero, just mentioning. Rises 9.20 % whereas Monero does -7.17 %
|
|
|
|
fluffypony
Donator
Legendary
Offline
Activity: 1274
Merit: 1060
GetMonero.org / MyMonero.com
|
|
February 09, 2015, 02:58:39 PM |
|
get_bulk_payments(json_encode(array('min_block_height'=>399206))); When can we expect this function to work with only min_block_height parameter in the pre-built libraries? That's not really on our radar; get_bulk_payments is for scanning payment IDs you already know. A general scan of the wallet would be using the incoming_transfers call. get_bulk_payments does give information like block height/payment id for the incoming tx (which you want to know if you want to wait for N confirmations before crediting), and has a min_block_height which hte other doesn't. So using incoming_transfers would need one such call plus a call per new incoming tx to get that other data. What I mean is that we won't be providing a get_bulk_payments call that doesn't take a list of payment IDs (at this stage). We are designing a successor to the payment ID protocol, but typically speaking you will still need to know what you're scanning for (whether it is a payment ID "generated" by the recipient or one given to the recipient by the sender).
|
|
|
|
GingerAle
Legendary
Offline
Activity: 1260
Merit: 1008
|
|
February 09, 2015, 05:19:22 PM |
|
Ultimately we aren't preventing anyone from writing an additional implementation and submitting a PR, and we will at the very least have a BerkleyDB fall-back implementation for environments that don't play well with large MMAPs.
Hmm... BerkleyDB is a typo? Bitcoin itself had migrated from BerkleyDB to LevelDB... Meanwhiles, on http://coinmarketcap.com/currencies/views/filter-non-mineable-and-premined/ MonaCoin gets ready to buypass Monero, just mentioning. Rises 9.20 % whereas Monero does -7.17 % https://www.allcoin.com/trade/MONA_BTCp.n.d.
|
|
|
|
David Latapie
|
|
February 09, 2015, 06:01:15 PM Last edit: February 09, 2015, 06:32:54 PM by David Latapie |
|
I see one use of multiple addresses: when you don't want to know that two transactions go to the same address (like if you don't want people to find you by googling your address which is on bitcointalk signature of profile, or openalias, for instance). But since there is no much of these needs, you may as well just use a second wallet.
It doesn't matter if your address is known, as it's impossible (with our current cryptography) to analyse the blockchain and find transactions you were involved in. Even if that was possible it still wouldn't be disastrous, as all that can be observed are transactions you *may or may not* have been involved in (thanks to ring signatures). The only time multiple wallets are necessary are for separating your personal and business accounts, for instance, or for a company that wants each department to have its own address and accounts. I was more thinking about the same address being a signature on weloveteddybears.com and gunenthusiast.com.
Pippo, to decide about Monero: 1. Follow this link: https://xmrmonero.com/faq/en/monero-matters2. Follow all the links (some are just one post to read,not the whole thread) If you are interested in the vision and the philosophy of the dev team, I recommand you "Three Pillars of Monero" if you want to know about the vision and spirit If you are more interested in "Monero vs Darkcoin", read my comment on "Darkcoin, Anoncoin, Shadowcash, Monero" You should have a good summary. We are working on creating a more consolidated document.
|
|
|
|
smooth
Legendary
Offline
Activity: 2968
Merit: 1198
|
|
February 09, 2015, 08:46:59 PM |
|
I was more thinking about the same address being a signature on weloveteddybears.com and gunenthusiast.com.
It would certainly be a good idea for those to use different addresses, except perhaps in the case where they are both using third party payment processor, in which case sharing an address (with each other but also with many other businesses using the same payment processor) wouldn't mean anything at all.
|
|
|
|
TheKoziTwo
Legendary
Offline
Activity: 1552
Merit: 1047
|
|
February 09, 2015, 08:53:58 PM |
|
get_bulk_payments(json_encode(array('min_block_height'=>399206))); When can we expect this function to work with only min_block_height parameter in the pre-built libraries? That's not really on our radar; get_bulk_payments is for scanning payment IDs you already know. A general scan of the wallet would be using the incoming_transfers call. I would like to make the application scalable, what is the best practice currently? Getting transactions with incoming_transfers is fine, except the returned result will grow too large at some point? I guess with the parameter transfer_type "available" it won't be all that bad since most funds will be transferred elsewhere, but doesn't feel right to me. Also, is there any function to retrieve a payment_id with tx hash? without that this won't work anyways. Polling get_bulk_payments with payment id's is fine too, except it will also grow too large at some point? As in, one may end up having to poll millions of payment ids. You could add the height parameter, but still, it just doesn't feel right having to run this through all payment_ids just to check for new transactions. I'm thinking a simple get tx's/payment id's > height = new transactions for script to process. Currently is seems to me I'll have to: 1. Record last checked height next to all payment ids in database. 2. Cron job traverse through all payment ids in database continuously checking for new tx's while also updating height I must be missing something
|
|
|
|
smooth
Legendary
Offline
Activity: 2968
Merit: 1198
|
|
February 09, 2015, 08:56:46 PM |
|
get_bulk_payments(json_encode(array('min_block_height'=>399206))); When can we expect this function to work with only min_block_height parameter in the pre-built libraries? That's not really on our radar; get_bulk_payments is for scanning payment IDs you already know. A general scan of the wallet would be using the incoming_transfers call. I would like to make the application scalable, what is the best practice currently? Getting transactions with incoming_transfers is fine, except the returned result will grow too large at some point? Maybe add an optional minimum height to incoming_transfers?
|
|
|
|
TheKoziTwo
Legendary
Offline
Activity: 1552
Merit: 1047
|
|
February 09, 2015, 09:00:49 PM |
|
get_bulk_payments(json_encode(array('min_block_height'=>399206))); When can we expect this function to work with only min_block_height parameter in the pre-built libraries? That's not really on our radar; get_bulk_payments is for scanning payment IDs you already know. A general scan of the wallet would be using the incoming_transfers call. I would like to make the application scalable, what is the best practice currently? Getting transactions with incoming_transfers is fine, except the returned result will grow too large at some point? Maybe add an optional minimum height to incoming_transfers? There is no such param atm afaik? Also that still leaves the other question, what function to get payment id from tx_id
|
|
|
|
smooth
Legendary
Offline
Activity: 2968
Merit: 1198
|
|
February 09, 2015, 09:08:32 PM |
|
get_bulk_payments(json_encode(array('min_block_height'=>399206))); When can we expect this function to work with only min_block_height parameter in the pre-built libraries? That's not really on our radar; get_bulk_payments is for scanning payment IDs you already know. A general scan of the wallet would be using the incoming_transfers call. I would like to make the application scalable, what is the best practice currently? Getting transactions with incoming_transfers is fine, except the returned result will grow too large at some point? Maybe add an optional minimum height to incoming_transfers? There is no such param atm afaik? Yes, that's why I proposed adding one. Also that still leaves the other question, what function to get payment id from tx_id There doesn't seem to be one right now. You can get the tx in raw hex but you would have to decode it. BTW, as far as I can tell from the code, if you do get_bulk_payments with an empty payment ID list you get all payments.
|
|
|
|
|
TheKoziTwo
Legendary
Offline
Activity: 1552
Merit: 1047
|
|
February 09, 2015, 11:29:27 PM |
|
get_bulk_payments(json_encode(array('min_block_height'=>399206))); When can we expect this function to work with only min_block_height parameter in the pre-built libraries? That's not really on our radar; get_bulk_payments is for scanning payment IDs you already know. A general scan of the wallet would be using the incoming_transfers call. I would like to make the application scalable, what is the best practice currently? Getting transactions with incoming_transfers is fine, except the returned result will grow too large at some point? Maybe add an optional minimum height to incoming_transfers? There is no such param atm afaik? Yes, that's why I proposed adding one. I would prefer to have minimum height implemented in get_bulk_payments so that you do not have to enter payment id's. Also that still leaves the other question, what function to get payment id from tx_id There doesn't seem to be one right now. You can get the tx in raw hex but you would have to decode it. BTW, as far as I can tell from the code, if you do get_bulk_payments with an empty payment ID list you get all payments. I thought so at first too, but it doesn't work, I have to specify payment id's otherwise nothing is returned... Code: $r = $wallet->get_bulk_payments(json_encode(array('payment_ids'=>array()))); var_dump($r);
$r = $wallet->get_bulk_payments(json_encode(array('min_block_height'=>399206))); var_dump($r);
$r = $wallet->get_bulk_payments(json_encode(array('payment_ids'=>array(),'min_block_height'=>399206))); var_dump($r);
$r = $wallet->get_bulk_payments(json_encode(array('payment_ids'=>null))); var_dump($r);
$r = $wallet->get_bulk_payments(json_encode(array('payment_ids'=>null,'min_block_height'=>399206))); var_dump($r);
Result: array (size=0) empty
array (size=0) empty
array (size=0) empty
array (size=0) empty
array (size=0) empty
|
|
|
|
smooth
Legendary
Offline
Activity: 2968
Merit: 1198
|
|
February 10, 2015, 12:05:49 AM |
|
I thought so at first too, but it doesn't work, I have to specify payment id's otherwise nothing is returned...
Try rebuilding the wallet
|
|
|
|
TheKoziTwo
Legendary
Offline
Activity: 1552
Merit: 1047
|
|
February 10, 2015, 12:45:38 AM |
|
I thought so at first too, but it doesn't work, I have to specify payment id's otherwise nothing is returned...
Try rebuilding the wallet I don't have any build environment atm so I'm just using the pre-built binaries for this, as I stated previously the idea is that once finished, the public can download the complete integration and pre-built binaries and quickly integrate with their own service. Instead of everyone trying to figure it out by themselves. I am not interested in using any functions not available in the pre-built binaries. Fluffypony said it's not going to be added. But if it's already added, all I'm asking is for a release date and I'll finish it of later, I'm in no hurry. This is the code isn't it? /* If the payment ID list is empty, we get payments to any payment ID (or lack thereof) */ if (req.payment_ids.empty()) { std::list<std::pair<crypto::hash,wallet2::payment_details>> payment_list; m_wallet.get_payments(payment_list, req.min_block_height); for (auto & payment : payment_list) { wallet_rpc::payment_details rpc_payment; rpc_payment.payment_id = epee::string_tools::pod_to_hex(payment.first); rpc_payment.tx_hash = epee::string_tools::pod_to_hex(payment.second.m_tx_hash); rpc_payment.amount = payment.second.m_amount; rpc_payment.block_height = payment.second.m_block_height; rpc_payment.unlock_time = payment.second.m_unlock_time; res.payments.push_back(std::move(rpc_payment)); } return true; } That's why I asked, because I thought this code was doing what I asked for (just not in the binaries yet), but fluffy said no: get_bulk_payments(json_encode(array('min_block_height'=>399206))); When can we expect this function to work with only min_block_height parameter in the pre-built libraries? That's not really on our radar; get_bulk_payments is for scanning payment IDs you already know. A general scan of the wallet would be using the incoming_transfers call.
|
|
|
|
smooth
Legendary
Offline
Activity: 2968
Merit: 1198
|
|
February 10, 2015, 12:51:34 AM |
|
I thought so at first too, but it doesn't work, I have to specify payment id's otherwise nothing is returned...
Try rebuilding the wallet I don't have any build environment atm so I'm just using the pre-built binaries for this, as I stated previously the idea is that once finished, the public can download the complete integration and pre-built binaries and quickly integrate with their own service. Instead of everyone trying to figure it out by themselves. I am not interested in using any functions not available in the pre-built binaries. Fluffypony said it's not going to be added. But if it's already added, all I'm asking is for a release date and I'll finish it of later, I'm in no hurry. Fluffypony misunderstood either your inquiry or what had been added to the code, I'm not sure which. When I said "rebuilding the wallet" I meant delete the wallet.bin file. (But this assume you are using the code that has support for the empty-list payment ID request.) The list of payments is stored in the wallet.bin file and doesn't include payments without an ID if they were received and processed using the old code. As far as a release date for the next official build of the code, I don't know. Maybe you can get a trusted person to create a custom build for you?
|
|
|
|
TheKoziTwo
Legendary
Offline
Activity: 1552
Merit: 1047
|
|
February 10, 2015, 01:13:16 AM |
|
I thought so at first too, but it doesn't work, I have to specify payment id's otherwise nothing is returned...
Try rebuilding the wallet I don't have any build environment atm so I'm just using the pre-built binaries for this, as I stated previously the idea is that once finished, the public can download the complete integration and pre-built binaries and quickly integrate with their own service. Instead of everyone trying to figure it out by themselves. I am not interested in using any functions not available in the pre-built binaries. Fluffypony said it's not going to be added. But if it's already added, all I'm asking is for a release date and I'll finish it of later, I'm in no hurry. Fluffypony misunderstood either your inquiry or what had been added to the code, I'm not sure which. When I said "rebuilding the wallet" I meant delete the wallet.bin file. (But this assume you are using the code that has support for the empty-list payment ID request.) The list of payments is stored in the wallet.bin file and doesn't include payments without an ID if they were received and processed using the old code. As far as a release date for the next official build of the code, I don't know. Maybe you can get a trusted person to create a custom build for you? Right, I just tried rebuilding the wallet, doesn't work. I'm running version 0.8.8.6. No worries, I'm just going to wait until the new release is out. But it would be great if fluffy could confirm this, because if it turns out this code will not be added, I will just go ahead with the proposed solution even though it's not optimal.
|
|
|
|
|
TheKoziTwo
Legendary
Offline
Activity: 1552
Merit: 1047
|
|
February 10, 2015, 01:29:03 AM |
|
Ok cool, I'll wait for the new version to be released and continue development then.
|
|
|
|
GingerAle
Legendary
Offline
Activity: 1260
Merit: 1008
|
|
February 10, 2015, 04:23:04 AM |
|
Unofficial Monday Moneroworld Digest Prettiest Backup I got tired of everyone wanting a monday missive. So I made one. Because thats what we do in moneroworld.
|
|
|
|
smooth
Legendary
Offline
Activity: 2968
Merit: 1198
|
|
February 10, 2015, 05:37:15 AM |
|
So I made one. Because thats what we do in moneroworld.
Bravo
|
|
|
|
Hueristic
Legendary
Offline
Activity: 3948
Merit: 5362
Doomed to see the future and unable to prevent it
|
|
February 10, 2015, 05:37:57 AM |
|
Unofficial Monday Moneroworld Digest Prettiest Backup I got tired of everyone wanting a monday missive. So I made one. Because thats what we do in moneroworld. What a great synopsis!
|
“Bad men need nothing more to compass their ends, than that good men should look on and do nothing.”
|
|
|
|