sidhujag
Legendary
Offline
Activity: 2044
Merit: 1005
|
|
December 25, 2013, 07:41:13 AM |
|
.. GetMinFee is updated I assume we dont want to allow free transactions so its similar to the link but different than the old source.
Indeed free transactions must be blocked to stop dust spam. Does your client load up to the latest block even though the old source might of allowed some free transactions into the block chain? Getworkaux (merge mining) wasnt changed but i couldnt test it my merge mine proxy wouldnt connect to a cpu miner so i mined locally on my daemon using setgenerate true instead and it wokred.. merge minimg will have to be tested.
I'll add a 12 share bounty for the first person to merge mine a block with your code, then 6 shares bounty for the second person. Well what was happening was For transactions under 27k coins it would fall into allowfree since its always true and set fee to 0.. however there is am involuntary dust fee added which adds a small fee regardles of allowfree basefee \ 10 where basefee is 5 coins.. so 0.5 dvc. So now fees for under 27k coins should be a little higher.The rest are same. Even on the old code there was always a fee so no free tx got in even before. I see the sync complete to the latest block index from block explorer.
|
|
|
|
sidhujag
Legendary
Offline
Activity: 2044
Merit: 1005
|
|
December 25, 2013, 07:43:52 AM |
|
And is that how bitcoin checks that same thing?
I understood that the new I0COin, on which this is based, was in turn based on new bitcoin?
-MarkM-
I coulsnt find many examples going from a pub script to a hash160.. I had to look up where hash160() was used to see what i had available... The keyid converts script address to hash160 by doing the strip.. I dont think the reciever stuff would have worked if it gave wrong address in the txout
|
|
|
|
markm
Legendary
Offline
Activity: 2982
Merit: 1113
|
|
December 25, 2013, 07:53:44 AM |
|
When bitcoin changed its fees way back when, was that a "when a certain block is reached, these new different free go into effect" change?
Or is it actually okay to arbitrarily change the fee calculations without having such a spot on the chain at which the change comes into effect?
-MarkM-
|
|
|
|
Wekkel
Legendary
Offline
Activity: 3108
Merit: 1531
yes
|
|
December 25, 2013, 07:56:59 AM |
|
I managed to install Github on Windows and get the .jar file. Upon install, I get an error, even if I make the 'Devcoin' folder manually.
[...]
Are you running as admin looks like it doesnt have priviledge? Try to install to say c:/mydvcwallet or something. I run Windows as regular user. Apparently, the java installer indeed has trouble passing the standard security measures. Installed in Desktop folder instead and moved everything to the regular program files folder. It workes fine and found my exiting wallet. For the record: windows 8.1 pro 64 bit, client v0.8.5.1-g25a7d46-beta. If someone wants to test payments again: 18GCTJhxrWfXjnLwwjJKsSYBpyEV16pRs (please mention return address in this thread). Please note that payments will eat 0.5 DVC so I wont be able to return 100% of the amount received.
|
|
|
|
Unthinkingbit
|
|
December 25, 2013, 07:57:08 AM |
|
.. Well what was happening was For transactions under 27k coins it would fall into allowfree since its always true and set fee to 0.. however there is am involuntary dust fee added which adds a small fee regardles of allowfree basefee \ 10 where basefee is 5 coins.. so 0.5 dvc.
So now fees for under 27k coins should be a little higher.The rest are same.
Even on the old code there was always a fee so no free tx got in even before. I see the sync complete to the latest block index from block explorer.
That's good news. Also, bitcoin 0.8.x now also stops dust: CTxOut::IsDust() I still want to keep the devcoin dust stopping code, because bitcoin has different fees.
|
|
|
|
sidhujag
Legendary
Offline
Activity: 2044
Merit: 1005
|
|
December 25, 2013, 08:08:32 AM |
|
.. Well what was happening was For transactions under 27k coins it would fall into allowfree since its always true and set fee to 0.. however there is am involuntary dust fee added which adds a small fee regardles of allowfree basefee \ 10 where basefee is 5 coins.. so 0.5 dvc.
So now fees for under 27k coins should be a little higher.The rest are same.
Even on the old code there was always a fee so no free tx got in even before. I see the sync complete to the latest block index from block explorer.
That's good news. Also, bitcoin 0.8.x now also stops dust: CTxOut::IsDust() I still want to keep the devcoin dust stopping code, because bitcoin has different fees. Yea looks like it checks before send and adds dust to fee.
|
|
|
|
markm
Legendary
Offline
Activity: 2982
Merit: 1113
|
|
December 25, 2013, 08:22:51 AM |
|
Wouldn't it be simpler, and more supportable going forward, to simply use bitcoin's fee code with the numbers such as how many satoshis consititutes dust all multiplied by 1000 ? Isn't that what we did originally? Or did we put in anti dust before bitcoin did?
(Even if we did though, using bitcoin's code might be easier to keep up with new bitcoin code versions going forward?)
-MarkM-
|
|
|
|
sidhujag
Legendary
Offline
Activity: 2044
Merit: 1005
|
|
December 25, 2013, 08:32:56 AM |
|
Wouldn't it be simpler, and more supportable going forward, to simply use bitcoin's fee code with the numbers such as how many satoshis consititutes dust all multiplied by 1000 ? Isn't that what we did originally? Or did we put in anti dust before bitcoin did?
(Even if we did though, using bitcoin's code might be easier to keep up with new bitcoin code versions going forward?)
-MarkM-
I agree but I think fee changed in latest.. Also going fwd they doing something with more dynamic fee structure?? not sure if its worth it for us right now.
|
|
|
|
weisoq
|
|
December 25, 2013, 10:13:31 AM |
|
I run Windows as regular user. Apparently, the java installer indeed has trouble passing the standard security measures.
Installed in Desktop folder instead and moved everything to the regular program files folder. It workes fine and found my exiting wallet. For the record: windows 8.1 pro 64 bit, client v0.8.5.1-g25a7d46-beta.
If someone wants to test payments again: 18GCTJhxrWfXjnLwwjJKsSYBpyEV16pRs (please mention return address in this thread).
Please note that payments will eat 0.5 DVC so I wont be able to return 100% of the amount received.
Done (you missed a 'B' off the end). Same again.
|
|
|
|
Wekkel
Legendary
Offline
Activity: 3108
Merit: 1531
yes
|
|
December 25, 2013, 12:16:09 PM Last edit: December 25, 2013, 12:56:00 PM by Wekkel |
|
The payment fees seem to have changed? A payment apparently no longer requires only 0.5 DVC but between 5.5 to 6 DVC as a minimum? See screenshots below. Weisoq, I have hold off from sending back for now until this is clear. Happy to fill it up to 10 again if - indeed - I need to burn 6 DVC to get 4 DVC back to you (once I reach my cold storage wallet).
|
|
|
|
sidhujag
Legendary
Offline
Activity: 2044
Merit: 1005
|
|
December 25, 2013, 03:43:01 PM |
|
Im going to uncomment allow free code looks like it uncovered a bug. I will leave it like it is.. The mintxfee is set to 5*COIN.. This is what it was in devcoin src..
Now the min fee ends up being 5*coin plus dust filter 0.5*coin.. give me few hrs I will update it back to what it was.
|
|
|
|
Wekkel
Legendary
Offline
Activity: 3108
Merit: 1531
yes
|
|
December 25, 2013, 04:03:15 PM |
|
No, take your time and relax. Fixing this can wait.
|
|
|
|
sidhujag
Legendary
Offline
Activity: 2044
Merit: 1005
|
|
December 25, 2013, 06:48:12 PM |
|
No, take your time and relax. Fixing this can wait.
Done, uplaoded v1.0.4... we should test with greater than 27k coin transactions aswell. Please see if this one works as expected.
|
|
|
|
Wekkel
Legendary
Offline
Activity: 3108
Merit: 1531
yes
|
|
December 25, 2013, 09:49:10 PM |
|
Updated the client to 1.0.4. Managed to make a payment but still a 6 DVC payment fee (not that this is much though....).
|
|
|
|
ranlo
Legendary
Offline
Activity: 1988
Merit: 1007
|
|
December 25, 2013, 10:18:20 PM |
|
Updated the client to 1.0.4. Managed to make a payment but still a 6 DVC payment fee (not that this is much though....). Can we please see your incoming transactions? Or at least the # of them? The message you see insinuates it is using 80+ transactions to build your outgoing one.
|
|
|
|
Wekkel
Legendary
Offline
Activity: 3108
Merit: 1531
yes
|
|
December 25, 2013, 10:56:24 PM |
|
|
|
|
|
sidhujag
Legendary
Offline
Activity: 2044
Merit: 1005
|
|
December 25, 2013, 11:27:45 PM |
|
I managed to install Github on Windows and get the .jar file. Upon install, I get an error, even if I make the 'Devcoin' folder manually.
[...]
Are you running as admin looks like it doesnt have priviledge? Try to install to say c:/mydvcwallet or something. I run Windows as regular user. Apparently, the java installer indeed has trouble passing the standard security measures. Installed in Desktop folder instead and moved everything to the regular program files folder. It workes fine and found my exiting wallet. For the record: windows 8.1 pro 64 bit, client v0.8.5.1-g25a7d46-beta. If someone wants to test payments again: 18GCTJhxrWfXjnLwwjJKsSYBpyEV16pRs (please mention return address in this thread). Please note that payments will eat 0.5 DVC so I wont be able to return 100% of the amount received. Did you get the windows shortcut installer and uninstaller in the start programs as well? Maybe I can make the default directory c:\Devcoin?
|
|
|
|
sidhujag
Legendary
Offline
Activity: 2044
Merit: 1005
|
|
December 25, 2013, 11:40:26 PM |
|
Maybe I didn't re build properly after main.cpp changed... assumed incremental linker would work. Let me upload next version... it should be just 0.5 fee .. btw guys let me know how many dvc your burning, I will refund you if you lose any. Also if it works, can you doa test of 30k coins? 50k coin? Again I will refund you any fees or lost coins.
|
|
|
|
notabot
Member
Offline
Activity: 99
Merit: 10
|
|
December 25, 2013, 11:52:41 PM |
|
I've had the large transaction fee with the older client - it occurs sometimes when sending a smaller amount
|
|
|
|
sidhujag
Legendary
Offline
Activity: 2044
Merit: 1005
|
|
December 26, 2013, 12:06:14 AM |
|
Ok ive uploaded 1.0.5, and I created a zip file with just the QT in it aswell incase the installer isn't updating the qt with the new version I made. You shouldn't get that message before sending... it should be 0.5dvc like the older versions with the allowfree commented out.. i think v1.0.2 and below. The zip and installer are in the same directory.
|
|
|
|
|