Bitcoin Forum
December 10, 2019, 10:58:02 PM *
News: Latest Bitcoin Core release: 0.19.0.1 [Torrent]
 
   Home   Help Search Login Register More  
Pages: « 1 ... 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 [151] 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 ... 412 »
  Print  
Author Topic: [DVC]DevCoin - Official Thread - Moderated  (Read 959259 times)
This is a self-moderated topic. If you do not want to be moderated by the person who started this topic, create a new topic.
markm
Legendary
*
Offline Offline

Activity: 2464
Merit: 1032



View Profile WWW
December 25, 2013, 06:58:33 AM
 #3001

The createblock had to change because the AddressTo160 doesnt exist in the new bitcoin src. But I suspect blocks wouldnt download if I didnt port it correctly.

What does bitcoin use instead? Presumably bitcoin still needs to validate its old blocks that did use 160 bit whatzits?

-MarkM-

Browser-launched Crossfire client now online (select CrossCiv server for Galactic  Milieu)
Free website hosting with PHP, MySQL etc: http://hosting.knotwork.com/
1576018682
Hero Member
*
Offline Offline

Posts: 1576018682

View Profile Personal Message (Offline)

Ignore
1576018682
Reply with quote  #2

1576018682
Report to moderator
1576018682
Hero Member
*
Offline Offline

Posts: 1576018682

View Profile Personal Message (Offline)

Ignore
1576018682
Reply with quote  #2

1576018682
Report to moderator
1576018682
Hero Member
*
Offline Offline

Posts: 1576018682

View Profile Personal Message (Offline)

Ignore
1576018682
Reply with quote  #2

1576018682
Report to moderator
PLAY NOW
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction. Advertise here.
1576018682
Hero Member
*
Offline Offline

Posts: 1576018682

View Profile Personal Message (Offline)

Ignore
1576018682
Reply with quote  #2

1576018682
Report to moderator
1576018682
Hero Member
*
Offline Offline

Posts: 1576018682

View Profile Personal Message (Offline)

Ignore
1576018682
Reply with quote  #2

1576018682
Report to moderator
1576018682
Hero Member
*
Offline Offline

Posts: 1576018682

View Profile Personal Message (Offline)

Ignore
1576018682
Reply with quote  #2

1576018682
Report to moderator
Unthinkingbit
Hero Member
*****
Offline Offline

Activity: 935
Merit: 1008



View Profile
December 25, 2013, 07:13:18 AM
 #3002

..
GetMinFee is updated I assume we dont want to allow free transactions so its similar to the link but different than the old source.

Indeed free transactions must be blocked to stop dust spam. Does your client load up to the latest block even though the old source might of allowed some free transactions into the block chain?

Quote
Getworkaux (merge mining) wasnt changed but i couldnt test it my merge mine proxy wouldnt connect to a cpu miner so i mined locally on my daemon using setgenerate true instead and it wokred.. merge minimg will have to be tested.

I'll add a 12 share bounty for the first person to merge mine a block with your code, then 6 shares bounty for the second person.

sidhujag
Legendary
*
Offline Offline

Activity: 2044
Merit: 1004


View Profile
December 25, 2013, 07:31:05 AM
 #3003

The createblock had to change because the AddressTo160 doesnt exist in the new bitcoin src. But I suspect blocks wouldnt download if I didnt port it correctly.

What does bitcoin use instead? Presumably bitcoin still needs to validate its old blocks that did use 160 bit whatzits?

-MarkM-


So here https://github.com/sidhujag/devcoin/blob/master/src/main.cpp

In connectblock it was checking address validity by seeing if hash160
was non zero but there were two new classes I used to check validity and get the address to store in the coinlist structure. CxDestination allow you to extract address destination using ExtractDestination passing in the script public key.. Then i pass the destination into
a new CBitcoinAddress which has a isvalid and then a tostring()...

In createnewblock (near end) Im doing an additional validity check and then using  CKeyID to
call GetID() on the CBitcoinAddress which returns the hash160 of the public address. So its just using these other functions to do same thing
markm
Legendary
*
Offline Offline

Activity: 2464
Merit: 1032



View Profile WWW
December 25, 2013, 07:33:14 AM
 #3004

And is that how bitcoin checks that same thing?

I understood that the new I0COin, on which this is based, was in turn based on new bitcoin?

-MarkM-

Browser-launched Crossfire client now online (select CrossCiv server for Galactic  Milieu)
Free website hosting with PHP, MySQL etc: http://hosting.knotwork.com/
sidhujag
Legendary
*
Offline Offline

Activity: 2044
Merit: 1004


View Profile
December 25, 2013, 07:41:13 AM
 #3005

..
GetMinFee is updated I assume we dont want to allow free transactions so its similar to the link but different than the old source.

Indeed free transactions must be blocked to stop dust spam. Does your client load up to the latest block even though the old source might of allowed some free transactions into the block chain?

Quote
Getworkaux (merge mining) wasnt changed but i couldnt test it my merge mine proxy wouldnt connect to a cpu miner so i mined locally on my daemon using setgenerate true instead and it wokred.. merge minimg will have to be tested.

I'll add a 12 share bounty for the first person to merge mine a block with your code, then 6 shares bounty for the second person.




Well what was happening was For transactions under 27k coins it would fall into allowfree since its always true and set fee to 0.. however there is am involuntary dust fee added which adds a small fee regardles of allowfree basefee \ 10 where basefee is 5 coins.. so 0.5 dvc.

So now fees for under 27k coins should be a little higher.The rest are same.

Even on the old code there was always a fee so no free tx got in even
before. I see the sync complete to the latest block index from block explorer.
sidhujag
Legendary
*
Offline Offline

Activity: 2044
Merit: 1004


View Profile
December 25, 2013, 07:43:52 AM
 #3006

And is that how bitcoin checks that same thing?

I understood that the new I0COin, on which this is based, was in turn based on new bitcoin?

-MarkM-


I coulsnt find many examples going from a pub script to a hash160.. I had to look up where hash160() was used to see what i had available... The keyid converts script address to hash160 by doing the strip.. I dont think the reciever stuff would have worked if it gave wrong address in the txout
markm
Legendary
*
Offline Offline

Activity: 2464
Merit: 1032



View Profile WWW
December 25, 2013, 07:53:44 AM
 #3007

When bitcoin changed its fees way back when, was that a "when a certain block is reached, these new different free go into effect" change?

Or is it actually okay to arbitrarily change the fee calculations without having such a spot on the chain at which the change comes into effect?

-MarkM-


Browser-launched Crossfire client now online (select CrossCiv server for Galactic  Milieu)
Free website hosting with PHP, MySQL etc: http://hosting.knotwork.com/
Wekkel
Legendary
*
Online Online

Activity: 2338
Merit: 1160


yes


View Profile
December 25, 2013, 07:56:59 AM
 #3008

I managed to install Github on Windows and get the .jar file. Upon install, I get an error, even if I make the 'Devcoin' folder manually.

[...]

Are you running as admin looks like it doesnt have priviledge? Try to install to say c:/mydvcwallet or something.

I run Windows as regular user. Apparently, the java installer indeed has trouble passing the standard security measures.

Installed in Desktop folder instead and moved everything to the regular program files folder. It workes fine and found my exiting wallet.
For the record: windows 8.1 pro 64 bit, client v0.8.5.1-g25a7d46-beta.

If someone wants to test payments again: 18GCTJhxrWfXjnLwwjJKsSYBpyEV16pRs (please mention return address in this thread).

Please note that payments will eat 0.5 DVC so I wont be able to return 100% of the amount received.

           ▀██▄ ▄██▀
            ▐█████▌
           ▄███▀███▄
         ▄████▄  ▀███▄
       ▄███▀ ▀██▄  ▀███▄
     ▄███▀  ▄█████▄  ▀███▄
   ▄███▀  ▄███▀ ▀███▄  ▀███▄
  ███▀  ▄████▌   ▐████▄  ▀███
 ███   ██▀  ██▄ ▄██  ▀██   ███
███   ███  ███   ███  ███   ███
███   ███   ███████   ███   ███
 ███   ███▄▄       ▄▄███   ███
  ███▄   ▀▀█████████▀▀   ▄███
   ▀████▄▄           ▄▄████▀
      ▀▀███████████████▀▀
DeepOnion
.Anonymous and Untraceable.
ANN  Whitepaper  Facebook  Twitter  Telegram  Discord 





      ▄▄██████████▄▄
    ▄███▀▀      ▀▀█▀   ▄▄
   ███▀              ▄███
  ███              ▄███▀   ▄▄
 ███▌  ▄▄▄▄      ▄███▀   ▄███
▐███  ██████   ▄███▀   ▄███▀
███▌ ███  ███▄███▀   ▄███▀
███▌ ███   ████▀   ▄███▀
███▌  ███   █▀   ▄███▀  ███
▐███   ███     ▄███▀   ███
 ███▌   ███  ▄███▀     ███
  ███    ██████▀      ███
   ███▄             ▄███
    ▀███▄▄       ▄▄███▀
      ▀▀███████████▀▀
.
Unthinkingbit
Hero Member
*****
Offline Offline

Activity: 935
Merit: 1008



View Profile
December 25, 2013, 07:57:08 AM
 #3009

..
Well what was happening was For transactions under 27k coins it would fall into allowfree since its always true and set fee to 0.. however there is am involuntary dust fee added which adds a small fee regardles of allowfree basefee \ 10 where basefee is 5 coins.. so 0.5 dvc.

So now fees for under 27k coins should be a little higher.The rest are same.

Even on the old code there was always a fee so no free tx got in even
before. I see the sync complete to the latest block index from block explorer.

That's good news. Also, bitcoin 0.8.x now also stops dust:
CTxOut::IsDust()

I still want to keep the devcoin dust stopping code, because bitcoin has different fees.

sidhujag
Legendary
*
Offline Offline

Activity: 2044
Merit: 1004


View Profile
December 25, 2013, 08:08:32 AM
 #3010

..
Well what was happening was For transactions under 27k coins it would fall into allowfree since its always true and set fee to 0.. however there is am involuntary dust fee added which adds a small fee regardles of allowfree basefee \ 10 where basefee is 5 coins.. so 0.5 dvc.

So now fees for under 27k coins should be a little higher.The rest are same.

Even on the old code there was always a fee so no free tx got in even
before. I see the sync complete to the latest block index from block explorer.

That's good news. Also, bitcoin 0.8.x now also stops dust:
CTxOut::IsDust()

I still want to keep the devcoin dust stopping code, because bitcoin has different fees.


Yea looks like it checks before send and adds dust to fee.
markm
Legendary
*
Offline Offline

Activity: 2464
Merit: 1032



View Profile WWW
December 25, 2013, 08:22:51 AM
 #3011

Wouldn't it be simpler, and more supportable going forward, to simply use bitcoin's fee code with the numbers such as how many satoshis consititutes dust all multiplied by 1000 ? Isn't that what we did originally? Or did we put in anti dust before bitcoin did?

(Even if we did though, using bitcoin's code might be easier to keep up with new bitcoin code versions going forward?)

-MarkM-

Browser-launched Crossfire client now online (select CrossCiv server for Galactic  Milieu)
Free website hosting with PHP, MySQL etc: http://hosting.knotwork.com/
sidhujag
Legendary
*
Offline Offline

Activity: 2044
Merit: 1004


View Profile
December 25, 2013, 08:32:56 AM
 #3012

Wouldn't it be simpler, and more supportable going forward, to simply use bitcoin's fee code with the numbers such as how many satoshis consititutes dust all multiplied by 1000 ? Isn't that what we did originally? Or did we put in anti dust before bitcoin did?

(Even if we did though, using bitcoin's code might be easier to keep up with new bitcoin code versions going forward?)

-MarkM-


I agree but I think fee changed in latest.. Also going fwd they doing something with more dynamic fee structure?? not sure if its worth it for us right now.
weisoq
Hero Member
*****
Offline Offline

Activity: 718
Merit: 500


View Profile
December 25, 2013, 10:13:31 AM
 #3013

I run Windows as regular user. Apparently, the java installer indeed has trouble passing the standard security measures.

Installed in Desktop folder instead and moved everything to the regular program files folder. It workes fine and found my exiting wallet.
For the record: windows 8.1 pro 64 bit, client v0.8.5.1-g25a7d46-beta.

If someone wants to test payments again: 18GCTJhxrWfXjnLwwjJKsSYBpyEV16pRs (please mention return address in this thread).

Please note that payments will eat 0.5 DVC so I wont be able to return 100% of the amount received.
Done (you missed a 'B' off the end). Same again.
Wekkel
Legendary
*
Online Online

Activity: 2338
Merit: 1160


yes


View Profile
December 25, 2013, 12:16:09 PM
Last edit: December 25, 2013, 12:56:00 PM by Wekkel
 #3014

The payment fees seem to have changed?

A payment apparently no longer requires only 0.5 DVC but between 5.5 to 6 DVC as a minimum? See screenshots below.





Weisoq, I have hold off from sending back for now until this is clear. Happy to fill it up to 10 again if - indeed - I need to burn 6 DVC to get 4 DVC back to you (once I reach my cold storage wallet).




           ▀██▄ ▄██▀
            ▐█████▌
           ▄███▀███▄
         ▄████▄  ▀███▄
       ▄███▀ ▀██▄  ▀███▄
     ▄███▀  ▄█████▄  ▀███▄
   ▄███▀  ▄███▀ ▀███▄  ▀███▄
  ███▀  ▄████▌   ▐████▄  ▀███
 ███   ██▀  ██▄ ▄██  ▀██   ███
███   ███  ███   ███  ███   ███
███   ███   ███████   ███   ███
 ███   ███▄▄       ▄▄███   ███
  ███▄   ▀▀█████████▀▀   ▄███
   ▀████▄▄           ▄▄████▀
      ▀▀███████████████▀▀
DeepOnion
.Anonymous and Untraceable.
ANN  Whitepaper  Facebook  Twitter  Telegram  Discord 





      ▄▄██████████▄▄
    ▄███▀▀      ▀▀█▀   ▄▄
   ███▀              ▄███
  ███              ▄███▀   ▄▄
 ███▌  ▄▄▄▄      ▄███▀   ▄███
▐███  ██████   ▄███▀   ▄███▀
███▌ ███  ███▄███▀   ▄███▀
███▌ ███   ████▀   ▄███▀
███▌  ███   █▀   ▄███▀  ███
▐███   ███     ▄███▀   ███
 ███▌   ███  ▄███▀     ███
  ███    ██████▀      ███
   ███▄             ▄███
    ▀███▄▄       ▄▄███▀
      ▀▀███████████▀▀
.
sidhujag
Legendary
*
Offline Offline

Activity: 2044
Merit: 1004


View Profile
December 25, 2013, 03:43:01 PM
 #3015

Im going to uncomment allow free code looks like it
uncovered a bug. I will leave it like it is.. The mintxfee is
set to 5*COIN.. This is what it was in devcoin src..

Now the min fee ends up being 5*coin plus dust filter 0.5*coin.. give me few
hrs I will update it back to what it was.
Wekkel
Legendary
*
Online Online

Activity: 2338
Merit: 1160


yes


View Profile
December 25, 2013, 04:03:15 PM
 #3016

No, take your time and relax. Fixing this can wait.

           ▀██▄ ▄██▀
            ▐█████▌
           ▄███▀███▄
         ▄████▄  ▀███▄
       ▄███▀ ▀██▄  ▀███▄
     ▄███▀  ▄█████▄  ▀███▄
   ▄███▀  ▄███▀ ▀███▄  ▀███▄
  ███▀  ▄████▌   ▐████▄  ▀███
 ███   ██▀  ██▄ ▄██  ▀██   ███
███   ███  ███   ███  ███   ███
███   ███   ███████   ███   ███
 ███   ███▄▄       ▄▄███   ███
  ███▄   ▀▀█████████▀▀   ▄███
   ▀████▄▄           ▄▄████▀
      ▀▀███████████████▀▀
DeepOnion
.Anonymous and Untraceable.
ANN  Whitepaper  Facebook  Twitter  Telegram  Discord 





      ▄▄██████████▄▄
    ▄███▀▀      ▀▀█▀   ▄▄
   ███▀              ▄███
  ███              ▄███▀   ▄▄
 ███▌  ▄▄▄▄      ▄███▀   ▄███
▐███  ██████   ▄███▀   ▄███▀
███▌ ███  ███▄███▀   ▄███▀
███▌ ███   ████▀   ▄███▀
███▌  ███   █▀   ▄███▀  ███
▐███   ███     ▄███▀   ███
 ███▌   ███  ▄███▀     ███
  ███    ██████▀      ███
   ███▄             ▄███
    ▀███▄▄       ▄▄███▀
      ▀▀███████████▀▀
.
sidhujag
Legendary
*
Offline Offline

Activity: 2044
Merit: 1004


View Profile
December 25, 2013, 06:48:12 PM
 #3017

No, take your time and relax. Fixing this can wait.

Done, uplaoded v1.0.4... we should test with greater than 27k coin transactions aswell. Please see if this one works as expected.
Wekkel
Legendary
*
Online Online

Activity: 2338
Merit: 1160


yes


View Profile
December 25, 2013, 09:49:10 PM
 #3018

Updated the client to 1.0.4. Managed to make a payment but still a 6 DVC payment fee (not that this is much though....).


           ▀██▄ ▄██▀
            ▐█████▌
           ▄███▀███▄
         ▄████▄  ▀███▄
       ▄███▀ ▀██▄  ▀███▄
     ▄███▀  ▄█████▄  ▀███▄
   ▄███▀  ▄███▀ ▀███▄  ▀███▄
  ███▀  ▄████▌   ▐████▄  ▀███
 ███   ██▀  ██▄ ▄██  ▀██   ███
███   ███  ███   ███  ███   ███
███   ███   ███████   ███   ███
 ███   ███▄▄       ▄▄███   ███
  ███▄   ▀▀█████████▀▀   ▄███
   ▀████▄▄           ▄▄████▀
      ▀▀███████████████▀▀
DeepOnion
.Anonymous and Untraceable.
ANN  Whitepaper  Facebook  Twitter  Telegram  Discord 





      ▄▄██████████▄▄
    ▄███▀▀      ▀▀█▀   ▄▄
   ███▀              ▄███
  ███              ▄███▀   ▄▄
 ███▌  ▄▄▄▄      ▄███▀   ▄███
▐███  ██████   ▄███▀   ▄███▀
███▌ ███  ███▄███▀   ▄███▀
███▌ ███   ████▀   ▄███▀
███▌  ███   █▀   ▄███▀  ███
▐███   ███     ▄███▀   ███
 ███▌   ███  ▄███▀     ███
  ███    ██████▀      ███
   ███▄             ▄███
    ▀███▄▄       ▄▄███▀
      ▀▀███████████▀▀
.
ranlo
Legendary
*
Offline Offline

Activity: 1652
Merit: 1002



View Profile
December 25, 2013, 10:18:20 PM
 #3019

Updated the client to 1.0.4. Managed to make a payment but still a 6 DVC payment fee (not that this is much though....).



Can we please see your incoming transactions? Or at least the # of them? The message you see insinuates it is using 80+ transactions to build your outgoing one.
Wekkel
Legendary
*
Online Online

Activity: 2338
Merit: 1160


yes


View Profile
December 25, 2013, 10:56:24 PM
 #3020

See this link

           ▀██▄ ▄██▀
            ▐█████▌
           ▄███▀███▄
         ▄████▄  ▀███▄
       ▄███▀ ▀██▄  ▀███▄
     ▄███▀  ▄█████▄  ▀███▄
   ▄███▀  ▄███▀ ▀███▄  ▀███▄
  ███▀  ▄████▌   ▐████▄  ▀███
 ███   ██▀  ██▄ ▄██  ▀██   ███
███   ███  ███   ███  ███   ███
███   ███   ███████   ███   ███
 ███   ███▄▄       ▄▄███   ███
  ███▄   ▀▀█████████▀▀   ▄███
   ▀████▄▄           ▄▄████▀
      ▀▀███████████████▀▀
DeepOnion
.Anonymous and Untraceable.
ANN  Whitepaper  Facebook  Twitter  Telegram  Discord 





      ▄▄██████████▄▄
    ▄███▀▀      ▀▀█▀   ▄▄
   ███▀              ▄███
  ███              ▄███▀   ▄▄
 ███▌  ▄▄▄▄      ▄███▀   ▄███
▐███  ██████   ▄███▀   ▄███▀
███▌ ███  ███▄███▀   ▄███▀
███▌ ███   ████▀   ▄███▀
███▌  ███   █▀   ▄███▀  ███
▐███   ███     ▄███▀   ███
 ███▌   ███  ▄███▀     ███
  ███    ██████▀      ███
   ███▄             ▄███
    ▀███▄▄       ▄▄███▀
      ▀▀███████████▀▀
.
Pages: « 1 ... 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 [151] 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 ... 412 »
  Print  
 
Jump to:  

Sponsored by , a Bitcoin-accepting VPN.
Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!