Bitcoin Forum
October 22, 2020, 07:22:18 AM *
News: Latest Bitcoin Core release: 0.20.0 [Torrent]
 
   Home   Help Search Login Register More  
Pages: « 1 ... 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 [155] 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 ... 427 »
  Print  
Author Topic: [DVC]DevCoin - Official Thread - Moderated  (Read 1050370 times)
This is a self-moderated topic. If you do not want to be moderated by the person who started this topic, create a new topic.
sidhujag
Legendary
*
Offline Offline

Activity: 2044
Merit: 1004


View Profile
December 27, 2013, 04:00:08 PM
 #3081

Sidhujag get 48 shares provisionally, on the condition that a code report shows that the changes are the same as that of the most recent source from Twobits:
https://gitorious.org/devcoin/devcoin

The changes must be identical or else there could be a network fork. Since we now need a quick code report, the bounty for that has been boosted to 12 shares for the first report and 6 shares for the second report.


Hello,

Here's a detailled code report.
I took ALL the commits made by Twobits or twobits in the devcoin client.
I made a list from all the changes made by twobits and compare with the code of Sidhujag.

 historical commits from twobits


May 26 2013   #fd07754  don't need stack randomization macro with [...] (twobits)
https://gitorious.org/devcoin/devcoin/commit/fd07754b44b6fb4d4f402085c9321f9cfbff6737

May 26 2013   #bdce5f0  Make things say devcoin (twobits)
https://gitorious.org/devcoin/devcoin/commit/bdce5f0526530a8bc24128cd0428403795373ce2

Jul 5 2013   #1785cc4  Add RPC commands: getblockhash and getblock (twobits)
https://gitorious.org/devcoin/devcoin/commit/1785cc420cd280abdb68b3af83d9dd3a28e5ef2d

Jul 16 2013   #fba32e5  Clean up headers. (Twobits)
https://gitorious.org/devcoin/devcoin/commit/fba32e5e31dcaa9d0f60d7c24000b24bb1dbcea2

Jul 18 2013   #29ddd73  only the ui files need to include xbm files (Twobits)
https://gitorious.org/devcoin/devcoin/commit/29ddd73a8b3dd6cf49e38ac5b2f98a32eab35cc6

Jul 18 2013   #f1d5b3c  devcoin graphics (twobits)
https://gitorious.org/devcoin/devcoin/commit/f1d5b3c56c74ea80a8aa21111dca2d4d17d077d1

Aug 20 2013   #ce01e7a  match rpc port change to 52332 in official repo (twobits)
https://gitorious.org/devcoin/devcoin/commit/ce01e7af882ae6579204168e3c4d1a0871936a37

Aug 20 2013   #6241096  BIP 30 (twobits)
https://gitorious.org/devcoin/devcoin/commit/62410960cc5c23921a18040529e2524780af8b6c

Aug 20 2013   #4e23c18  add DNSSeeds (twobits)
https://gitorious.org/devcoin/devcoin/commit/4e23c180945785c49bbab682b7f6c6e1eda29b05

historical commits from twobits with commited files

May 26 2013   #fd07754  don't need stack randomization macro with [...] (twobits)
src/db.cpp (2) -+
src/irc.cpp (1) -
src/net.cpp (4) ----
src/rpc.cpp (1) -
src/util.h (13) -------------
May 26 2013   #bdce5f0  Make things say devcoin (twobits)
share/pixmaps/devcoin.ico (0)
share/pixmaps/favicon.ico (0)
share/pixmaps/nsis-header.bmp (0)
share/pixmaps/nsis-wizard.bmp (0)
share/ui.rc (2) -+
src/ui.cpp (2) -+
src/uibase.cpp (14) -------+++++++
src/uibase.h (6) ---+++
Jul 5 2013   #1785cc4  Add RPC commands: getblockhash and getblock (twobits)
src/main.h (1) -
src/rpc.cpp (92) -------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Jul 16 2013   #fba32e5  Clean up headers. (Twobits)
src/headers.h (21) ------------+++++++++
src/net.cpp (3) +++
src/protocol.h (11) -++++++++++
Jul 18 2013   #29ddd73  only the ui files need to include xbm files (Twobits)
src/headers.h (15) ---------------
src/ui.cpp (5) +++++
src/xpm/bitcoin80.xpm (2) -+
Jul 18 2013   #f1d5b3c  devcoin graphics (twobits)
src/xpm/bitcoin16.xpm (350) -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin20.xpm (315) ------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin32.xpm (341) ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin48.xpm (401) ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin80.xpm (492) ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Aug 20 2013   #ce01e7a  match rpc port change to 52332 in official repo (twobits)
src/init.cpp (2) -+
src/rpc.cpp (6) ---+++
Aug 20 2013   #6241096  BIP 30 (twobits)
src/main.cpp (26) --++++++++++++++++++++++++
Aug 20 2013   #4e23c18  add DNSSeeds (twobits)
src/net.cpp (9) ------+++

30 committed files list by twobits

src/db.cpp (2) -+
src/irc.cpp (1) -
src/net.cpp (4) ----
src/rpc.cpp (1) -
src/util.h (13) -------------
share/pixmaps/devcoin.ico (0)
share/pixmaps/favicon.ico (0)
share/pixmaps/nsis-header.bmp (0)
share/pixmaps/nsis-wizard.bmp (0)
share/ui.rc (2) -+
src/ui.cpp (2) -+
src/uibase.cpp (14) -------+++++++
src/uibase.h (6) ---+++
src/main.h (1) -
src/rpc.cpp (92) -------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/headers.h (21) ------------+++++++++
src/net.cpp (3) +++
src/protocol.h (11) -++++++++++
src/headers.h (15) ---------------
src/ui.cpp (5) +++++
src/xpm/bitcoin80.xpm (2) -+
src/xpm/bitcoin16.xpm (350) -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin20.xpm (315) ------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin32.xpm (341) ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin48.xpm (401) ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin80.xpm (492) ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/init.cpp (2) -+
src/rpc.cpp (6) ---+++
src/main.cpp (26) --++++++++++++++++++++++++
src/net.cpp (9) ------+++

remarks :
          src/net.cpp appearing in two commits !
          src/rpc.cpp appearing in three commits !
          src/ui.cpp appearing in two commits !
          src/headers.h appearing in two commits !
         
25 unique files by twobits

src/db.cpp (2) -+
src/irc.cpp (1) -
src/net.cpp (4) ----
            (9) ------+++
src/rpc.cpp (1) -
            (92) -------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
            (6) ---+++
src/util.h (13) -------------
share/pixmaps/devcoin.ico (0)
share/pixmaps/favicon.ico (0)
share/pixmaps/nsis-header.bmp (0)
share/pixmaps/nsis-wizard.bmp (0)
share/ui.rc (2) -+
src/ui.cpp (2) -+
           (5) +++++
src/uibase.cpp (14) -------+++++++
src/uibase.h (6) ---+++
src/main.h (1) -
src/headers.h (21) ------------+++++++++
              (15) ---------------
src/net.cpp (3) +++
src/protocol.h (11) -++++++++++
src/xpm/bitcoin80.xpm (2) -+
src/xpm/bitcoin16.xpm (350) -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin20.xpm (315) ------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin32.xpm (341) ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin48.xpm (401) ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin80.xpm (492) ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/init.cpp (2) -+
src/main.cpp (26) --++++++++++++++++++++++++


Compare Twobits changed files with same Sidhujag files

Twobits Files not used or cosmetic changes in Sidhujag

share/pixmaps/nsis-header.bmp (0)
share/pixmaps/nsis-wizard.bmp (0)
share/pixmaps/devcoin.ico (0)
share/pixmaps/favicon.ico (0)
ok (bmp files replaced by .png files !)
ok (ico files replaced by good ico files)

src/xpm/bitcoin80.xpm (2) -+
src/xpm/bitcoin16.xpm (350) -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin20.xpm (315) ------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin32.xpm (341) ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin48.xpm (401) ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/xpm/bitcoin80.xpm (492) ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
ok (xpm file not used by qt version -> use png instead)

src/ui.cpp (2) -+
src/uibase.cpp (14) -------+++++++
src/uibase.h (6) ---+++
ok (these files are not used by QT version -> not important : only bitcoin replace by devcoin string !)

Jul 16 2013   #fba32e5  Clean up headers. (Twobits)
src/headers.h (21) ------------+++++++++
Jul 18 2013   #29ddd73  only the ui files need to include xbm files (Twobits)
src/headers.h (15) ---------------
ok (file doesn't exist in qt version -> other file used for headers ?)

Twobits Files changes important in Sidhujag

Aug 20 2013 #4e23c18  add DNSSeeds (twobits)
https://gitorious.org/devcoin/devcoin/commit/4e23c180945785c49bbab682b7f6c6e1eda29b05

src/net.cpp   
ok ("dvcstable01.dvcnode.org" , "dvc-seed.21stcenturymoneytalk.org", "dvcstable01.devtome.com")

Aug 20 2013   #ce01e7a  match rpc port change to 52332 in official repo (twobits)
https://gitorious.org/devcoin/devcoin/commit/ce01e7af882ae6579204168e3c4d1a0871936a37

src/init.cpp (2) -+
src/rpc.cpp (6) ---+++
ok (in init.cpp replace "8332" string port by "52332" string port)
ok (rpc.cpp is subdivided in many files with rpc prefix but no string containing 52332 or 8332 -> perhaps defined in another place ? )

Jul 16 2013   #fba32e5  Clean up headers. (Twobits)
https://gitorious.org/devcoin/devcoin/commit/fba32e5e31dcaa9d0f60d7c24000b24bb1dbcea2

src/headers.h (21) ------------+++++++++
* file doesn't exist in qt version
but for BSD version need these lines
https://gitorious.org/devcoin/devcoin/commit/fba32e5e31dcaa9d0f60d7c24000b24bb1dbcea2
#define __STDC_LIMIT_MACROS
// to enable UINT64_MAX from stdint.h   
#include <stdint.h>


src/net.cpp (3) +++
* missing (stdint include)
https://gitorious.org/devcoin/devcoin/commit/fba32e5e31dcaa9d0f60d7c24000b24bb1dbcea2
#include <stdint.h>

src/protocol.h (11) -++++++++++
* missing (idef for win)
https://gitorious.org/devcoin/devcoin/commit/fba32e5e31dcaa9d0f60d7c24000b24bb1dbcea2
#ifndef _WIN32
#include <netinet/in.h>
#include <sys/socket.h>
#include <net/if.h>
#include <netdb.h>
#include <ifaddrs.h>
#endif


Jul 5 2013   #1785cc4  Add RPC commands: getblockhash and getblock (twobits)
https://gitorious.org/devcoin/devcoin/commit/1785cc420cd280abdb68b3af83d9dd3a28e5ef2d

src/main.h (1) -
* not removed (class declaration in qt version -> used in qt version ?)
//class CBlockIndex;

src/rpc.cpp (92) -------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
ok (rpc.cpp replaced by rpcblockchain.cpp)
ok (change in fonction double GetDifficulty()
ok (functions getblock and getblockhash added (same code)
* differences (in function block on three Pairs names)
In twobits |in  sidhujag
result.push_back(Pair("blockcount", blockindex->nHeight)); | result.push_back(Pair("height", blockindex->nHeight));
result.push_back(Pair("hashprevious", blockindex->pprev->GetBlockHash().GetHex())); |  result.push_back(Pair("previousblockhash", blockindex->pprev->GetBlockHash().GetHex()));
result.push_back(Pair("hashnext", blockindex->pnext->GetBlockHash().GetHex())); |  result.push_back(Pair("nextblockhash", blockindex->pnext->GetBlockHash().GetHex()));

Aug 20 2013   #6241096  BIP 30 (twobits)
https://gitorious.org/devcoin/devcoin/commit/62410960cc5c23921a18040529e2524780af8b6c

src/main.cpp (26) --++++++++++++++++++++++++
* differences
https://gitorious.org/devcoin/devcoin/commit/62410960cc5c23921a18040529e2524780af8b6c
In twobits commit , the rule applies to all blocks whose timestamp is after March 15, 2012, 0:00 UTC (1331769600)   
   and on testnet it is enabled as of februari 20, 2012, 0:00 UTC. (1329696000)
In Sidjuhag version , for DVC the rule BIP30 for Devcoin will go into effect on 2013-09-01 0:00 UTC (1377993600)
I think that Sidjuhag version is correct !

May 26 2013   #fd07754  don't need stack randomization macro with [...] (twobits)
https://gitorious.org/devcoin/devcoin/commit/fd07754b44b6fb4d4f402085c9321f9cfbff6737

ok (no stack random macro implemented in util.h and not used in any files !)

src/db.cpp (2) -+

ok (change applied in   void CDB::Flush() in Sidjuhag version)

src/irc.cpp (1) -
* no irc.cpp file in Sidjuhag version !

src/net.cpp (4) ----
ok (macro not used)

src/rpc.cpp (1) -
ok (macro not used in rpcblockchain.cpp)

src/util.h (13) -------------
ok (no stack random macro implemented)

Before reaching to a conclusion I would like comments from Sidhujag on my code report. Now I can't show if changes are the same or not (fork or not fork ?)   Embarrassed

Cyke64





The first difference about the timestamp on bip30 I think that is to avert a potential problem in the future so since blocks are already created and patch is applied I think its safe? Unless someone can prove me wrong?

On the blockcount to height rename etc looks like simple rename if these are rpc calls We just need to ensure that the merged mine proxy doesnt make the old calls. i downloaded latest one from i0coin and dbl checked with namecoin so it will use renamed rpc calls if thats the casse. i will check.

Do merged mine pools run thru this merged mine proxy in the contrib folder?

The main stuff is the createnewblock processblock where the reciever stuff is the small changes there but we already talked about that... Am i right in saying that since i take a fresh database and fill it with the blockchain from block 1 and it downloads all blocks that the block processing and bip stuff is all good?

Merged mining will test any rpc differences since i did internal mining I didnt jog the getworkaux stuff. You can merge mine on testnet too using the nerged mine proxy and the three nodes I have setup in the src folder just run the three batch files and then comnect the proxy.. Then point miner to proxy.. Getworkaux gets called but i got no new blocks i thought ut was a setup issue since my network is locked down from blockchain downloads on my dev machine.

Did you look at the devtome technical page and compare with new code? Also receiver.h was changed did you catch that?

On the blockcount to height rename etc looks like simple rename if these are rpc calls We just need to ensure that the merged mine proxy doesnt make the old calls. i downloaded latest one from i0coin and dbl checked with namecoin so it will use renamed rpc calls if thats the casse. i will check.

Jul 5 2013   #1785cc4  Add RPC commands: getblockhash and getblock (twobits)
src/rpc.cpp (92) -------+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

* differences (in function block on three Pairs names)
twobits | sidjuhag
result.push_back(Pair("blockcount", blockindex->nHeight)); | result.push_back(Pair("height", blockindex->nHeight));
result.push_back(Pair("hashprevious", blockindex->pprev->GetBlockHash().GetHex())); |  result.push_back(Pair("previousblockhash", blockindex->pprev->GetBlockHash().GetHex()));
result.push_back(Pair("hashnext", blockindex->pnext->GetBlockHash().GetHex())); |  result.push_back(Pair("nextblockhash", blockindex->pnext->GetBlockHash().GetHex()));

not important because these pairs are only used here locally in this file (no definition in another place)

Here are more details and check about BIP.
Aug 20 2013   #6241096  BIP 30 (twobits)
src/main.cpp (26) --++++++++++++++++++++++++
* differences
https://gitorious.org/devcoin/devcoin/commit/62410960cc5c23921a18040529e2524780af8b6c
In twobits commit , the rule applies to all blocks whose timestamp is after March 15, 2012, 0:00 UTC (1331769600)   
   and on testnet it is enabled as of februari 20, 2012, 0:00 UTC. (1329696000)
In Sidjuhag version , for DVC the rule BIP30 for Devcoin will go into effect on 2013-09-01 0:00 UTC (1377993600)

In twobits | In Sidhujag
no BIP16  | BIP16 enabled
BIP30 after March 15,2012 | BIP30 after 2013-09-01


Getworkaux gets called but i got no new blocks i thought ut was a setup issue since my network is locked down from blockchain downloads on my dev machine.

Aug 20 2013   #ce01e7a  match rpc port change to 52332 in official repo (twobits)
src/init.cpp (2) -+
src/rpc.cpp (6) ---+++

PROBLEM :
port used by RPCPORT is always 52332 (there's no testnet) in twobits instead of bitcoin RPCPORT 8332.
In Sidhujag , port used is 7332 defaut and for testnet 17332 (src\bitcoinrpc.cpp,src\init.cpp)
Could it be the source of your problem ?


Did you look at the devtome technical page and compare with new code?"

CreateNewBlock

Everything is correct (like twobits)
I check out also the GetKeyID function you used instead of finding the hash160.

pblock->vtx[0].vout[0].nValue = GetBlockValue(pindexPrev->nHeight+1, nFees);
   txNew.vout[0].nValue = minerValue + nFees;
in devtome wiki technical

But in all codes (twobits,Sidjuhag) , it's  pblock->vtx[0].vout[0].nValue = minerValue + nFees;
so wiki content should be corrected with the right assign statement.

GetNextWorkRequired
code contents are the same except your difficulty rule code for testnet you added.

generation rate

devtome wiki :
//static const int64 MIN_TX_FEE = 50000;
static const int64 MIN_TX_FEE = 500000000;
//static const int64 MIN_RELAY_TX_FEE = 10000;
static const int64 MIN_RELAY_TX_FEE = MIN_TX_FEE;
//static const int64 MAX_MONEY = 21000000 * COIN;
static const int64 MAX_MONEY = 21000000000 * COIN;



Twobits | Sidjuhag :
static const int64 MAX_MONEY = 21000000000 * COIN; | static const int64 MAX_MONEY = (int64)21000000 * (int64)1000 * COIN;
static const int64 COIN = 100000000; | static const int64 COIN = 100000000;
MIN_TX_FEE  | int64 CTransaction::nMinTxFee = COIN;
MIN_RELAY_TX_FEE |   int64 CTransaction::nMinRelayTxFee = COIN;


MIN_TX_FEE = MIN_RELAY_TX_FEE = 500,000,000 but in Twobits and Sidhujag values are
100,000,000 = COIN
Why ?

Disbursing the Share
Code is the same.

receiver.h was changed

Yes but I don't see any problem (you add code for testnet and some debug code)

I'm waiting for your comments about this code report
Cyke64



The fee was coming to 5.5 dvc for transactions per 1k bytes I think bitcoin fees were scaled down? When I changed the fee down to 1 coin from 5 coins they now make sense. The dust fee is 1\10th of 1 coin per vout. So if you set multiple recipients in your transaction like create 5 new address and set small amount to each you will see a 0.5dvc fee plus 1 coin so 1.5 dvc fee..
1603351338
Hero Member
*
Offline Offline

Posts: 1603351338

View Profile Personal Message (Offline)

Ignore
1603351338
Reply with quote  #2

1603351338
Report to moderator
1603351338
Hero Member
*
Offline Offline

Posts: 1603351338

View Profile Personal Message (Offline)

Ignore
1603351338
Reply with quote  #2

1603351338
Report to moderator
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction. Advertise here.
1603351338
Hero Member
*
Offline Offline

Posts: 1603351338

View Profile Personal Message (Offline)

Ignore
1603351338
Reply with quote  #2

1603351338
Report to moderator
Wekkel
Legendary
*
Offline Offline

Activity: 2632
Merit: 1272


yes


View Profile
December 27, 2013, 04:16:33 PM
 #3082

Ok, tested the payment fees again. When sending 8 DVC, no message from my client (it sends the payment right away). At 7 DVC, the client informs me that a 1.2 DVC fee will apply. I have not investigated further into decimals.

           ▀██▄ ▄██▀
            ▐█████▌
           ▄███▀███▄
         ▄████▄  ▀███▄
       ▄███▀ ▀██▄  ▀███▄
     ▄███▀  ▄█████▄  ▀███▄
   ▄███▀  ▄███▀ ▀███▄  ▀███▄
  ███▀  ▄████▌   ▐████▄  ▀███
 ███   ██▀  ██▄ ▄██  ▀██   ███
███   ███  ███   ███  ███   ███
███   ███   ███████   ███   ███
 ███   ███▄▄       ▄▄███   ███
  ███▄   ▀▀█████████▀▀   ▄███
   ▀████▄▄           ▄▄████▀
      ▀▀███████████████▀▀
DeepOnion
.Anonymous and Untraceable.
ANN  Whitepaper  Facebook  Twitter  Telegram  Discord 





      ▄▄██████████▄▄
    ▄███▀▀      ▀▀█▀   ▄▄
   ███▀              ▄███
  ███              ▄███▀   ▄▄
 ███▌  ▄▄▄▄      ▄███▀   ▄███
▐███  ██████   ▄███▀   ▄███▀
███▌ ███  ███▄███▀   ▄███▀
███▌ ███   ████▀   ▄███▀
███▌  ███   █▀   ▄███▀  ███
▐███   ███     ▄███▀   ███
 ███▌   ███  ▄███▀     ███
  ███    ██████▀      ███
   ███▄             ▄███
    ▀███▄▄       ▄▄███▀
      ▀▀███████████▀▀
.
sidhujag
Legendary
*
Offline Offline

Activity: 2044
Merit: 1004


View Profile
December 27, 2013, 04:17:47 PM
 #3083

The default rpcport is a setting in the conf file that I oerwrote I can connext so its working. I will change this but its only useful for proxies and if conf file doesnt specify rpcporr in the firet place...

Otherwise we just need to send a few coins back forth to confirm fees and mining merged works.
sidhujag
Legendary
*
Offline Offline

Activity: 2044
Merit: 1004


View Profile
December 27, 2013, 04:20:09 PM
 #3084

Ok, tested the payment fees again. When sending 8 DVC, no message from my client (it sends the payment right away). At 7 DVC, the client informs me that a 1.2 DVC fee will apply. I have not investigated further into decimals.

Ya 1.2 dvc fees are normal or 0.2 dvc fees depends on transaction..
markm
Legendary
*
Offline Offline

Activity: 2618
Merit: 1038



View Profile WWW
December 27, 2013, 04:28:21 PM
 #3085

The default rpcport is a setting in the conf file that I oerwrote I can connext so its working. I will change this but its only useful for proxies and if conf file doesnt specify rpcporr in the firet place...

Otherwise we just need to send a few coins back forth to confirm fees and mining merged works.

I never use conf files, except for those ancient multicoin-based coins like the old GeistGeld and Tenebrix.

If for some reason I need to use a port other than the default I put it on the commandline in my start-the-daemon script.

Usually I do not put it on the commandline though because to do so I'd have to go digging into the source-code to discover what the heck the default port actually is, since that is the port I'd put there anyway unless it was one of those stupid crapcoins that forgot to change its port from whichever coin it was cloned from; and those coins I usually try to avoid.

-MarkM-

Browser-launched Crossfire client now online (select CrossCiv server for Galactic  Milieu)
Free website hosting with PHP, MySQL etc: http://hosting.knotwork.com/
sidhujag
Legendary
*
Offline Offline

Activity: 2044
Merit: 1004


View Profile
December 27, 2013, 05:17:34 PM
 #3086

The default rpcport is a setting in the conf file that I oerwrote I can connext so its working. I will change this but its only useful for proxies and if conf file doesnt specify rpcporr in the firet place...

Otherwise we just need to send a few coins back forth to confirm fees and mining merged works.

I never use conf files, except for those ancient multicoin-based coins like the old GeistGeld and Tenebrix.

If for some reason I need to use a port other than the default I put it on the commandline in my start-the-daemon script.

Usually I do not put it on the commandline though because to do so I'd have to go digging into the source-code to discover what the heck the default port actually is, since that is the port I'd put there anyway unless it was one of those stupid crapcoins that forgot to change its port from whichever coin it was cloned from; and those coins I usually try to avoid.

-MarkM-


Ya that was i0coin ports I scanned Important places left that one out.. Should change...

Anyone have  experience with maven? Having a heck of a time building
bitcoinj with android wallet ootb.
Unthinkingbit
Hero Member
*****
Offline Offline

Activity: 935
Merit: 1015



View Profile
December 27, 2013, 08:48:24 PM
Last edit: December 27, 2013, 09:02:31 PM by Unthinkingbit
 #3087

..
Here's a detailled code report.
I took ALL the commits made by Twobits or twobits in the devcoin client.
I made a list from all the changes made by twobits and compare with the code of Sidhujag.

Thank you for your excellent code report, you get 12 shares:
https://raw.github.com/Unthinkingbit/charity/master/bounty_31.csv

The last remaining code report bounty is 6 shares.

Quote
..
The first difference about the timestamp on bip30 I think that is to avert a potential problem in the future so since blocks are already created and patch is applied I think its safe? Unless someone can prove me wrong?

I agree, it should be the same as Twobits's version. It will work anyways, but it's one less difference to keep track of.

Quote
..
pblock->vtx[0].vout[0].nValue = GetBlockValue(pindexPrev->nHeight+1, nFees);
   txNew.vout[0].nValue = minerValue + nFees;
in devtome wiki technical

But in all codes (twobits,Sidjuhag) , it's  pblock->vtx[0].vout[0].nValue = minerValue + nFees;

pblock->vtx[0] is txNew

because the txNew is the first transaction to be placed on the block:

Code:
// Add our coinbase tx as first transaction
pblock->vtx.push_back(txNew);

so it should be changed in the code to txNew instead of pblock->vtx[0] because it's simpler and easier to read.

Quote
..
MIN_TX_FEE = MIN_RELAY_TX_FEE = 500,000,000 but in Twobits and Sidhujag values are
100,000,000 = COIN
Why ?

Twobits changed that without telling me. I didn't know because at the time we couldn't afford a code review. Now that blocks have been made with Twobit's lower transaction fee, the change must be kept and I will change the wiki documentation.

For the port difference noted by cyke64:

Quote
port used by RPCPORT is always 52332 (there's no testnet) in twobits instead of bitcoin RPCPORT 8332.
In Sidhujag , port used is 7332 defaut and for testnet 17332 (src\bitcoinrpc.cpp,src\init.cpp)
Could it be the source of your problem ?

Sidhujag wrote:

The default rpcport is a setting in the conf file that I oerwrote I can connext so its working. I will change this but its only useful for proxies and if conf file doesnt specify rpcporr in the firet place...

Otherwise we just need to send a few coins back forth to confirm fees and mining merged works.

I'm glad this will be changed. Even if it's overwritten, it's still good to have it the same as the documentation to prevent confusion.

sidhujag
Legendary
*
Offline Offline

Activity: 2044
Merit: 1004


View Profile
December 27, 2013, 08:54:06 PM
 #3088

..
Here's a detailled code report.
I took ALL the commits made by Twobits or twobits in the devcoin client.
I made a list from all the changes made by twobits and compare with the code of Sidhujag.

Thank you for your excellent code report, you get 12 shares:


The last remaining code report bounty is 6 shares.

You try out the java installer? I will create a sorceforge so
I can host the releases.
Unthinkingbit
Hero Member
*****
Offline Offline

Activity: 935
Merit: 1015



View Profile
December 27, 2013, 09:01:32 PM
 #3089

..
You try out the java installer? I will create a sorceforge so
I can host the releases.

I haven't tried the java installer. The code must be tested and finalized before making a bounty for an installer.

KleinMatthias
Newbie
*
Offline Offline

Activity: 56
Merit: 0


View Profile
December 27, 2013, 09:18:58 PM
Last edit: December 27, 2013, 09:32:06 PM by KleinMatthias
 #3090

Hi,

Since not all users of this coin are as active as you are, may I ask for a feature in a future wallet version?

Please implement one of the following features:
1) an autoupdate feature which automatically keeps the QT updated without the user doing anything (or with the user just clicking an "update" button which only appears when new updates are available - but where the entire update process is done automatically)
2) a notification feature where the user can enter his eMail address into the wallet and the wallet sends him an eMail when a new version is available? That requires - of course - that the wallet has a way to check for updates. But since Microsoft/Apple/Adobe/andalltheothers can do it, so can you :-)
3) (for those who don't even run their QT all the time) a notification feature where the user can enter his eMail address into the wallet and the wallet sends that eMail address plus its own version information to a central server of yours which then sends out an eMail when a new software version is available. And which sends a warning eMail when a mantatory update has to be performed.

Naturally, as of today, the Cryptocurrency-community has been very active but with the price explosion of the Bitcoin last month, more and more "normal users" will enter the market.
They will not keep their wallet running all the time.
They will not check the forum all the time.
But they might spend hard cash on buying this coin at an exchange and then send it over to their wallet. As a community, we even need that kind of passive user - and we need their money buying this coin.
And when they find ways to spend or donate the coin, they will. And for that purpose they will open their wallets - but not in between.

Having said this, I personally prefer feature (3) because it has a few advantage over the other 2:

  • It keeps even those "passive" users in the loop that do not run their wallet regularily.
  • That way, if a really important change has to be made (e.g. a new blockchain), even those users won't lose their money because they get a notification. Think of the bad publicity when "normal users" start losing their money because they simply ignored their wallets for months only to find them not working anymore because weeks before, a new blockchain or equally invasive measure was introduced without them knowing.
  • That feature can be extended for marketing purposes: add a checkmark "the makers of this coin are allowed to send me exciting news about this coin yaddayaddaya" - and voila you get yourself a free marketing database with tons of eMail addresses that you can use to keep engaging your users. Notify them of new shops where they can pay with this currency. Notify them of faucets. Notify them of exchanges that trade this coin. Notify them of the rise in value of that coin. And so on. Just keep engaging even the passive users - because to make a currency successful, you need every hand and every dollar you can get.

You guys and all the other professionals or those that have privacy concerns won't use that feature - and should never be required to do so. But the regular passive user will get that fuzzy feeling that he will be informed of important stuff without him spending much time checking bitcointalk or their wallets. And that will give him extra confidence when it comes to him spending the coin or buying the coin with his FIAT.

Just a few additional remarks:

  • Naturally, the best possible combination would be (3) with (1) where the users gets a "move your ass and update your wallet or else..." eMail (friendly version, of course) - and then he opens the wallet and clicks on the "update" button and that's it for him.
  • May be the required serverside portion (the thing that collects all version information and the eMail addresses and which also allows for sending out mass eMails to all users in that database) could be written in a generic way so that other virtual currencies can implement that feature, too?
  • May be, future wallets should have a default setting that causes them to run in the background as a service whenever the computer starts. That way, even many passive users will contribute to the P2P network without them even knowing. But that was just a sideline remark and describes a completely different feature request. But then again, while you are at it... :-)

Don't know. What do you guys think about that feature request?
Does anyone second that request?
Does anyone have a better idea how to solve the above mentioned challenges that this new species of regular, passive users will introduce in the weeks and months to come?

Thanks
Matt
DVC: 1NEvNu9EC9YzRoviNaZDrt6TfqfZsKqLE9


P.S. Just a full disclosure: I have posted this same feature request to the thread of some other cryptocurrencies as well.
sidhujag
Legendary
*
Offline Offline

Activity: 2044
Merit: 1004


View Profile
December 27, 2013, 11:49:07 PM
Last edit: December 28, 2013, 12:42:37 AM by sidhujag
 #3091

..
Here's a detailled code report.
I took ALL the commits made by Twobits or twobits in the devcoin client.
I made a list from all the changes made by twobits and compare with the code of Sidhujag.

Thank you for your excellent code report, you get 12 shares:


The last remaining code report bounty is 6 shares.

You try out the java installer? I will create a sorceforge so
I can host the releases.

Uploaded latest release with the changes suggested above:

Block reference to txNew and changed rpcports,

Created new hosted installer 1.0.7 at: https://sourceforge.net/projects/devcoin/files/

You can download lastest java installer here. As soon as we upload it to the official site devcoin.org I can create a web installer that will only be 1.5 megs and download the right pack depending on the platform selected.

One issue I was having was, I tried to send some coins back to my vircurex account, but I dont even see my transaction show up on the blockchain? It shows on my wallet(non confirmed), and its been more than a day? How can that happen? Maybe 0.2 dvc is too little of a fee and not accepted by old clients?


So I created 1.0.8 by setting the fees to you 5*COIN like it is in the current codebase. So the fee is high for small transactions in single digit DVC but it is ok for normal transactions. I sent a bunch using the normal fees to my vircurex account and now seeing if they get confirmed by the older client on the blockchain explorer http://darkgamex.ch:2751
notabot
Member
**
Offline Offline

Activity: 99
Merit: 10



View Profile
December 28, 2013, 02:16:09 AM
 #3092

To assist in the proper functioning of the Devtome wiki for future growth, articles require categorizing. Please take the time to categorize all new articles that you post. If you don’t do this it will take an admin time and effort to complete this, and as admins are quite busy behind the scenes, it is in everyone’s best interest if author’s do this as they go. In addition to your new articles, you should also go over all your previous articles and categorize them also, as it could affect your word count by 10%.

There is a brief page at Devtome Categorizing Your Articles that explains the process. If anyone notices any errors on this page, please post so we can ensure the process is correct.

Thank you.

sidhujag
Legendary
*
Offline Offline

Activity: 2044
Merit: 1004


View Profile
December 28, 2013, 03:20:37 AM
 #3093

Anyone who tested the new client were you able to send coins to old clients? I sent coins to vircurex and the transaction is not on block chain. I even tried to put the fees back to what the old source was (1.0.8 ) still not on there.
cyke64
Newbie
*
Offline Offline

Activity: 15
Merit: 0


View Profile
December 28, 2013, 04:04:54 AM
 #3094

..
Here's a detailled code report.
I took ALL the commits made by Twobits or twobits in the devcoin client.
I made a list from all the changes made by twobits and compare with the code of Sidhujag.

Thank you for your excellent code report, you get 12 shares:
https://raw.github.com/Unthinkingbit/charity/master/bounty_31.csv

The last remaining code report bounty is 6 shares.


Thank you  Cheesy
Today I take a look in the account_31.csv but I'am only located one time in the file for trying the new Sidjuhag client.
I saw no mention yet for the code report  Shocked
I wrote during round 31 two short articles on devtome. If the word count is < to 1000 can I see my word count ? If the answer is affirmative in which file of the website Charity ?


advanced
Sr. Member
****
Offline Offline

Activity: 267
Merit: 250


Woodwallets.io


View Profile WWW
December 28, 2013, 04:53:58 AM
 #3095

thank you all for your responses both about DVC shares system, betting and ATM.

You say that the 96 shares for the first to make an open source DVC ATM machine should be only a side contribution. Moreover you want the ATM to run both ways (cash2dvc and dvc2cash).

I was pointed out that a one-way ATM will receive only half of the shares. I cannot stop to emphasise how hard it is to achieve such thing. The top todays manufacturers which are well funded, closed source and ship the ATM for freaking 4k$, only managed to build it one way. http://www.coindesk.com/lamassu-ships-first-bitcoin-atm/ .

If you really want to encourage me or others around to build an open source one, that cannot be done with a 'side contribution'.

I work in a makerspace, we are a no-profit association, and we do not have any plan of building a business model around the ATM . This is what will make it great. We won't sell it anywhere! We will just make it very easy to re-build with fine desigh, thourough documentation, open source software distribution, 3dprinted and lasercutted components, standard and available safety and electronic components.  This is the kind of project DVC should support, not some backed startups who already makes money by selling it and will 'just add DVC'.


My 2 DVC-cents.

Bitmessage : BM-NAx31aEiqeq5zKUtxhKscXQ7Dwn1jJfR
markm
Legendary
*
Offline Offline

Activity: 2618
Merit: 1038



View Profile WWW
December 28, 2013, 04:59:06 AM
 #3096

MIN_TX_FEE = MIN_RELAY_TX_FEE = 500,000,000 but in Twobits and Sidhujag values are
100,000,000 = COIN
Why ?

Twobits changed that without telling me. I didn't know because at the time we couldn't afford a code review. Now that blocks have been made with Twobit's lower transaction fee, the change must be kept and I will change the wiki documentation.

Why? Obviously the original / main client accepted the blocks that had the lower fee otherwise the blockchain the people using his version of the client would have forked away from the mainline blockchain.

Since it didn't obviously the old client accepted it.

The sooner we get it back to the correct value the better so we don't persist the error since we evidently do not need to cause it to persist.

(Especially if it is possible that one of these days it might end up creating a block that the original client, still in use probably for a long time to come by people who use what worked instead of trying out new versions to discover what new bugs have been introduced, might not accept. It seems like you are potentially trying to possibly blow away all the serious users who are conservative about sticking with what they know works instead of risking all on some new release. If it is not a deliberate hard-fork, fix it before it becomes one. The goal here is not to produce a hard-fork release, is it? If it is, then a block number far in the future should be chosen as the block at which it will come into effect.)

-MarkM-

Browser-launched Crossfire client now online (select CrossCiv server for Galactic  Milieu)
Free website hosting with PHP, MySQL etc: http://hosting.knotwork.com/
markm
Legendary
*
Offline Offline

Activity: 2618
Merit: 1038



View Profile WWW
December 28, 2013, 05:06:05 AM
 #3097

thank you all for your responses both about DVC shares system, betting and ATM.

You say that the 96 shares for the first to make an open source DVC ATM machine should be only a side contribution. Moreover you want the ATM to run both ways (cash2dvc and dvc2cash).

I was pointed out that a one-way ATM will receive only half of the shares. I cannot stop to emphasise how hard it is to achieve such thing. The top todays manufacturers which are well funded, closed source and ship the ATM for freaking 4k$, only managed to build it one way. http://www.coindesk.com/lamassu-ships-first-bitcoin-atm/ .

If you really want to encourage me or others around to build an open source one, that cannot be done with a 'side contribution'.

I work in a makerspace, we are a no-profit association, and we do not have any plan of building a business model around the ATM . This is what will make it great. We won't sell it anywhere! We will just make it very easy to re-build with fine desigh, thourough documentation, open source software distribution, 3dprinted and lasercutted components, standard and available safety and electronic components.  This is the kind of project DVC should support, not some backed startups who already makes money by selling it and will 'just add DVC'.


My 2 DVC-cents.

If the bounty is not yet sufficient, wait for the value per coin to make it sufficient or for our market cap due to sheer number more coins we have minted to make it feasible for us to offer a higher bounty?

Do we even have free open source 3D printers and laser-cutters yet?

If those are the tools you will be designing for maybe lets get those developed first?

-MarkM-

Browser-launched Crossfire client now online (select CrossCiv server for Galactic  Milieu)
Free website hosting with PHP, MySQL etc: http://hosting.knotwork.com/
Hunterbunter
Hero Member
*****
Offline Offline

Activity: 994
Merit: 1000


View Profile
December 28, 2013, 06:09:34 AM
 #3098

Some questions for the (armchair or otherwise) economists out there:

What is the intention behind used coins, when it comes to devcoins?

I should probably quantify what I mean by "used". It's those coins which people have purchased simply to inject cash into the devcoin system so developers can be paid - be they the devcoin admin team buying them from advertising revenue, or philanthropists which have more money than they know what to do with and wish to support open source development. They buy the earned coins off developers (giving them their pay), and then what? Is the intention for them to add them to wallets and leave them there forever?

What "use" are coins like these? A token to measure karma by before the gates of heaven?

Would it make sense to have a null pointer in the blockchain? a fixed address to which any coin sent to is destroyed forever? Or is the expectation that given enough time, those coins can come back in the form of development direction: the holder can direct productivity based on extra bounties for things they want to see done (that would actually make the most sense).

As I understand it, there is no destruction process so even if they are all put back on the market and crash the price to almost nothing for 2 months. Is this a possible way to temporarily hamstring progress on devtome (because no one wants to work if they think the coins are worth nothing)?

These people are different from speculators - people buying and holding hoping to sell for a profit, who ironically might be the buffer against this sort of attack.
markm
Legendary
*
Offline Offline

Activity: 2618
Merit: 1038



View Profile WWW
December 28, 2013, 06:32:27 AM
 #3099

The "latest rates include file", http://galaxies.mygamesonline.org/latestrates.inc uses DeVCoin as the unit of measure, as indicated by the fact that DVC appears as being a value (rate) of 1.00000000 in that file.

This has led to DVC being used as a "unit of account", for example a lot of loans are denominated in DVC now.

General Financial Corp alone has accounts receivable denominated in DeVCoins totalling 341391108170.02256199 DVC as of the plots and tables timestamped Sat Dec 28 01:55:50 AST 2013.

GFC itself had outstanding DeVCoin-denominated debt totalling 287239801234.20907405 DVC as of that same timestamp set of reports tables and plots.

A whole heck of a lot more DeVCoin need to be minted before such figures could ever be paid off in lump sums using DeVCoin, thus necessitating conversion rates between DeVCoin and other means of settlement, hence the latestrates.inc file.

-MarkM-




Browser-launched Crossfire client now online (select CrossCiv server for Galactic  Milieu)
Free website hosting with PHP, MySQL etc: http://hosting.knotwork.com/
weisoq
Hero Member
*****
Offline Offline

Activity: 720
Merit: 500


View Profile
December 28, 2013, 08:39:21 AM
Last edit: December 28, 2013, 12:13:34 PM by weisoq
 #3100

Thank you  Cheesy
Today I take a look in the account_31.csv but I'am only located one time in the file for trying the new Sidjuhag client.
I saw no mention yet for the code report  Shocked
I wrote during round 31 two short articles on devtome. If the word count is < to 1000 can I see my word count ? If the answer is affirmative in which file of the website Charity ?
The count will show on this file http://d.evco.in/charity/devtome_31.csv
You're not there yet, which will just be because it takes a while to get your address added to the receiver list and for an initial check of your articles. The round doesn't end until about 10th Jan but let us know is you're still not added before then, although I'm sure you will.
Pages: « 1 ... 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 [155] 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 ... 427 »
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!