flatfly
Legendary
Offline
Activity: 1092
Merit: 1016
760930
|
|
October 28, 2012, 10:27:17 AM |
|
Hi Thomas, congrats on the new release! Just thought I should mention that I get the below error upon starting electrum. type error, using default value [edit] this error only appears the very first time (when the blockchain_headers file doesn't exist yet) I don't think it is related. maybe you used an intermediate (github) version, and I changed the type of a variable you saved. Also, the GUI appears to be hanging during that this initial header validation process - perhaps a little progress dialog or status message would be more user-friendly (as most Windows users never use the console)
if you have lots of transactions, it might hang the gui for a few seconds, because it will redraw the history everytime a transaction is validated. however, the gui should not be slowed down during the headers download & validation phase. I have just updated my client from Github and tried to re-download the headers from scratch, and no longer encounter any issues! Thanks
|
|
|
|
flatfly
Legendary
Offline
Activity: 1092
Merit: 1016
760930
|
|
October 28, 2012, 11:44:05 AM Last edit: October 28, 2012, 02:56:54 PM by flatfly |
|
Unrelated to SPV - Does anyone also notice the below issue? it seems that when I connect to ecdsa.org, the list of available servers I see in the Server dialog is different than if I connect to uncle-enzo (for instance): [EDIT] Just a wild guess: Could it be due to ecdsa.org failing to join the #electrum channel?
|
|
|
|
ThomasV (OP)
Moderator
Legendary
Offline
Activity: 1896
Merit: 1353
|
|
October 28, 2012, 08:37:28 PM |
|
[EDIT] Just a wild guess: Could it be due to ecdsa.org failing to join the #electrum channel?
indeed that's the reason. if the client does cannot get the list from irc, it falls back to a hardcoded list of nodes.
|
Electrum: the convenience of a web wallet, without the risks
|
|
|
flatfly
Legendary
Offline
Activity: 1092
Merit: 1016
760930
|
|
October 28, 2012, 09:36:15 PM |
|
Seems that I'm getting an error whenever I make a transaction. (The tx goes through anyway) Example: Sending change to 1Pea... verify header: 000000000000032ed6a16300830b731f07ff09095559278bff988ea692db8957 205457 received error: {u'id': 26, u'error': u'not in a block: 734415a09e1663f55f01e501 a5a4839a7154c3fcb2c4e782044846dd6db92c60'}
|
|
|
|
ThomasV (OP)
Moderator
Legendary
Offline
Activity: 1896
Merit: 1353
|
|
October 29, 2012, 08:35:09 AM |
|
Seems that I'm getting an error whenever I make a transaction. (The tx goes through anyway)
oh right, that's a small bug. I just fixed it, try the latest git code.
|
Electrum: the convenience of a web wallet, without the risks
|
|
|
flatfly
Legendary
Offline
Activity: 1092
Merit: 1016
760930
|
|
October 29, 2012, 07:09:13 PM |
|
Seems that I'm getting an error whenever I make a transaction. (The tx goes through anyway)
oh right, that's a small bug. I just fixed it, try the latest git code. Thanks, I confirm I've got no more errors now So expect the first SPV-enabled build for Windows soon...
|
|
|
|
ThomasV (OP)
Moderator
Legendary
Offline
Activity: 1896
Merit: 1353
|
|
November 02, 2012, 09:04:43 AM |
|
Someone showed me that my current SPV implementation (in version 1.2) has a bug, and that it needs to be updated; the client needs to download its transactions in serialized form in order to ensure they have the correct hash. I will try to do this soon, but it might take some time, because it requires a modification in the protocol.
|
Electrum: the convenience of a web wallet, without the risks
|
|
|
ThomasV (OP)
Moderator
Legendary
Offline
Activity: 1896
Merit: 1353
|
|
November 04, 2012, 11:04:59 AM |
|
Someone showed me that my current SPV implementation (in version 1.2) has a bug, and that it needs to be updated; the client needs to download its transactions in serialized form in order to ensure they have the correct hash. I will try to do this soon, but it might take some time, because it requires a modification in the protocol.
This bug is fixed in the github repo. The fix comes along a protocol change, that will also fix the infamous "cannot spend coins" bug I will try to release version 1.3 tomorrow (the 1-year anniversary of Electrum!). Note that since the protocol has changed, new clients will only be able to connect to upgraded servers.
|
Electrum: the convenience of a web wallet, without the risks
|
|
|
flatfly
Legendary
Offline
Activity: 1092
Merit: 1016
760930
|
|
November 04, 2012, 01:36:12 PM |
|
Someone showed me that my current SPV implementation (in version 1.2) has a bug, and that it needs to be updated; the client needs to download its transactions in serialized form in order to ensure they have the correct hash. I will try to do this soon, but it might take some time, because it requires a modification in the protocol.
This bug is fixed in the github repo. The fix comes along a protocol change, that will also fix the infamous "cannot spend coins" bug I will try to release version 1.3 tomorrow (the 1-year anniversary of Electrum!). Note that since the protocol has changed, new clients will only be able to connect to upgraded servers. I'm getting this error at startup when trying the latest github code: Sun 11/04/2012 14:26:41.29> electrum Exception in thread Thread-2: Traceback (most recent call last): File "\Electrum_SysFiles\1.3\C_\Python27\lib\threading.py", line 551, in __bootstrap_inner self.run() File "\Electrum_SysFiles\1.3\C_\ElectrumPY\lib\wallet.py", line 947, in run if self.wallet.get_status(addr) != result: File "\Electrum_SysFiles\1.3\C_\ElectrumPY\lib\wallet.py", line 534, in get_status for tx_hash, height in h: ValueError: too many values to unpack
|
|
|
|
ThomasV (OP)
Moderator
Legendary
Offline
Activity: 1896
Merit: 1353
|
|
November 04, 2012, 02:49:04 PM |
|
I'm getting this error at startup when trying the latest github code: [...]
thanks for testing! try now, I fixed that
|
Electrum: the convenience of a web wallet, without the risks
|
|
|
flatfly
Legendary
Offline
Activity: 1092
Merit: 1016
760930
|
|
November 04, 2012, 04:00:03 PM |
|
I'm getting this error at startup when trying the latest github code: [...]
thanks for testing! try now, I fixed that No problem... Now I'm getting another error every few seconds. (This is with my existing wallet, while downloading/verifying the headers): Sun 11/04/2012 15:59:47.78> electrum Traceback (most recent call last): File "\Electrum_SysFiles\1.3\C_\ElectrumPY\lib\gui_qt.py", line 284, in update_wallet c, u = self.wallet.get_balance() File "\Electrum_SysFiles\1.3\C_\ElectrumPY\lib\wallet.py", line 425, in get_balance c, u = self.get_addr_balance(addr) File "\Electrum_SysFiles\1.3\C_\ElectrumPY\lib\wallet.py", line 415, in get_addr_balance v = self.get_tx_value(tx_hash, [addr]) File "\Electrum_SysFiles\1.3\C_\ElectrumPY\lib\wallet.py", line 383, in get_tx_value value = self.prevout_values[ key ] KeyError: '066fac23731c2f0384f3ad97c74e71e53758c3d37b6a9d12af5f39108e5f000b:1'
|
|
|
|
ThomasV (OP)
Moderator
Legendary
Offline
Activity: 1896
Merit: 1353
|
|
November 04, 2012, 04:18:57 PM |
|
No problem... Now I'm getting another error every few seconds. (This is with my existing wallet, while downloading/verifying the headers):
I was not able to reproduce it, but I fixed a possible race condition that could have caused it. please let me know if it is fixed
|
Electrum: the convenience of a web wallet, without the risks
|
|
|
flatfly
Legendary
Offline
Activity: 1092
Merit: 1016
760930
|
|
November 04, 2012, 04:40:48 PM |
|
No problem... Now I'm getting another error every few seconds. (This is with my existing wallet, while downloading/verifying the headers):
I was not able to reproduce it, but I fixed a possible race condition that could have caused it. please let me know if it is fixed yes this has fixed it! Well done. However, the client successfully downloads the headers but I still don't see any transactions on the history tab (and it's stuck on 'synchronizing'). When verbose mode on, it lists a bunch of missing transactions, but then I don't see any further network activity... I have to go now but might be back online later tonight (not sure yet).
|
|
|
|
ThomasV (OP)
Moderator
Legendary
Offline
Activity: 1896
Merit: 1353
|
|
November 06, 2012, 08:17:15 AM |
|
Hi,
I did not release version 1.3 yesterday as planned, because it needs a bit more testing (several bugs were fixed yesterday), and also because I would like to wait until a few more servers have upgraded to protocol version 0.5. (this is a major protocol change and 1.3 clients cannot use old servers; if you use the recent git version you will notice that the client does not even report the old servers).
In the meantime, many thanks to all the people who have been testing the git version. please keep reporting bugs!
|
Electrum: the convenience of a web wallet, without the risks
|
|
|
flatfly
Legendary
Offline
Activity: 1092
Merit: 1016
760930
|
|
November 06, 2012, 10:20:49 PM |
|
Good to see release 1.3 being right around the corner A minor thing: It seems the below option no longer works (electrum still seems to download & check the headers): electrum set disable_spv True
(Using the latest github master code)
|
|
|
|
bitcats
Legendary
Offline
Activity: 1014
Merit: 1001
|
|
November 07, 2012, 10:27:07 AM |
|
this is a major protocol change and 1.3 clients cannot use old servers; if you use the recent git version you will notice that the client does not even report the old servers).
What about the "old" servers? Can we still use the old clients?
|
"Unser Problem ist nicht ziviler Ungehorsam, unser Problem ist ziviler Gehorsam." - Howard Zinn
|
|
|
Tachikoma
|
|
November 07, 2012, 10:49:20 AM |
|
this is a major protocol change and 1.3 clients cannot use old servers; if you use the recent git version you will notice that the client does not even report the old servers).
What about the "old" servers? Can we still use the old clients? Old clients can use new and old servers as far as I am aware.
|
|
|
|
ThomasV (OP)
Moderator
Legendary
Offline
Activity: 1896
Merit: 1353
|
|
November 08, 2012, 02:50:30 PM |
|
Electrum 1.3 is officially released!
Changelog: * New client-server protocol, the client downloads raw transactions and deserializes them. * Simple Payments Verification (SPV) is now fixed. (the previous version had a vulnerability, reported by mhanne) * A file containing the blockchain headers is included in the package. * A new 'text-mode' user interface is available. It does not have as many features as the other GUIs, but it works and can be used if you don't have a graphical environment.
|
Electrum: the convenience of a web wallet, without the risks
|
|
|
ThomasV (OP)
Moderator
Legendary
Offline
Activity: 1896
Merit: 1353
|
|
November 08, 2012, 02:55:50 PM |
|
|
Electrum: the convenience of a web wallet, without the risks
|
|
|
ThomasV (OP)
Moderator
Legendary
Offline
Activity: 1896
Merit: 1353
|
|
November 08, 2012, 03:09:29 PM |
|
It seems the below option no longer works (electrum still seems to download & check the headers):
indeed, I had to remove that option, because Electrum now uses block headers to get the timestamps of transactions.
|
Electrum: the convenience of a web wallet, without the risks
|
|
|
|