Bitcoin Forum
December 11, 2016, 02:36:33 AM *
News: Latest stable version of Bitcoin Core: 0.13.1  [Torrent].
 
   Home   Help Search Donate Login Register  
Pages: « 1 ... 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 [733] 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 ... 830 »
  Print  
Author Topic: OFFICIAL CGMINER mining software thread for linux/win/osx/mips/arm/r-pi 4.9.2  (Read 4827752 times)
This is a self-moderated topic. If you do not want to be moderated by the person who started this topic, create a new topic.
rallasnackbar
Full Member
***
Offline Offline

Activity: 196


View Profile
March 07, 2014, 06:31:27 PM
 #14641

Anyone knows what causes this error, running raspberry pi with newest version of cgminer, and mining with bi*fury's


cgminer version 4.0.1 - Started: [2014-03-07 13:45:35]
(5s):10.43G (avg):10.29Gh/s I A:35532 R:84 HW:1 WU:145.7/m ST: 59 SS: 0 MB: 27 LW: 113898 GF: 0 RF: 0
Connected to uk1.ghash.io diff 12 with stratum as user
Block: 44170d05... Diff:3.81G Started: [17:40:01] Best share: 26.4X
[USB device management [P]ool management [Settings [D]isplay options [Q]uit

0: BXF 0: 41.5C I 5.299G/5.245Gh/s I A:18084 R:36 HW:0 WU:74.0/m
1: BXF 1: 38.4C I 5.130[14433.599787] Unable to handle kernel paging request at uirtual address 20626f6a
[14433.608374] pgd = d9e58000
[14433.611216] [20626f6a] *pgd=000000007 Diff 15/12 BXF 1
[14433.615990] Internal error: Dops: 5 [111] PREEMPT ARM 1
[2014-03-07 17:41:22] Accepted 08cd5d8a Diff 29/12 BXF 1
Entering kdb (current=0xd9e68000, pid 233) Oops: (null) 0
due to pops @ Oxc00eabd4ccepted Obf0c68e Diff 21/12 BXF 1
[2014-03-07 17:41:32] Accepted 12c87979 Diff 14/12 BXF 0
2dCPU: 0 PID: 233 Comm: wicd-monitor Not tainted 3.10.32-1-ARCH #1
Eldtask: d9e68000 ti: d9dce000 task.ti: d9dce0004/12 BXF 1
PC is at kmalloc_track_caller+Ox6c/OxlcOiff 14/12 BXF 1
LR is at kmalloctrack_ca11er+Ox50/0x1c0iff 20/12 BXF 1
pc : [<c00eabd4>] lr : [<c00eabb8>1 psr: 20000013 1
sp : d9dcfc80 ip : 00069c9b fp : 00053b7cff 29/12 BXF 1
r10: d9dce000 r9 : cO4de2c8 r8 : d9dce000ff 12/12 BXF 1
r7 : 00000140 r6 : 000106d0 r5 : 20626f6a r4 : da801c00
r3 : 00000000 r2 : 00000001 rl : 000106d0 1.0 : 00000000
Flags: nzCu IRQs on Figs on Mode SVC_32 ISA ARM Segment user
Control: 00c5387d Table: 19e58008 DAC: 00000015/12 BXF 1
dCPU: 0 ND: 233 Comm: wicd-monitor Not tainted 3.10.32-1-ARCH #1
[<c0013428>] (unwind_backtrace+Ox0/0xec) from [<c00112d0>] (show_stack+0x10/0x14) [<c00112d0] (show_stack+Ox10/0x14) from [<c007fbfc>] (kdb_dumpregs+0x28/0x50) [<c007fbfc>] (kdb_dumpregs+0x28/0x50) from [<c0082cfc>] (kdb_main_loop+Ox370/0x6bc) [<c0082cfc>] (kdb_main_loop+Ox370/0x6bc) from [<c00854c8>] (kdb_stub+0x164/0x380) more> =03-07 17:42:49] Accepted 113371b7 Diff 15/12 BXF 1
[2014-03-07 17:42:50] Accepted Oed5e5c0 Diff 17/12 BXF 1
[2014-03-07 17:42:57] Accepted Ocl2f819 Diff 21/12 BXF 0

Picture for better text. http://i.imgur.com/8muciXP.jpg
1481423793
Hero Member
*
Offline Offline

Posts: 1481423793

View Profile Personal Message (Offline)

Ignore
1481423793
Reply with quote  #2

1481423793
Report to moderator
1481423793
Hero Member
*
Offline Offline

Posts: 1481423793

View Profile Personal Message (Offline)

Ignore
1481423793
Reply with quote  #2

1481423793
Report to moderator
Advertised sites are not endorsed by the Bitcoin Forum. They may be unsafe, untrustworthy, or illegal in your jurisdiction. Advertise here.
-ck
Moderator
Legendary
*
Offline Offline

Activity: 2002


Ruu \o/


View Profile WWW
March 07, 2014, 09:33:18 PM
 #14642

Anyone knows what causes this error, running raspberry pi with newest version of cgminer, and mining with bi*fury's

Code:
1: BXF 1: 38.4C I 5.130[14433.599787] Unable to handle kernel paging request at uirtual address 20626f6a
[14433.608374] pgd = d9e58000
[14433.611216] [20626f6a] *pgd=000000007 Diff 15/12 BXF 1
[14433.615990] Internal error: Dops: 5 [111] PREEMPT ARM 1
[2014-03-07 17:41:22] Accepted 08cd5d8a Diff 29/12 BXF 1
Entering kdb (current=0xd9e68000, pid 233) Oops: (null) 0
due to pops @ Oxc00eabd4ccepted Obf0c68e Diff 21/12 BXF 1
[2014-03-07 17:41:32] Accepted 12c87979 Diff 14/12 BXF 0
2dCPU: 0 PID: 233 Comm: wicd-monitor Not tainted 3.10.32-1-ARCH #1
Eldtask: d9e68000 ti: d9dce000 task.ti: d9dce0004/12 BXF 1
PC is at kmalloc_track_caller+Ox6c/OxlcOiff 14/12 BXF 1
LR is at kmalloctrack_ca11er+Ox50/0x1c0iff 20/12 BXF 1
pc : [<c00eabd4>] lr : [<c00eabb8>1 psr: 20000013 1
sp : d9dcfc80 ip : 00069c9b fp : 00053b7cff 29/12 BXF 1
r10: d9dce000 r9 : cO4de2c8 r8 : d9dce000ff 12/12 BXF 1
r7 : 00000140 r6 : 000106d0 r5 : 20626f6a r4 : da801c00
r3 : 00000000 r2 : 00000001 rl : 000106d0 1.0 : 00000000
Flags: nzCu IRQs on Figs on Mode SVC_32 ISA ARM Segment user
Control: 00c5387d Table: 19e58008 DAC: 00000015/12 BXF 1
dCPU: 0 ND: 233 Comm: wicd-monitor Not tainted 3.10.32-1-ARCH #1
[<c0013428>] (unwind_backtrace+Ox0/0xec) from [<c00112d0>] (show_stack+0x10/0x14) [<c00112d0] (show_stack+Ox10/0x14) from [<c007fbfc>] (kdb_dumpregs+0x28/0x50) [<c007fbfc>] (kdb_dumpregs+0x28/0x50) from [<c0082cfc>] (kdb_main_loop+Ox370/0x6bc) [<c0082cfc>] (kdb_main_loop+Ox370/0x6bc) from [<c00854c8>] (kdb_stub+0x164/0x380) more> =03-07 17:42:49] Accepted 113371b7 Diff 15/12 BXF 1

That is a linux kernel, aka operating system, crash message unrelated to the cgminer code but mixed in with the cgminer output. Only an operating system upgrade/downgrade/kernel package fix can make it better.

Primary developer/maintainer for cgminer and ckpool/ckproxy.
Pooled mine at kano.is, solo mine at solo.ckpool.org
-ck
HellDiverUK
Hero Member
*****
Offline Offline

Activity: 574


View Profile
March 07, 2014, 10:11:35 PM
 #14643

Anyone knows what causes this error, running raspberry pi with newest version of cgminer, and mining with bi*fury's


cgminer version 4.0.1 - Started: [2014-03-07 13:45:35]
(5s):10.43G (avg):10.29Gh/s I A:35532 R:84 HW:1 WU:145.7/m ST: 59 SS: 0 MB: 27 LW: 113898 GF: 0 RF: 0
Connected to uk1.ghash.io diff 12 with stratum as user


You're trying to mine with a toy on a shit pool.  There's your two errors.
kano
Legendary
*
Offline Offline

Activity: 1932


Linux since 1997 RedHat 4


View Profile
March 07, 2014, 10:18:48 PM
 #14644

Anyone knows what causes this error, running raspberry pi with newest version of cgminer, and mining with bi*fury's
...
Looks like it's most likely a problem with the SD card
Get a new one and ensure you are using latest cgminer.

Pool: https://kano.is BTC: 1KanoiBupPiZfkwqB7rfLXAzPnoTshAVmb
CKPool and CGMiner developer, IRC FreeNode #ckpool and #cgminer kanoi
Help keep Bitcoin secure by mining on pools with Stratum, the best protocol to mine Bitcoins with ASIC hardware
coretechs
Donator
Sr. Member
*
Offline Offline

Activity: 362



View Profile
March 07, 2014, 10:24:54 PM
 #14645

For sure that will reduce overall cpu usage with 20-30% that is what i observe on my tplinks


That fixed it, thanks.  After disabling LOCK_TRACKING 4.0.1 is now running at a very steady 11% on my system, which is actually a nice improvement over 3.9.   Smiley

http://bitcoindoc.com - The Rise and Rise of Bitcoin | http://nxtportal.org - Nxt blockchain explorer
-ck
Moderator
Legendary
*
Offline Offline

Activity: 2002


Ruu \o/


View Profile WWW
March 08, 2014, 04:42:54 AM
 #14646

New version: 4.1.0, 8th March 2014

A stable and bugfix release with new drivers. I recommend all 4.x users update.

Human readable changelog:

- Zero stats will now show the correct average hashrate per device.
- Fixed the high CPU usage which led to eventually slowing down of hashrates over time.
- Respect the -Q value by slightly changing its meaning to be the highest value it can reach, defaulting to 9999. Regular users need not do anything with this value.
- Fixed the hex32 api values (currently only hashfast serial number) returning invalid JSON over the API.
- New driver - BXM for an upcoming two bitfury chip USB stick courtesy of Goodney, along with an overclocking option with --bxm-bits
- New driver - merged the bitmain S1 driver
- Try harder to shut cgminer down fully on quit/restart/--shares end.
- Fix cgminer shutting down and hanging when a grossly invalid stratum message is received.
- Fix cointerra hashrate display to show a share based hashrate so that the displayed hashrate should match the pool hashrate.
- Hashfast improvements:
. Dramatic decrease in CPU usage for all existing firmwares since they don't internally nroll time.
. Latest version now works with older 0.2 firmwares
. Only decrease the clockspeed if a device fails in less than an hour at its current clockspeed
. New feature allows per-device settings:
Code:
--hfa-options <arg> Set hashfast options name:clock (comma separated)

This command allows you to set options for each discrete hashfast device by
its name (if the firmware has naming support, i.e. version 0.3+). Currently
this takes only one option, the clock speed, although future options may be
added.
e.g.:
--hfa-options "rabbit:650,turtle:550"

Would set a device named rabbit to clock speed 650 and the one named turtle to
550. Starting the device at a speed where it is most stable will give more
reliable hashrates long term and prevent it interacting with other devices,
rather than depending on the clockdown feature in cgminer.
- Other low level bugfixes and improvements and anticipatory changes.


Full changelog:

- Correct fix for dev start time being adjusted for stat zeroing.
- Make per device stats work for average after a stat zeroing.
- Add an hfa-options command line that allows the clockspeed to be chosen per
device by name comma separated, with a function that can be expanded with more
options in the future.
- Off by one drv_rolllimit check against jobs
- Free the work that may be lost, leaking memory, in a failed hfa_send_frame
- Roll the ntime for work within the hfa driver for firmware we know doesn't do
it internally as an optimisation.
- Export the roll_work function to be usable by driver code and make it
compatible with rolling stratum work.
- Make opt_queue be respected as a maximum value for staged items.
- Disable mistakenly enabled lock tracking.
- api version update for HEX32
- api.c - HEX32 type needs quotes
- Disable the MAX_CLOCK_DIFF check for newer hashfast firmwares since it's not
required.
- Store the hardware and firmware revision in the info struct for easy use in
the hfa driver.
- Only decrease the hfa clock rate if the device has been running for less than
an hour before dying.
- Change lack of op name response message in hfa driver
- Check for lost devices at every write/read in hfa_detect_common
- Make bxm bits configurable.
- Move avalon2 options to ~alphabetic position in help.
- Do a shutdown routine on bxm close.
- Provide support for 2 chips in libbitfury sendhashdata and enable the 2nd chip
on BXM devices.
- Remove unnecessary opayload and newbuf members of bitfury info struct.
- Add an spi add fasync command.
- Cope with older hfa firmware not even responding to op_name.
- Forcibly kill everything silently with an exit code of 1 should we fail to
cleanly shut down and use a completion timeout for the __kill_work in
app_restart.
- Make __kill_work itself also be a completion timeout.
- Generalise more of libbitfury for more reuse in both nf1 and bxm drivers.
- Remove redundant init components of bxm driver.
- Set default osc6 bits on bxm to 50
- Enable the transaction translator emulator for bxm devices and use a dummy spi
tx the size of a normal payload.
- Store usb11 and tt flags as booleans in cgusbdev allowing them to be
discretely enabled as well as detected by the device data.
- Add bxm scan function and check spi txrx returns only as much as sent.
- Add init sequence to bxm detect one.
- Add a bxm specific txrx function for spi transfers.
- Add bxm close to bitfury shutdown switch.
- Add reset/purge/cshigh/low sequence to bxm init
- Add bitmode init to bxm open sequence.
- Add initial bxm opening sequence for detect one.
- Add identifiers for bxm bitfury devices.
- Clean up parse_method
- More gracefully break out of parse_notify on a corrupted hex string error,
checking the return value of all hex2bin conversions and being consistent with
using stack memory. Fix an unlocking error in cases of failure.
- AntS1 - add detection information to usbutils
- Enable Bitmain Ant S1 code and make it conform to cgminer requirements
- Make the cointerra displayed hashrate based on valid share generation.
- Convert and update values shown in the cointerra api output.
- Export the api_add_int16 function.
- Use a custom mystrstr function in cointerra driver.
- Add api_add_int16 to API functions.
- Add support for Bitmain Multi Chain and Single Chain and optimize the
efficiency
- Add support for bitmain devices
- Perfect function of BitMain Multi Chain
- Add support for Bitmain Multi Chain and Single Chain and optimize the
efficiency
- Add support for bitmain devices

Primary developer/maintainer for cgminer and ckpool/ckproxy.
Pooled mine at kano.is, solo mine at solo.ckpool.org
-ck
KyrosKrane
Sr. Member
****
Offline Offline

Activity: 292


View Profile WWW
March 08, 2014, 06:31:21 AM
 #14647

Quick question about compiling cgminer, please.  I tweak a few of the constants in the Klondike driver for use with my devices, and I recompile every couple of days, trying different things.  Since I'm using an RPi, compiling takes about 30-45 minutes total. Right now, I use a small shell script with the following lines, based on a combination of advice from Kano's blog post and a troubleshooting guide I use for Klondikes:

Code:
cd ~/cgminer
git pull
CFLAGS="-g -W -Wall" ./autogen.sh
./configure --enable-icarus --enable-klondike
make clean
make

Obviously, this takes a while to run. How much of this has to be rerun every time I tweak the code, and how much of it only needs to be run once?

Thanks.

Tips and donations: 1KyrosREGDkNLp1rMd9wfVwfkXYHTd6j5U  |  BTC P2Pool node: p2pool.kyros.info:9332
-ck
Moderator
Legendary
*
Offline Offline

Activity: 2002


Ruu \o/


View Profile WWW
March 08, 2014, 08:12:02 AM
 #14648

Quick question about compiling cgminer, please.  I tweak a few of the constants in the Klondike driver for use with my devices, and I recompile every couple of days, trying different things.  Since I'm using an RPi, compiling takes about 30-45 minutes total. Right now, I use a small shell script with the following lines, based on a combination of advice from Kano's blog post and a troubleshooting guide I use for Klondikes:

Code:
cd ~/cgminer
git pull
CFLAGS="-g -W -Wall" ./autogen.sh
./configure --enable-icarus --enable-klondike
make clean
make

Obviously, this takes a while to run. How much of this has to be rerun every time I tweak the code, and how much of it only needs to be run once?

Thanks.
autogen is only rarely required with a significant git update so you can skip that and do CFLAGS="-g -W -Wall -O2" ./configure --enable-icarus --enable-klondike
I note you're not adding any optimisation flags like O2 but you probably should unless you're debugging a real issue.

Primary developer/maintainer for cgminer and ckpool/ckproxy.
Pooled mine at kano.is, solo mine at solo.ckpool.org
-ck
KyrosKrane
Sr. Member
****
Offline Offline

Activity: 292


View Profile WWW
March 08, 2014, 12:13:40 PM
 #14649

Quick question about compiling cgminer, please.  I tweak a few of the constants in the Klondike driver for use with my devices, and I recompile every couple of days, trying different things.  Since I'm using an RPi, compiling takes about 30-45 minutes total. Right now, I use a small shell script with the following lines, based on a combination of advice from Kano's blog post and a troubleshooting guide I use for Klondikes:

Code:
cd ~/cgminer
git pull
CFLAGS="-g -W -Wall" ./autogen.sh
./configure --enable-icarus --enable-klondike
make clean
make

Obviously, this takes a while to run. How much of this has to be rerun every time I tweak the code, and how much of it only needs to be run once?

Thanks.
autogen is only rarely required with a significant git update so you can skip that and do CFLAGS="-g -W -Wall -O2" ./configure --enable-icarus --enable-klondike
I note you're not adding any optimisation flags like O2 but you probably should unless you're debugging a real issue.
Awesome, thanks! I'll give it a try with 4.1.0.

Like I said, I'm a newb at compilation.  I was going by the instructions in the two linked guides.  I noted that in the README file, you have:

CFLAGS="-O2 -Wall -march=native" ./configure ...

But I honestly don't know what the various CFLAGS values do.  Hence I figured it's safer to go with what others have confirmed works on a Pi, at least until I learn more about the flags.

Tips and donations: 1KyrosREGDkNLp1rMd9wfVwfkXYHTd6j5U  |  BTC P2Pool node: p2pool.kyros.info:9332
Karin
Member
**
Offline Offline

Activity: 109



View Profile WWW
March 08, 2014, 05:11:52 PM
 #14650

Unofficial Mac binaries have been updated for v4.1.0, and are available here.

These are precompiled universal binaries that support Mac OS X 10.5.8 through 10.9+.

Easiest to use bitcoin/litecoin miner for Mac: AsteroidApp.com | @AsteroidApp | Bitcointalk forum thread
Unofficial cgminer for Mac OS X | sgminer for Mac OS X
techman05
Hero Member
*****
Offline Offline

Activity: 546


View Profile WWW
March 08, 2014, 08:55:25 PM
 #14651

Ckolivias, when you get a chance could you check your windows cross compile text file to see if there is something not listed I need to do. When I run it through as written I get a cannot find version of curl needed and when I point it to where curl is in the win deps folder it then says compiler doesn't work.

Also maybe if your using mxe cross compiler add some details to how to use that. There's a tutorial for it but I'm not sure where the intended program to compiles goes and if the win deps folder can be used or have to copy all of that into a specific folder.

Thanks ahead of time.

Like the info address for potential tips Wink
BTC 1CL5BnNhdL2wDVmSDwMbW1cNhZew87CAPV
* http://www.miningrigrentals.com/register?ref=563
deagel
Member
**
Offline Offline

Activity: 67


View Profile
March 09, 2014, 04:31:39 PM
 #14652

hi,
how can i update the cgminer version from a antminer s1? Normally the software is deployed with a new firmware.

thanks
Buchi-88
Legendary
*
Offline Offline

Activity: 1092


My Solo Block: 401934


View Profile
March 09, 2014, 08:38:06 PM
 #14653

The new CGMiner also support the new Antminer U2?

I mean yes, only the Heatsink is new?

regards


                ,╓▄▄▄▄▄▄▄▄▄╓                 
            ╓▄█████████████████▄╖           
         ╓▄█████▀▀'▒,,,,,╠'▀▀█████▄,         
       ,▓███▀╜,▄▄███████████▄▄,╙▀████╖       
      ▄███▀ ▄█████▀▀"``╙"▀▀█████▄ ▀███▄     
     ▓███╜╓████▀ ,▄▄█████▄▄, ▀████,╙███▌     
    ▓███`╔███▀ ╓▓███▀▀▀▀▀████╖ ▀███@"███▌   
   ]███▌┌███▌ ▐███         ███▄ ▐███ ▐███,   
   ▐███ ▐███ .███           ███  ███▌ ███▌   
   ▐███ ▐███ '███           ███  ███▌ ███▌   
   ]███@╙███@ ▀██▌        ,▄██▌ ▐███ ▐███`   
    ▓███ ▐███▄ ╙██▀╩     9███╜ ╔███▀,███▌   
     ████,╙███▌               ▓███╜,████     
      ▀███▄ ▀╜                 ▀▀ ▄███▌     
       ╙████▄,                 ╓▄████╜       
         ╙█████▄▄╓,       ,╓▄▄█████▀         
            ▀▀█████████████████▀▀           
                '▀▀▀▀▀▀▀▀▀▀▀'

CloakCoin |  Trustless Anonymous Cryptocurrency |  PoSA3
Forum | Bitcointalk | Twitter | Slack |  Facebook |  VK |  Reddit |  CloakTV |  Instagram |  IRC-Chat |  Faucet
kano
Legendary
*
Offline Offline

Activity: 1932


Linux since 1997 RedHat 4


View Profile
March 09, 2014, 09:46:13 PM
 #14654

hi,
how can i update the cgminer version from a antminer s1? Normally the software is deployed with a new firmware.

thanks
Yeah I can build binaries and ipk files now.
I'm not 100% sure of building a complete firmware file, that will come a little later.

The luci web code that displays the stats doesn't work with the correct API code, so I'll see if I can sort that out today and hack a binary that works with both the luci code and of course includes the correct API output for anyone who accesses it.

Pool: https://kano.is BTC: 1KanoiBupPiZfkwqB7rfLXAzPnoTshAVmb
CKPool and CGMiner developer, IRC FreeNode #ckpool and #cgminer kanoi
Help keep Bitcoin secure by mining on pools with Stratum, the best protocol to mine Bitcoins with ASIC hardware
kano
Legendary
*
Offline Offline

Activity: 1932


Linux since 1997 RedHat 4


View Profile
March 09, 2014, 09:48:49 PM
 #14655

The new CGMiner also support the new Antminer U2?

I mean yes, only the Heatsink is new?

regards
Try it and let us know Smiley
We don't have any U2's but I think they are the same with just a better heat sink?

Pool: https://kano.is BTC: 1KanoiBupPiZfkwqB7rfLXAzPnoTshAVmb
CKPool and CGMiner developer, IRC FreeNode #ckpool and #cgminer kanoi
Help keep Bitcoin secure by mining on pools with Stratum, the best protocol to mine Bitcoins with ASIC hardware
-ck
Moderator
Legendary
*
Offline Offline

Activity: 2002


Ruu \o/


View Profile WWW
March 09, 2014, 09:50:52 PM
 #14656

The new CGMiner also support the new Antminer U2?

I mean yes, only the Heatsink is new?
Try it and let us know Smiley
We don't have any U2's but I think they are the same with just a better heat sink?

Ive got a few boxes of these on hand.... pretty nice.
Of the U2s?  hows the software support? do they use the same software as the prior versions?

Theoretically they're supposed to run identical software to the U1s which cgminer has full support for.

Does anyone know how to overclock them? It seems it works different than the U1, at least I am not able to OC them yet.

If they run the same as the U1 then it would take the same cgminer parameter to overclock it, i.e. adding '--anu-freq 250' would make them run at 2GH

Primary developer/maintainer for cgminer and ckpool/ckproxy.
Pooled mine at kano.is, solo mine at solo.ckpool.org
-ck
loshia
Legendary
*
Offline Offline

Activity: 1372


View Profile
March 10, 2014, 12:26:30 PM
 #14657

Hello Con,

I might be wrong but i found a possible memleak in

void roll_work(struct work *work)...

More info

   if (work->ntime)
      work->ntime = offset_ntime(work->ntime, 1);
should be something like

   if (work->ntime) {
      char *memleak = work->ntime;
      work->ntime = offset_ntime(work->ntime, 1);
      free(memleak);
  }

as long as offset_ntime returns new pointer and old work->ntime pointer is lost and never freed on free_work call

PS: consider it as confirmed and fixed Wink My tplinks are a lot mare happy with the above fix. Everything is working fine and most important memory is not leaking

Please help the Led Boy aka Bicknellski to make us a nice Christmas led tree and pay WASP membership fee here:
https://bitcointalk.org/index.php?topic=643999.msg7191563#msg7191563
And remember Bicknellski is not collecting money from community;D
-ck
Moderator
Legendary
*
Offline Offline

Activity: 2002


Ruu \o/


View Profile WWW
March 10, 2014, 01:17:53 PM
 #14658

Hello Con,

I might be wrong but i found a possible memleak in

void roll_work(struct work *work)...

More info

   if (work->ntime)
      work->ntime = offset_ntime(work->ntime, 1);
should be something like

   if (work->ntime) {
      char *memleak = work->ntime;
      work->ntime = offset_ntime(work->ntime, 1);
      free(memleak);
  }

as long as offset_ntime returns new pointer and old work->ntime pointer is lost and never freed on free_work call

PS: consider it as confirmed and fixed Wink My tplinks are a lot mare happy with the above fix. Everything is working fine and most important memory is not leaking

Good catch, looks valid, thanks!

EDIT: Fixed in git, along with an opportunity for a further optimisation.

Primary developer/maintainer for cgminer and ckpool/ckproxy.
Pooled mine at kano.is, solo mine at solo.ckpool.org
-ck
loshia
Legendary
*
Offline Offline

Activity: 1372


View Profile
March 10, 2014, 01:35:35 PM
 #14659

Hello Con,

I might be wrong but i found a possible memleak in

void roll_work(struct work *work)...

More info

   if (work->ntime)
      work->ntime = offset_ntime(work->ntime, 1);
should be something like

   if (work->ntime) {
      char *memleak = work->ntime;
      work->ntime = offset_ntime(work->ntime, 1);
      free(memleak);
  }

as long as offset_ntime returns new pointer and old work->ntime pointer is lost and never freed on free_work call

PS: consider it as confirmed and fixed Wink My tplinks are a lot mare happy with the above fix. Everything is working fine and most important memory is not leaking

Good catch, looks valid, thanks!

EDIT: Fixed in git, along with an opportunity for a further optimisation.
thanks!!!!

Please help the Led Boy aka Bicknellski to make us a nice Christmas led tree and pay WASP membership fee here:
https://bitcointalk.org/index.php?topic=643999.msg7191563#msg7191563
And remember Bicknellski is not collecting money from community;D
os2sam
Legendary
*
Offline Offline

Activity: 1918


Think for yourself


View Profile
March 10, 2014, 01:39:02 PM
 #14660

EDIT: Fixed in git, along with an opportunity for a further optimisation.

Any optimizations to help Block Erupters? Still not quite stable for me, 4.x that is.

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on usenet and in e-mail?
Pages: « 1 ... 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 [733] 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 ... 830 »
  Print  
 
Jump to:  

Sponsored by , a Bitcoin-accepting VPN.
Powered by MySQL Powered by PHP Powered by SMF 1.1.19 | SMF © 2006-2009, Simple Machines Valid XHTML 1.0! Valid CSS!